[Vertical Tabs] Allow OOB Mouse Drag Scroll [chromium/src : main]
0 views
Skip to first unread message
Gazal Agarwal (Gerrit)
2:16 PM (3 hours ago) 2:16 PM
to Jack Thiesen, Calder Kitagawa, Chromium LUCI CQ, chromium...@chromium.org, davidj...@chromium.org, gogeral...@chromium.org, hanxi...@chromium.org, mattsimm...@chromium.org, meilian...@chromium.org, wychen...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org
Attention needed from Calder Kitagawa and Jack Thiesen
Gazal Agarwal voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Calder Kitagawa
- Jack Thiesen
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Calder Kitagawa (Gerrit)
2:34 PM (3 hours ago) 2:34 PM
to Jack Thiesen, Gazal Agarwal, Chromium LUCI CQ, chromium...@chromium.org, davidj...@chromium.org, gogeral...@chromium.org, hanxi...@chromium.org, mattsimm...@chromium.org, meilian...@chromium.org, wychen...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org
Attention needed from Jack Thiesen
Calder Kitagawa voted and added 1 comment![]( "Open in Gerrit")
Votes added by Calder Kitagawa
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Jack Thiesen
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gazal Agarwal (Gerrit)
2:41 PM (3 hours ago) 2:41 PM
to Jack Thiesen, Calder Kitagawa, Chromium LUCI CQ, chromium...@chromium.org, davidj...@chromium.org, gogeral...@chromium.org, hanxi...@chromium.org, mattsimm...@chromium.org, meilian...@chromium.org, wychen...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org
Attention needed from Jack Thiesen
Gazal Agarwal voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Jack Thiesen
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
2:46 PM (3 hours ago) 2:46 PM
to Jack Thiesen, Gazal Agarwal, Calder Kitagawa, chromium...@chromium.org, davidj...@chromium.org, gogeral...@chromium.org, hanxi...@chromium.org, mattsimm...@chromium.org, meilian...@chromium.org, wychen...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[Vertical Tabs] Allow OOB Mouse Drag Scroll
Allow cursor drags to trigger an out-of-bounds scroll. Additionally
disable the OnMoved() block for mouse as a followup bugfix.
Bug: 518307037
Change-Id: If50d7fff0541b378745661d147edfecd91f346e8
Commit-Queue: Gazal Agarwal <aga...@google.com>
Reviewed-by: Gazal Agarwal <aga...@google.com>
Commit-Queue: Jack Thiesen <jthi...@chromium.org>
Reviewed-by: Calder Kitagawa <ckit...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1659731}
Files:
- M chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabListItemTouchHelperCallback.java
- M chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/vertical_tabs/VerticalTabListItemTouchHelperCallback.java
Change size: S
Delta: 2 files changed, 37 insertions(+), 7 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Gazal Agarwal, +1 by Calder Kitagawa
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages