Use Feature flag to control whether to show Query Tiles [chromium/src : main]

Min Qin (Gerrit)

unread,

Aug 1, 2022, 9:31:31 PM8/1/22

to davidj...@chromium.org, gogeral...@chromium.org, hanxi...@chromium.org, mattsimm...@chromium.org, meilian...@chromium.org, spdongh...@chromium.org, wychen...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org, Xi Han, David Trainor, chromium...@chromium.org

Attention is currently required from: David Trainor, Xi Han.

View Change

1 comment:

Patchset:
- Patch Set #1:
  PTAL

To view, visit change 3803799. To unsubscribe, or for help writing mail filters, visit settings.

David Trainor (Gerrit)

unread,

Aug 5, 2022, 1:48:45 AM8/5/22

to Min Qin, davidj...@chromium.org, gogeral...@chromium.org, hanxi...@chromium.org, mattsimm...@chromium.org, meilian...@chromium.org, spdongh...@chromium.org, wychen...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org, Tricium, Xi Han, chromium...@chromium.org

Attention is currently required from: Min Qin, Xi Han.

Patch set 1:Code-Review +1

View Change

To view, visit change 3803799. To unsubscribe, or for help writing mail filters, visit settings.

Min Qin (Gerrit)

unread,

Aug 9, 2022, 1:03:20 AM8/9/22

to davidj...@chromium.org, gogeral...@chromium.org, hanxi...@chromium.org, mattsimm...@chromium.org, meilian...@chromium.org, spdongh...@chromium.org, wychen...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org, David Trainor, Tricium, Xi Han, chromium...@chromium.org

Attention is currently required from: Min Qin, Xi Han.

Patch set 1:Commit-Queue +2

View Change

To view, visit change 3803799. To unsubscribe, or for help writing mail filters, visit settings.

Chromium LUCI CQ (Gerrit)

unread,

Aug 9, 2022, 2:38:59 AM8/9/22

to Min Qin, davidj...@chromium.org, gogeral...@chromium.org, hanxi...@chromium.org, mattsimm...@chromium.org, meilian...@chromium.org, spdongh...@chromium.org, wychen...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org, David Trainor, Tricium, Xi Han, chromium...@chromium.org

Chromium LUCI CQ submitted this change.

View Change

Approvals:
  Min Qin: Commit
  David Trainor: Looks good to me

Use Feature flag to control whether to show Query Tiles

Currently QueryTiles on start surface is controled by a param
This CL will change it to use a cached flag, so it can decouple from
start surface.

Change-Id: I99affbe0f97d400bf991f471a696d6f91201070a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3803799
Reviewed-by: David Trainor <dtra...@chromium.org>
Commit-Queue: Min Qin <qin...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1032892}
---
M chrome/android/features/start_surface/java/src/org/chromium/chrome/features/start_surface/StartSurfaceConfiguration.java
M chrome/android/features/start_surface/java/src/org/chromium/chrome/features/start_surface/StartSurfaceCoordinator.java
M chrome/android/java/src/org/chromium/chrome/browser/app/flags/ChromeCachedFlags.java
M chrome/browser/flags/android/chrome_feature_list.cc
M chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/CachedFeatureFlags.java
M chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/ChromeFeatureList.java
M components/query_tiles/switches.cc
M components/query_tiles/switches.h
8 files changed, 30 insertions(+), 8 deletions(-)

To view, visit change 3803799. To unsubscribe, or for help writing mail filters, visit settings.

Xi Han (Gerrit)

unread,

Aug 10, 2022, 1:52:17 PM8/10/22

to Min Qin, Chromium LUCI CQ, davidj...@chromium.org, gogeral...@chromium.org, hanxi...@chromium.org, mattsimm...@chromium.org, meilian...@chromium.org, spdongh...@chromium.org, wychen...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org, David Trainor, Tricium, chromium...@chromium.org

Patch set 2:Code-Review +1

View Change

1 comment:

Patchset:
- Patch Set #2:
  Thanks for making this change!

To view, visit change 3803799. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward