Reland "Reland "Remove callback_helpers.h include from is_callback.h"" [chromium/src : main]
0 views
Skip to first unread message
Lei Zhang (Gerrit)
Dec 5, 2025, 9:13:13 PM (6 hours ago) Dec 5
to Lei Zhang, Chromium LUCI CQ, Daniel Cheng, AyeAye, chromium...@chromium.org, cc-...@chromium.org, dmurph+watching...@chromium.org, halliwe...@chromium.org, dmurph+watch...@chromium.org, edgesto...@microsoft.com, storage...@chromium.org, feature-me...@chromium.org
Attention needed from Daniel Cheng
Lei Zhang added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Lei Zhang . resolved
Third try over the weekend for the win? Please OO+1.
Related details
Attention is currently required from:
- Daniel Cheng
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel Cheng (Gerrit)
12:55 AM (2 hours ago) 12:55 AM
to Lei Zhang, Daniel Cheng, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, cc-...@chromium.org, dmurph+watching...@chromium.org, halliwe...@chromium.org, dmurph+watch...@chromium.org, edgesto...@microsoft.com, storage...@chromium.org, feature-me...@chromium.org
Attention needed from Lei Zhang
Daniel Cheng voted![]( "Open in Gerrit")
Attention is currently required from:
- Lei Zhang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
12:59 AM (2 hours ago) 12:59 AM
to Lei Zhang, Daniel Cheng, AyeAye, chromium...@chromium.org, cc-...@chromium.org, dmurph+watching...@chromium.org, halliwe...@chromium.org, dmurph+watch...@chromium.org, edgesto...@microsoft.com, storage...@chromium.org, feature-me...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Reland "Reland "Remove callback_helpers.h include from is_callback.h""
This is a reland of commit 9bd2be2d8d0c435542afc2e59f128b8e9ef23496
Added missing include to fix collision with crrev.com/1554986.
Original change's description:
> Reland "Remove callback_helpers.h include from is_callback.h"
>
> This is a reland of commit fab09e07f02d2033bd32ea32758d0f41e8312f51
>
> Added more missing includes to fix the Linux CFM bot.
>
> Original change's description:
> > Remove callback_helpers.h include from is_callback.h
> >
> > This temporary include existed to help safely land the CL that added
> > is_callback.h. Now that is_callback.h is in the code base, remove this
> > crutch.
> >
> > Change-Id: I2b457b73e799ee7226c5476cdcc9c48d9c8c3e3d
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7224760
> > Commit-Queue: Daniel Cheng <dch...@chromium.org>
> > Commit-Queue: Lei Zhang <the...@chromium.org>
> > Owners-Override: Daniel Cheng <dch...@chromium.org>
> > Reviewed-by: Daniel Cheng <dch...@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#1554466}
>
> Change-Id: Ib117b0e6f46c5593b677fbca15d242c9c5e1cadf
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7230701
> Owners-Override: Daniel Cheng <dch...@chromium.org>
> Reviewed-by: Daniel Cheng <dch...@chromium.org>
> Commit-Queue: Lei Zhang <the...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1554999}
Change-Id: Ief251126335eedb9209edcb4b80dd2c504226374
Owners-Override: Daniel Cheng <dch...@chromium.org>
Reviewed-by: Daniel Cheng <dch...@chromium.org>
Commit-Queue: Daniel Cheng <dch...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1555060}
Files:
- M base/functional/is_callback.h
- M chrome/browser/ash/chromebox_for_meetings/artemis/local_data_source_unittest.cc
- M chrome/browser/ash/chromebox_for_meetings/artemis/log_source_unittest.cc
- M chrome/browser/ash/chromebox_for_meetings/artemis/test_data_aggregator_service.cc
- M chromecast/cast_core/runtime/browser/message_port_handler.cc
- M chromecast/media/audio/cast_audio_manager_android.cc
- M components/breadcrumbs/core/application_breadcrumbs_logger_unittest.cc
- M components/services/storage/dom_storage/session_storage_namespace_impl.cc
- M components/viz/service/transitions/transferable_resource_tracker_unittest.cc
Change size: S
Delta: 9 files changed, 9 insertions(+), 4 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Daniel Cheng
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages