webnn: ensure EP selection only considers compiler-eligible devices [chromium/src : main]

0 views
Skip to first unread message

Zou, Shiyi (Gerrit)

unread,
Jul 21, 2026, 3:00:12 AM (4 days ago) Jul 21
to Hu, Ningxin, Rafael Cintron, chromium...@chromium.org, Jiewei Qian, Chromium LUCI CQ
Attention needed from Hu, Ningxin and Rafael Cintron

Zou, Shiyi added 2 comments

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Zou, Shiyi . resolved

PTAL, thanks!

File services/webnn/ort/environment.cc
Line 225, Patchset 1 (Latest): VLOG(1) << "[WebNN] No CPU execution provider available.";
Zou, Shiyi . resolved

Since `SelectEpDeviceForCompiler()` filters out the default CPU EP before calling `SelectEpDevices()`, so it's normal to reach this line.

Open in Gerrit

Related details

Attention is currently required from:
  • Hu, Ningxin
  • Rafael Cintron
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6f3970f217613a1a62afcbd561c6c18e1a4640b7
Gerrit-Change-Number: 8128042
Gerrit-PatchSet: 1
Gerrit-Owner: Zou, Shiyi <shiy...@intel.com>
Gerrit-Reviewer: Hu, Ningxin <ningx...@intel.com>
Gerrit-Reviewer: Rafael Cintron <rafael....@microsoft.com>
Gerrit-Reviewer: Zou, Shiyi <shiy...@intel.com>
Gerrit-CC: Jiewei Qian <q...@chromium.org>
Gerrit-Attention: Rafael Cintron <rafael....@microsoft.com>
Gerrit-Attention: Hu, Ningxin <ningx...@intel.com>
Gerrit-Comment-Date: Tue, 21 Jul 2026 06:59:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Hu, Ningxin (Gerrit)

unread,
Jul 22, 2026, 2:44:51 PM (3 days ago) Jul 22
to Zou, Shiyi, Rafael Cintron, chromium...@chromium.org, Jiewei Qian, Chromium LUCI CQ
Attention needed from Rafael Cintron and Zou, Shiyi

Hu, Ningxin voted and added 3 comments

Votes added by Hu, Ningxin

Code-Review+1

3 comments

Patchset-level comments
Hu, Ningxin . resolved

LGTM with comments

File services/webnn/ort/environment.cc
Line 225, Patchset 1 (Latest): VLOG(1) << "[WebNN] No CPU execution provider available.";
Zou, Shiyi . unresolved

Since `SelectEpDeviceForCompiler()` filters out the default CPU EP before calling `SelectEpDevices()`, so it's normal to reach this line.

Hu, Ningxin

Should the corresponding comment be updated accordingly?

Line 635, Patchset 1 (Latest): if (support_it == offline_support.end()) {
Hu, Ningxin . unresolved

The old code logged which EP and why it failed (device type vs. device ID mismatch). Consider keeping them.

Open in Gerrit

Related details

Attention is currently required from:
  • Rafael Cintron
  • Zou, Shiyi
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6f3970f217613a1a62afcbd561c6c18e1a4640b7
Gerrit-Change-Number: 8128042
Gerrit-PatchSet: 1
Gerrit-Owner: Zou, Shiyi <shiy...@intel.com>
Gerrit-Reviewer: Hu, Ningxin <ningx...@intel.com>
Gerrit-Reviewer: Rafael Cintron <rafael....@microsoft.com>
Gerrit-Reviewer: Zou, Shiyi <shiy...@intel.com>
Gerrit-CC: Jiewei Qian <q...@chromium.org>
Gerrit-Attention: Rafael Cintron <rafael....@microsoft.com>
Gerrit-Attention: Zou, Shiyi <shiy...@intel.com>
Gerrit-Comment-Date: Wed, 22 Jul 2026 18:44:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Zou, Shiyi <shiy...@intel.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Zou, Shiyi (Gerrit)

unread,
Jul 23, 2026, 12:31:14 AM (2 days ago) Jul 23
to Hu, Ningxin, Rafael Cintron, chromium...@chromium.org, Jiewei Qian, Chromium LUCI CQ
Attention needed from Rafael Cintron

Zou, Shiyi added 2 comments

File services/webnn/ort/environment.cc
Line 225, Patchset 1: VLOG(1) << "[WebNN] No CPU execution provider available.";
Zou, Shiyi . resolved

Since `SelectEpDeviceForCompiler()` filters out the default CPU EP before calling `SelectEpDevices()`, so it's normal to reach this line.

Hu, Ningxin

Should the corresponding comment be updated accordingly?

Zou, Shiyi

Done

Line 635, Patchset 1: if (support_it == offline_support.end()) {
Hu, Ningxin . resolved

The old code logged which EP and why it failed (device type vs. device ID mismatch). Consider keeping them.

Zou, Shiyi

Got it, used VLOG(2) for them since these logs are a bit noisy. Also changed some other logs to VLOG(2) and added a VLOG(1) to print the selected EP device.

Open in Gerrit

Related details

Attention is currently required from:
  • Rafael Cintron
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I6f3970f217613a1a62afcbd561c6c18e1a4640b7
    Gerrit-Change-Number: 8128042
    Gerrit-PatchSet: 2
    Gerrit-Owner: Zou, Shiyi <shiy...@intel.com>
    Gerrit-Reviewer: Hu, Ningxin <ningx...@intel.com>
    Gerrit-Reviewer: Rafael Cintron <rafael....@microsoft.com>
    Gerrit-Reviewer: Zou, Shiyi <shiy...@intel.com>
    Gerrit-CC: Jiewei Qian <q...@chromium.org>
    Gerrit-Attention: Rafael Cintron <rafael....@microsoft.com>
    Gerrit-Comment-Date: Thu, 23 Jul 2026 04:30:49 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Hu, Ningxin <ningx...@intel.com>
    Comment-In-Reply-To: Zou, Shiyi <shiy...@intel.com>
    satisfied_requirement
    open
    diffy

    Hu, Ningxin (Gerrit)

    unread,
    Jul 23, 2026, 2:00:04 PM (2 days ago) Jul 23
    to Zou, Shiyi, Rafael Cintron, chromium...@chromium.org, Jiewei Qian, Chromium LUCI CQ
    Attention needed from Rafael Cintron and Zou, Shiyi

    Hu, Ningxin voted and added 1 comment

    Votes added by Hu, Ningxin

    Code-Review+1

    1 comment

    Patchset-level comments
    Hu, Ningxin . resolved

    LGTM

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Rafael Cintron
    • Zou, Shiyi
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I6f3970f217613a1a62afcbd561c6c18e1a4640b7
    Gerrit-Change-Number: 8128042
    Gerrit-PatchSet: 3
    Gerrit-Owner: Zou, Shiyi <shiy...@intel.com>
    Gerrit-Reviewer: Hu, Ningxin <ningx...@intel.com>
    Gerrit-Reviewer: Rafael Cintron <rafael....@microsoft.com>
    Gerrit-Reviewer: Zou, Shiyi <shiy...@intel.com>
    Gerrit-CC: Jiewei Qian <q...@chromium.org>
    Gerrit-Attention: Rafael Cintron <rafael....@microsoft.com>
    Gerrit-Attention: Zou, Shiyi <shiy...@intel.com>
    Gerrit-Comment-Date: Thu, 23 Jul 2026 17:59:47 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Rafael Cintron (Gerrit)

    unread,
    Jul 24, 2026, 8:56:11 PM (7 hours ago) Jul 24
    to Zou, Shiyi, Hu, Ningxin, chromium...@chromium.org, Jiewei Qian, Chromium LUCI CQ
    Attention needed from Zou, Shiyi

    Rafael Cintron voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Zou, Shiyi
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I6f3970f217613a1a62afcbd561c6c18e1a4640b7
    Gerrit-Change-Number: 8128042
    Gerrit-PatchSet: 3
    Gerrit-Owner: Zou, Shiyi <shiy...@intel.com>
    Gerrit-Reviewer: Hu, Ningxin <ningx...@intel.com>
    Gerrit-Reviewer: Rafael Cintron <rafael....@microsoft.com>
    Gerrit-Reviewer: Zou, Shiyi <shiy...@intel.com>
    Gerrit-CC: Jiewei Qian <q...@chromium.org>
    Gerrit-Attention: Zou, Shiyi <shiy...@intel.com>
    Gerrit-Comment-Date: Sat, 25 Jul 2026 00:56:01 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Hu, Ningxin (Gerrit)

    unread,
    Jul 24, 2026, 11:42:21 PM (5 hours ago) Jul 24
    to Zou, Shiyi, Rafael Cintron, chromium...@chromium.org, Jiewei Qian, Chromium LUCI CQ
    Attention needed from Zou, Shiyi

    Hu, Ningxin voted Commit-Queue+2

    Commit-Queue+2
    Gerrit-Comment-Date: Sat, 25 Jul 2026 03:42:12 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages