[Force Save to Cloud] Update download bubble message [chromium/src : main]
0 views
Skip to first unread message
Theresa Sullivan (Gerrit)
Jan 13, 2026, 2:28:04 PMJan 13
to Nasser Al-shawwa, Chromium LUCI CQ, chromium...@chromium.org, dtraino...@chromium.org, srahim...@chromium.org
Attention needed from Nasser Al-shawwa
Theresa Sullivan added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Theresa Sullivan . unresolved
Can this go to someone in https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/download/OWNERS for revie wplease?
Related details
Attention is currently required from:
- Nasser Al-shawwa
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nasser Al-shawwa (Gerrit)
Jan 13, 2026, 2:36:02 PMJan 13
to Xinghui Lu, Chromium LUCI CQ, chromium...@chromium.org, dtraino...@chromium.org, srahim...@chromium.org
Attention needed from Xinghui Lu
Nasser Al-shawwa added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Theresa Sullivan . resolved
Can this go to someone in https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/download/OWNERS for revie wplease?
Attention is currently required from:
- Xinghui Lu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Xinghui Lu (Gerrit)
Jan 13, 2026, 2:49:47 PMJan 13
to Nasser Al-shawwa, Xinghui Lu, Chromium LUCI CQ, chromium...@chromium.org, dtraino...@chromium.org, srahim...@chromium.org
Attention needed from Nasser Al-shawwa
Xinghui Lu voted and added 1 comment![]( "Open in Gerrit")
Votes added by Xinghui Lu
| Code-Review | +1 |
1 comment
File chrome/browser/download/download_item_model_unittest.cc
Line 295, Patchset 3 (Latest):
// TODO(alshawwa): Handle LOCAL_DOWNLOAD_BLOCKED separatelyXinghui Lu . unresolved
Looks like this TODO can be removed.
Related details
Attention is currently required from:
- Nasser Al-shawwa
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nasser Al-shawwa (Gerrit)
Jan 13, 2026, 2:53:46 PMJan 13
to Xinghui Lu, Chromium LUCI CQ, chromium...@chromium.org, dtraino...@chromium.org, srahim...@chromium.org
Nasser Al-shawwa added 1 comment![]( "Open in Gerrit")
File chrome/browser/download/download_item_model_unittest.cc
Line 295, Patchset 3 (Latest):
// TODO(alshawwa): Handle LOCAL_DOWNLOAD_BLOCKED separatelyXinghui Lu . resolved
Looks like this TODO can be removed.
Nasser Al-shawwa
Not yet, I will update `Failed - Blocked` (the first string) in the following CL.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nasser Al-shawwa (Gerrit)
Jan 13, 2026, 3:24:34 PMJan 13
to Xinghui Lu, Chromium LUCI CQ, chromium...@chromium.org, dtraino...@chromium.org, srahim...@chromium.org
Nasser Al-shawwa voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jan 13, 2026, 4:05:28 PMJan 13
to Nasser Al-shawwa, Xinghui Lu, chromium...@chromium.org, dtraino...@chromium.org, srahim...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[Force Save to Cloud] Update download bubble message
Bug: 473022803
Change-Id: I60fc54770f7dd05ad0f444b0d347e868c13faf4c
Reviewed-by: Xinghui Lu <xing...@chromium.org>
Commit-Queue: Nasser Al-shawwa <alsh...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1568661}
Files:
- M chrome/app/generated_resources.grd
- A chrome/app/generated_resources_grd/IDS_DOWNLOAD_INTERRUPTED_STATUS_LOCAL_DOWNLOAD_BLOCKED.png.sha1
- M chrome/browser/download/chrome_download_manager_delegate.cc
- M chrome/browser/download/download_item_model_unittest.cc
- M chrome/browser/download/download_ui_model.cc
Change size: S
Delta: 5 files changed, 20 insertions(+), 7 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Xinghui Lu
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages