webnn: Route CPU/NPU requests to in-renderer TFLite backend [chromium/src : main]
0 views
Skip to first unread message
Fu, Junwei (Gerrit)
May 5, 2026, 11:46:17 PM (5 days ago) May 5
to Hu, Ningxin, Reilly Grant, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Jiewei Qian, blink-...@chromium.org
Attention needed from Hu, Ningxin and Reilly Grant
Fu, Junwei added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Hu, Ningxin
- Reilly Grant
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reilly Grant (Gerrit)
May 6, 2026, 9:17:20 PM (4 days ago) May 6
to Fu, Junwei, Hu, Ningxin, Reilly Grant, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Jiewei Qian, blink-...@chromium.org
Attention needed from Fu, Junwei and Hu, Ningxin
Reilly Grant added 1 comment![]( "Open in Gerrit")
File services/webnn/webnn_test_environment.cc
Line 26, Patchset 11 (Latest):
// Wraps the GPU-process `WebNNContextProvider`. When the in-process TFLite
// backend is compiled in, falls back to it on GPU-process error.Reilly Grant . unresolved
This is confusing because in unit tests there is no GPU process. This should be more explicit that is mimicking the behavior of the renderer process and that `WebNNContextProviderImpl` is expected to reject requests which wouldn't be handled by the GPU process.
Related details
Attention is currently required from:
- Fu, Junwei
- Hu, Ningxin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Fu, Junwei (Gerrit)
May 6, 2026, 9:40:33 PM (4 days ago) May 6
to Hu, Ningxin, Reilly Grant, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Jiewei Qian, blink-...@chromium.org
Attention needed from Hu, Ningxin and Reilly Grant
Fu, Junwei added 2 comments![]( "Open in Gerrit")
Patchset-level comments
File services/webnn/webnn_test_environment.cc
Line 26, Patchset 11:
// Wraps the GPU-process `WebNNContextProvider`. When the in-process TFLite
// backend is compiled in, falls back to it on GPU-process error.Reilly Grant . resolved
This is confusing because in unit tests there is no GPU process. This should be more explicit that is mimicking the behavior of the renderer process and that `WebNNContextProviderImpl` is expected to reject requests which wouldn't be handled by the GPU process.
Attention is currently required from:
- Hu, Ningxin
- Reilly Grant
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reilly Grant (Gerrit)
May 7, 2026, 4:19:39 PM (3 days ago) May 7
to Fu, Junwei, Reilly Grant, Hu, Ningxin, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Jiewei Qian, blink-...@chromium.org
Attention needed from Fu, Junwei and Hu, Ningxin
Reilly Grant voted and added 1 comment![]( "Open in Gerrit")
Votes added by Reilly Grant
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Fu, Junwei
- Hu, Ningxin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hu, Ningxin (Gerrit)
May 8, 2026, 12:28:30 AM (3 days ago) May 8
to Fu, Junwei, Reilly Grant, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Jiewei Qian, blink-...@chromium.org
Attention needed from Fu, Junwei
Hu, Ningxin added 2 comments![]( "Open in Gerrit")
File services/webnn/tflite/context_provider_tflite.cc
Line 31, Patchset 12 (Latest):
#if BUILDFLAG(WEBNN_USE_CHROME_ML_API)Hu, Ningxin . unresolved
Nit: If `WEBNN_USE_CHROME_ML_API` is not defined, there will be an empty if statement body which is confusing. Would it be better to move `#if BUILDFLAG(WEBNN_USE_CHROME_ML_API)` out and guard the entire if statement?
File services/webnn/webnn_context_provider_impl.cc
Line 591, Patchset 12 (Parent):
#else
WebNNContextImplPtr context_impl(nullptr, OnTaskRunnerDeleter(task_runner));
OnCreateWebNNContextImpl(
std::move(callback), std::move(remote), std::move(write_tensor_producer),
std::move(read_tensor_consumer), std::move(context_impl));Hu, Ningxin . unresolved
Should we keep this #else code path? May its removal leave a code path that never reports an error if tflite is disabled and ORT is not available?
Related details
Attention is currently required from:
- Fu, Junwei
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Fu, Junwei (Gerrit)
May 8, 2026, 3:02:22 AM (2 days ago) May 8
to Reilly Grant, Hu, Ningxin, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Jiewei Qian, blink-...@chromium.org
Attention needed from Hu, Ningxin
Fu, Junwei added 3 comments![]( "Open in Gerrit")
Patchset-level comments
Fu, Junwei . resolved
Thanks for review, done the comments.
File services/webnn/tflite/context_provider_tflite.cc
Nit: If `WEBNN_USE_CHROME_ML_API` is not defined, there will be an empty if statement body which is confusing. Would it be better to move `#if BUILDFLAG(WEBNN_USE_CHROME_ML_API)` out and guard the entire if statement?
Fu, Junwei
Done
File services/webnn/webnn_context_provider_impl.cc
Line 591, Patchset 12 (Parent):
#else
WebNNContextImplPtr context_impl(nullptr, OnTaskRunnerDeleter(task_runner));
OnCreateWebNNContextImpl(
std::move(callback), std::move(remote), std::move(write_tensor_producer),
std::move(read_tensor_consumer), std::move(context_impl));Hu, Ningxin . resolved
Should we keep this #else code path? May its removal leave a code path that never reports an error if tflite is disabled and ORT is not available?
Attention is currently required from:
- Hu, Ningxin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hu, Ningxin (Gerrit)
May 8, 2026, 5:49:13 PM (2 days ago) May 8
to Fu, Junwei, Reilly Grant, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Jiewei Qian, blink-...@chromium.org
Attention needed from Fu, Junwei
Hu, Ningxin voted and added 1 comment![]( "Open in Gerrit")
Votes added by Hu, Ningxin
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Fu, Junwei
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Fu, Junwei (Gerrit)
May 9, 2026, 4:49:06 AM (yesterday) May 9
to Hu, Ningxin, Reilly Grant, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Jiewei Qian, blink-...@chromium.org
Fu, Junwei voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
0 new messages