Grace Cham (Gerrit)

unread,

Feb 27, 2026, 2:15:22 AM (3 days ago) Feb 27

to Calder Kitagawa, chromium...@chromium.org, Rijubrata Bhaumik, chfreme...@chromium.org, feature-me...@chromium.org

Attention needed from Calder Kitagawa

Grace Cham voted and added 1 comment

Votes added by Grace Cham

Auto-Submit	+1
Commit-Queue	+1

1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Grace Cham . resolved

Hi Calder, I'm trying to investigate some bugs that I can't reproduce and am relying on reporters bug report and logs. PTAL and let me know if you think this is too spammy and should change the verbosity. Thanks!

Open in Gerrit

Related details

Attention is currently required from:

Calder Kitagawa

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Calder Kitagawa (Gerrit)

unread,

Feb 27, 2026, 7:04:45 AM (3 days ago) Feb 27

to Grace Cham, Chromium LUCI CQ, chromium...@chromium.org, Rijubrata Bhaumik, chfreme...@chromium.org, feature-me...@chromium.org

Attention needed from Grace Cham

Calder Kitagawa voted and added 4 comments

Votes added by Calder Kitagawa

Code-Review

+1

4 comments

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Calder Kitagawa . resolved

LGTM

Commit Message

Line 9, Patchset 2 (Latest):

For easier initial bug investigation from bug reports when picker fails
to launch or trigger sharing.

Calder Kitagawa . unresolved

You might want to add histograms for anything critical as well (follow up). Logs aren't generally available except via the crash server when there is a crash or if a full bug report is uploaded.

File chrome/android/java/src/org/chromium/chrome/browser/media/MediaCapturePickerInvoker.java

Line 76, Patchset 2 (Latest):

        Log.d(
                TAG,
                String.format(
                        "PickerInvoker: AndroidCapturePrompt received user action %d", action));

Calder Kitagawa . unresolved

I think you can just append this rather than using a format string.

Line 88, Patchset 2 (Latest):

                        String.format(
                                "PickerInvoker: Tab %d with title '%s' was picked",
                                tab.getId(), tab.getTitle()));

Calder Kitagawa . unresolved

Ditto.

Open in Gerrit

Related details

Attention is currently required from:

Grace Cham

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Grace Cham (Gerrit)

unread,

Mar 1, 2026, 9:16:02 PM (7 hours ago) Mar 1

to Calder Kitagawa, Chromium LUCI CQ, chromium...@chromium.org, Rijubrata Bhaumik, chfreme...@chromium.org, feature-me...@chromium.org

Attention needed from Frank Liberato

Grace Cham voted and added 4 comments

Votes added by Grace Cham

Auto-Submit	+1
Commit-Queue	+1

4 comments

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Grace Cham . resolved

Hi Frank, PTAL, thanks!

Commit Message

Line 9, Patchset 2:For easier initial bug investigation from bug reports when picker fails


to launch or trigger sharing.

Calder Kitagawa . resolved

You might want to add histograms for anything critical as well (follow up). Logs aren't generally available except via the crash server when there is a crash or if a full bug report is uploaded.

Grace Cham

Acknowledged

File chrome/android/java/src/org/chromium/chrome/browser/media/MediaCapturePickerInvoker.java

Line 76, Patchset 2: Log.d(


                TAG,
                String.format(
                        "PickerInvoker: AndroidCapturePrompt received user action %d", action));

Calder Kitagawa . resolved

I think you can just append this rather than using a format string.

Grace Cham

Done - wow I didn't know this!

Line 88, Patchset 2: String.format(


                                "PickerInvoker: Tab %d with title '%s' was picked",
                                tab.getId(), tab.getTitle()));

Calder Kitagawa . resolved

Ditto.

Grace Cham

Done

Open in Gerrit

Related details

Attention is currently required from:

Frank Liberato

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Frank Liberato (Gerrit)

unread,

12:16 AM (4 hours ago) 12:16 AM

to Grace Cham, Calder Kitagawa, Chromium LUCI CQ, chromium...@chromium.org, Rijubrata Bhaumik, chfreme...@chromium.org, feature-me...@chromium.org

Attention needed from Grace Cham

Frank Liberato voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Grace Cham

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Grace Cham (Gerrit)

unread,

12:17 AM (4 hours ago) 12:17 AM

to Calder Kitagawa, Chromium LUCI CQ, chromium...@chromium.org, Rijubrata Bhaumik, chfreme...@chromium.org, feature-me...@chromium.org

Grace Cham voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

12:20 AM (4 hours ago) 12:20 AM

to Grace Cham, Calder Kitagawa, chromium...@chromium.org, Rijubrata Bhaumik, chfreme...@chromium.org, feature-me...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

[Media Capture] Add logs for launching picker and result callback



For easier initial bug investigation from bug reports when picker fails
to launch or trigger sharing.

Bug: 486762180, 481228978

Test: None

Change-Id: Ie1b2ab94fc902c848f0f99fc0bf72994c0ffe8a2

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7616290

Reviewed-by: Calder Kitagawa <ckit...@chromium.org>

Commit-Queue: Grace Cham <hsc...@chromium.org>

Auto-Submit: Grace Cham <hsc...@chromium.org>

Reviewed-by: Frank Liberato <libe...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1592246}

Files:

M chrome/android/java/src/org/chromium/chrome/browser/media/MediaCapturePickerDialog.java
M chrome/android/java/src/org/chromium/chrome/browser/media/MediaCapturePickerInvoker.java
M chrome/android/java/src/org/chromium/chrome/browser/media/MediaCapturePickerManager.java
M chrome/android/java/src/org/chromium/chrome/browser/media/MediaCapturePickerManagerBridge.java
M chrome/browser/media/android/media_capture_picker_manager_bridge.cc

Change size: M

Delta: 5 files changed, 61 insertions(+), 0 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Frank Liberato, +1 by Calder Kitagawa

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

[Media Capture] Add logs for launching picker and result callback [chromium/src : main]

Grace Cham (Gerrit)

Grace Cham voted and added 1 comment

Votes added by Grace Cham

1 comment

Related details

Calder Kitagawa (Gerrit)

Calder Kitagawa voted and added 4 comments

Votes added by Calder Kitagawa

4 comments

Related details

Grace Cham (Gerrit)

Grace Cham voted and added 4 comments

Votes added by Grace Cham

4 comments

Related details

Frank Liberato (Gerrit)

Frank Liberato voted Code-Review+1

Related details

Grace Cham (Gerrit)

Grace Cham voted Commit-Queue+2

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information