[bedrock] Remove Browser dependencies from app_info_dialog_views tests [chromium/src : main]

1 view
Skip to first unread message

Wenbin Zhang (Gerrit)

unread,
Jul 31, 2026, 1:47:32 PM (2 days ago) Jul 31
to chromium-bedrock-reviews, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from chromium-bedrock-reviews

Wenbin Zhang added 1 comment

Patchset-level comments
File-level comment, Patchset 8 (Latest):
Wenbin Zhang . resolved

PTAL.

Open in Gerrit

Related details

Attention is currently required from:
  • chromium-bedrock-reviews
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7706d6a87ded08db34f06aa921165b99f11ed79a
Gerrit-Change-Number: 8175373
Gerrit-PatchSet: 8
Gerrit-Owner: Wenbin Zhang <wenbi...@google.com>
Gerrit-Reviewer: Wenbin Zhang <wenbi...@google.com>
Gerrit-Reviewer: chromium-bedrock-reviews <chromium-bed...@google.com>
Gerrit-Attention: chromium-bedrock-reviews <chromium-bed...@google.com>
Gerrit-Comment-Date: Fri, 31 Jul 2026 17:47:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

gwsq (Gerrit)

unread,
Jul 31, 2026, 1:52:13 PM (2 days ago) Jul 31
to Wenbin Zhang, chromium-bedrock-reviews, Sophie Chang, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Sophie Chang

Message from gwsq

Reviewer source(s):
sophi...@chromium.org is from context(googleclient/chrome/chromium_gwsq/chrome/browser/config.gwsq)

Open in Gerrit

Related details

Attention is currently required from:
  • Sophie Chang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7706d6a87ded08db34f06aa921165b99f11ed79a
Gerrit-Change-Number: 8175373
Gerrit-PatchSet: 8
Gerrit-Owner: Wenbin Zhang <wenbi...@google.com>
Gerrit-Reviewer: Sophie Chang <sophi...@chromium.org>
Gerrit-Reviewer: Wenbin Zhang <wenbi...@google.com>
Gerrit-CC: chromium-bedrock-reviews <chromium-bed...@google.com>
Gerrit-CC: gwsq
Gerrit-Attention: Sophie Chang <sophi...@chromium.org>
Gerrit-Comment-Date: Fri, 31 Jul 2026 17:52:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Sophie Chang (Gerrit)

unread,
Jul 31, 2026, 6:20:59 PM (2 days ago) Jul 31
to Wenbin Zhang, chromium-bedrock-reviews, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Wenbin Zhang

Sophie Chang voted and added 1 comment

Votes added by Sophie Chang

Code-Review+1

1 comment

File chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views_browsertest.cc
Line 28, Patchset 8 (Latest):namespace test {
Sophie Chang . unresolved

do you actually need this namespace?

Open in Gerrit

Related details

Attention is currently required from:
  • Wenbin Zhang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7706d6a87ded08db34f06aa921165b99f11ed79a
Gerrit-Change-Number: 8175373
Gerrit-PatchSet: 8
Gerrit-Owner: Wenbin Zhang <wenbi...@google.com>
Gerrit-Reviewer: Sophie Chang <sophi...@chromium.org>
Gerrit-Reviewer: Wenbin Zhang <wenbi...@google.com>
Gerrit-CC: chromium-bedrock-reviews <chromium-bed...@google.com>
Gerrit-CC: gwsq
Gerrit-Attention: Wenbin Zhang <wenbi...@google.com>
Gerrit-Comment-Date: Fri, 31 Jul 2026 22:20:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Wenbin Zhang (Gerrit)

unread,
Aug 1, 2026, 1:13:32 AM (yesterday) Aug 1
to android-bu...@system.gserviceaccount.com, AyeAye Python Dispatcher, SLSA Policy Verification Service, Sophie Chang, chromium-bedrock-reviews, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, chrome-intelligence-te...@google.com, chrome-intell...@chromium.org
Attention needed from Sophie Chang

Wenbin Zhang added 2 comments

Patchset-level comments
File-level comment, Patchset 11 (Latest):
Wenbin Zhang . resolved

Thanks for the review! +1 was reset after rebase. PTAL again.

File chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views_browsertest.cc
Line 28, Patchset 8:namespace test {
Sophie Chang . resolved

do you actually need this namespace?

Wenbin Zhang

Thanks for the catch! Updated!

Open in Gerrit

Related details

Attention is currently required from:
  • Sophie Chang
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I7706d6a87ded08db34f06aa921165b99f11ed79a
    Gerrit-Change-Number: 8175373
    Gerrit-PatchSet: 11
    Gerrit-Owner: Wenbin Zhang <wenbi...@google.com>
    Gerrit-Reviewer: SLSA Policy Verification Service <devtools-gerritco...@google.com>
    Gerrit-Reviewer: Sophie Chang <sophi...@chromium.org>
    Gerrit-Reviewer: Wenbin Zhang <wenbi...@google.com>
    Gerrit-CC: AyeAye Python Dispatcher <android-build-ayeay...@system.gserviceaccount.com>
    Gerrit-CC: chromium-bedrock-reviews <chromium-bed...@google.com>
    Gerrit-CC: gwsq
    Gerrit-Attention: Sophie Chang <sophi...@chromium.org>
    Gerrit-Comment-Date: Sat, 01 Aug 2026 05:13:18 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Sophie Chang <sophi...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Sophie Chang (Gerrit)

    unread,
    Aug 1, 2026, 1:08:02 PM (18 hours ago) Aug 1
    to Wenbin Zhang, android-bu...@system.gserviceaccount.com, AyeAye Python Dispatcher, SLSA Policy Verification Service, chromium-bedrock-reviews, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, chrome-intelligence-te...@google.com, chrome-intell...@chromium.org
    Attention needed from Wenbin Zhang

    Sophie Chang voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Wenbin Zhang
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I7706d6a87ded08db34f06aa921165b99f11ed79a
      Gerrit-Change-Number: 8175373
      Gerrit-PatchSet: 11
      Gerrit-Owner: Wenbin Zhang <wenbi...@google.com>
      Gerrit-Reviewer: SLSA Policy Verification Service <devtools-gerritco...@google.com>
      Gerrit-Reviewer: Sophie Chang <sophi...@chromium.org>
      Gerrit-Reviewer: Wenbin Zhang <wenbi...@google.com>
      Gerrit-CC: AyeAye Python Dispatcher <android-build-ayeay...@system.gserviceaccount.com>
      Gerrit-CC: chromium-bedrock-reviews <chromium-bed...@google.com>
      Gerrit-CC: gwsq
      Gerrit-Attention: Wenbin Zhang <wenbi...@google.com>
      Gerrit-Comment-Date: Sat, 01 Aug 2026 17:07:45 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Wenbin Zhang (Gerrit)

      unread,
      1:28 AM (6 hours ago) 1:28 AM
      to Sophie Chang, android-bu...@system.gserviceaccount.com, AyeAye Python Dispatcher, SLSA Policy Verification Service, chromium-bedrock-reviews, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, chrome-intelligence-te...@google.com, chrome-intell...@chromium.org

      Wenbin Zhang voted Commit-Queue+2

      Commit-Queue+2
      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I7706d6a87ded08db34f06aa921165b99f11ed79a
      Gerrit-Change-Number: 8175373
      Gerrit-PatchSet: 11
      Gerrit-Owner: Wenbin Zhang <wenbi...@google.com>
      Gerrit-Reviewer: SLSA Policy Verification Service <devtools-gerritco...@google.com>
      Gerrit-Reviewer: Sophie Chang <sophi...@chromium.org>
      Gerrit-Reviewer: Wenbin Zhang <wenbi...@google.com>
      Gerrit-CC: AyeAye Python Dispatcher <android-build-ayeay...@system.gserviceaccount.com>
      Gerrit-CC: chromium-bedrock-reviews <chromium-bed...@google.com>
      Gerrit-CC: gwsq
      Gerrit-Comment-Date: Sun, 02 Aug 2026 05:27:45 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages