Zhenyao Mo (Gerrit)

unread,

May 7, 2026, 5:20:49 PM (3 days ago) May 7

to Ben Pastene, Chromium LUCI CQ, chromium...@chromium.org

Attention needed from Ben Pastene

Zhenyao Mo added 1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Zhenyao Mo . resolved

PTAL

I will land this after https://chromium-review.git.corp.google.com/c/chromium/src/+/7830477

Open in Gerrit

Related details

Attention is currently required from:

Ben Pastene

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Ben Pastene (Gerrit)

unread,

May 7, 2026, 9:49:05 PM (3 days ago) May 7

to Zhenyao Mo, Chromium LUCI CQ, chromium...@chromium.org

Attention needed from Zhenyao Mo

Ben Pastene voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Zhenyao Mo

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Zhenyao Mo (Gerrit)

unread,

9:00 AM (4 hours ago) 9:00 AM

to Ben Pastene, Chromium LUCI CQ, chromium...@chromium.org

Zhenyao Mo voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

11:13 AM (2 hours ago) 11:13 AM

to Zhenyao Mo, Ben Pastene, chromium...@chromium.org

Chromium LUCI CQ submitted the change

Unreviewed changes

3 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:

Infra: switch TreesInViz bots between enabled/disabled.

Linux: switch from enabled to disabled. Win/Mac/Android/ChromiumOS:
switch from disabled to enabled.

This is due to corresponding fieldtrials_testing_config.json change.

TEST=waterfall

Bug: 369883417

Change-Id: Iae38e12c276b2cc5725ca97bb5039234a15a03cd

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7831257

Reviewed-by: Ben Pastene <bpas...@chromium.org>

Commit-Queue: Zhenyao Mo <z...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1628276}

Files:

M infra/config/generated/builder-owners/chrome-...@google.com.txt
R infra/config/generated/builders/ci/android-x64-treesinviz-disabled-rel/gn-args.json
R infra/config/generated/builders/ci/android-x64-treesinviz-disabled-rel/properties.json
R infra/config/generated/builders/ci/android-x64-treesinviz-disabled-rel/shadow-properties.json
R infra/config/generated/builders/ci/android-x64-treesinviz-disabled-rel/targets/chromium.fyi.json
R infra/config/generated/builders/ci/linux-chromeos-treesinviz-disabled-rel/gn-args.json
R infra/config/generated/builders/ci/linux-chromeos-treesinviz-disabled-rel/properties.json
R infra/config/generated/builders/ci/linux-chromeos-treesinviz-disabled-rel/shadow-properties.json
R infra/config/generated/builders/ci/linux-chromeos-treesinviz-disabled-rel/targets/chromium.fyi.json
R infra/config/generated/builders/ci/linux-treesinviz-enabled-rel/gn-args.json
R infra/config/generated/builders/ci/linux-treesinviz-enabled-rel/properties.json
R infra/config/generated/builders/ci/linux-treesinviz-enabled-rel/shadow-properties.json
R infra/config/generated/builders/ci/linux-treesinviz-enabled-rel/targets/chromium.fyi.json
R infra/config/generated/builders/ci/mac-treesinviz-disabled-rel/gn-args.json
R infra/config/generated/builders/ci/mac-treesinviz-disabled-rel/properties.json
R infra/config/generated/builders/ci/mac-treesinviz-disabled-rel/shadow-properties.json
R infra/config/generated/builders/ci/mac-treesinviz-disabled-rel/targets/chromium.fyi.json
R infra/config/generated/builders/ci/win-treesinviz-disabled-rel/gn-args.json
R infra/config/generated/builders/ci/win-treesinviz-disabled-rel/properties.json
R infra/config/generated/builders/ci/win-treesinviz-disabled-rel/shadow-properties.json
R infra/config/generated/builders/ci/win-treesinviz-disabled-rel/targets/chromium.fyi.json
M infra/config/generated/builders/gn_args_locations.json
R infra/config/generated/builders/try/android-x64-treesinviz-disabled-rel/gn-args.json
R infra/config/generated/builders/try/android-x64-treesinviz-disabled-rel/properties.json
C infra/config/generated/builders/try/android-x64-treesinviz-disabled-rel/targets/chromium.fyi.json
D infra/config/generated/builders/try/android-x64-treesinviz-enabled-rel/targets/chromium.fyi.json
R infra/config/generated/builders/try/linux-chromeos-treesinviz-disabled-rel/gn-args.json
R infra/config/generated/builders/try/linux-chromeos-treesinviz-disabled-rel/properties.json
C infra/config/generated/builders/try/linux-chromeos-treesinviz-disabled-rel/targets/chromium.fyi.json
D infra/config/generated/builders/try/linux-chromeos-treesinviz-enabled-rel/targets/chromium.fyi.json
D infra/config/generated/builders/try/linux-treesinviz-disabled-rel/targets/chromium.fyi.json
R infra/config/generated/builders/try/linux-treesinviz-enabled-rel/gn-args.json
R infra/config/generated/builders/try/linux-treesinviz-enabled-rel/properties.json
C infra/config/generated/builders/try/linux-treesinviz-enabled-rel/targets/chromium.fyi.json
R infra/config/generated/builders/try/mac-treesinviz-disabled-rel/gn-args.json
R infra/config/generated/builders/try/mac-treesinviz-disabled-rel/properties.json
C infra/config/generated/builders/try/mac-treesinviz-disabled-rel/targets/chromium.fyi.json
D infra/config/generated/builders/try/mac-treesinviz-enabled-rel/targets/chromium.fyi.json
R infra/config/generated/builders/try/win-treesinviz-disabled-rel/gn-args.json
R infra/config/generated/builders/try/win-treesinviz-disabled-rel/properties.json
C infra/config/generated/builders/try/win-treesinviz-disabled-rel/targets/chromium.fyi.json
D infra/config/generated/builders/try/win-treesinviz-enabled-rel/targets/chromium.fyi.json
M infra/config/generated/health-specs/health-specs.json
M infra/config/generated/luci/commit-queue.cfg
M infra/config/generated/luci/cr-buildbucket.cfg
M infra/config/generated/luci/luci-milo.cfg
M infra/config/generated/luci/luci-scheduler.cfg
M infra/config/subprojects/chromium/ci/chromium.fyi.star
M infra/config/subprojects/chromium/try/tryserver.chromium.android.star
M infra/config/subprojects/chromium/try/tryserver.chromium.chromiumos.star
M infra/config/subprojects/chromium/try/tryserver.chromium.linux.star
M infra/config/subprojects/chromium/try/tryserver.chromium.mac.star
M infra/config/subprojects/chromium/try/tryserver.chromium.win.star
M infra/config/targets/bundles.star

Change size: XL

Delta: 54 files changed, 261 insertions(+), 939 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Ben Pastene

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

Infra: switch TreesInViz bots between enabled/disabled. [chromium/src : main]

Zhenyao Mo (Gerrit)

Zhenyao Mo added 1 comment

Related details

Ben Pastene (Gerrit)

Ben Pastene voted Code-Review+1

Related details

Zhenyao Mo (Gerrit)

Zhenyao Mo voted Commit-Queue+2

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Unreviewed changes

Change information