[bedrock] Migrate app_shim_manager_mac.h away from BrowserListObserver. [chromium/src : main]
Glenn Hartmann (Gerrit)
New activity on the change![]( "Open in Gerrit")
Related details
- Marijn Kruisselbrink
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Marijn Kruisselbrink (Gerrit)
Marijn Kruisselbrink voted Code-Review+1![]( "Open in Gerrit")
- Glenn Hartmann
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Glenn Hartmann (Gerrit)
Glenn Hartmann voted Commit-Queue+2![]( "Open in Gerrit")
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
[bedrock] Migrate app_shim_manager_mac.h away from BrowserListObserver.
This migration is part of project bedrock to reduce the dependencies on
Browser and BrowserList. See https://crbug.com/431671320 for more info.
- M chrome/browser/apps/app_shim/app_shim_manager_mac.cc
- M chrome/browser/apps/app_shim/app_shim_manager_mac.h
- M chrome/browser/apps/app_shim/app_shim_manager_mac_unittest.cc
Code-Review: +1 by Marijn Kruisselbrink
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
luci-bisection@appspot.gserviceaccount.com (Gerrit)
Message from luci-bi...@appspot.gserviceaccount.com![]( "Open in Gerrit")
LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/5712169380347904
Sample build with failed test: https://ci.chromium.org/b/8690562369275624897
Affected test(s):
[://chrome/test\:interactive_ui_tests!gtest::AIOnDeviceBrowserTest#AvailableInWindowOrWorker/FlagNotEnabledByUser_NoWorkerFlag_NoAPIKillswitch_NoOTToken](https://ci.chromium.org/ui/test/chromium/:%2F%2Fchrome%2Ftest%5C:interactive_ui_tests%21gtest::AIOnDeviceBrowserTest%23AvailableInWindowOrWorker%2FFlagNotEnabledByUser_NoWorkerFlag_NoAPIKillswitch_NoOTToken?q=VHash%3A5ba6efc192694ec6)
[://chrome/test\:interactive_ui_tests!gtest::AIOnDeviceBrowserTest#ExposedToWindowOrWorker/FlagEnabledByUser_WithWorkerFlag_NoAPIKillswitch_WithOTToken](https://ci.chromium.org/ui/test/chromium/:%2F%2Fchrome%2Ftest%5C:interactive_ui_tests%21gtest::AIOnDeviceBrowserTest%23ExposedToWindowOrWorker%2FFlagEnabledByUser_WithWorkerFlag_NoAPIKillswitch_WithOTToken?q=VHash%3A5ba6efc192694ec6)
[://chrome/test\:interactive_ui_tests!gtest::AIOnDeviceBrowserTest#ExposedToWindowOrWorker/FlagEnabledByUser_WithWorkerFlag_WithAPIKillswitch_WithOTToken](https://ci.chromium.org/ui/test/chromium/:%2F%2Fchrome%2Ftest%5C:interactive_ui_tests%21gtest::AIOnDeviceBrowserTest%23ExposedToWindowOrWorker%2FFlagEnabledByUser_WithWorkerFlag_WithAPIKillswitch_WithOTToken?q=VHash%3A5ba6efc192694ec6)
[://chrome/test\:interactive_ui_tests!gtest::AIOnDeviceBrowserTest#ExposedToWindowOrWorker/FlagNotEnabledByUser_NoWorkerFlag_WithAPIKillswitch_NoOTToken](https://ci.chromium.org/ui/test/chromium/:%2F%2Fchrome%2Ftest%5C:interactive_ui_tests%21gtest::AIOnDeviceBrowserTest%23ExposedToWindowOrWorker%2FFlagNotEnabledByUser_NoWorkerFlag_WithAPIKillswitch_NoOTToken?q=VHash%3A5ba6efc192694ec6)
[://chrome/test\:interactive_ui_tests!gtest::ActionCommandsApiTest#TriggeringCommandTriggersPopup/All.2](https://ci.chromium.org/ui/test/chromium/:%2F%2Fchrome%2Ftest%5C:interactive_ui_tests%21gtest::ActionCommandsApiTest%23TriggeringCommandTriggersPopup%2FAll.2?q=VHash%3A5ba6efc192694ec6)
and 95 more ...
A revert for this change was not created because the builder that this CL broke is not watched by gardeners, therefore less important. You can consider revert this CL, fix forward or let builder owners resolve it themselves.
If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F5712169380347904&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F7551752&type=BUG
Related details
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |