nested app menu: Minor cosmetic changes per UX directions [chromium/src : main]

0 views

Skip to first unread message

Masa Fujita (Gerrit)

unread,

11:42 AM (3 hours ago) 11:42 AM

to chromium...@chromium.org, Chromium Metrics Reviews, asvitkine...@chromium.org, jmedle...@chromium.org, browser-comp...@chromium.org, srahim...@chromium.org, asvitki...@chromium.org

Masa Fujita has uploaded the change for review

Commit message

nested app menu: Minor cosmetic changes per UX directions

Changes included in the CL:
 - Rename "Bookmark" parent item to "Bookmarks and lists"
 - Rename "Bookmark this page" to "Bookmark this tab"
 - Move "Mobile bookmarks" and "Other bookmarks" to above reading list
 - Rename "Bookmarks" to "Show all bookmarks"
 - Rename "History" item to "Open history"
 - Rename "QR code" to "Create QR code"
 - Updated tests to match the changes

This change is behind the flag #submenus-in-app-menu.

Bug: 533509373, 533509567, 533509291, 533509461, 533509987

Change-Id: Idef854e9c370f5ae42e7ee8444767d5f969f5ed3

Change diff

Change information

Files:

M chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/BookmarksItemBuilder.java
M chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/HistoryItemBuilder.java
M chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/MoreToolsItemBuilder.java
M chrome/android/junit/src/org/chromium/chrome/browser/tabbed_mode/BookmarksItemBuilderUnitTest.java
M chrome/android/junit/src/org/chromium/chrome/browser/tabbed_mode/HistoryItemBuilderUnitTest.java
M chrome/android/junit/src/org/chromium/chrome/browser/tabbed_mode/TabbedAppMenuPropertiesDelegateUnitTest.java
M chrome/browser/bookmarks/android/junit/src/org/chromium/chrome/browser/bookmarks/FakeBookmarkModel.java
M chrome/browser/ui/android/strings/android_chrome_strings.grd
A chrome/browser/ui/android/strings/android_chrome_strings_grd/IDS_MENU_BOOKMARKS_AND_LISTS.png.sha1
D chrome/browser/ui/android/strings/android_chrome_strings_grd/IDS_MENU_BOOKMARK_THIS_PAGE.png.sha1
A chrome/browser/ui/android/strings/android_chrome_strings_grd/IDS_MENU_BOOKMARK_THIS_TAB.png.sha1
A chrome/browser/ui/android/strings/android_chrome_strings_grd/IDS_MENU_CUSTOMIZE_CHROME.png.sha1
A chrome/browser/ui/android/strings/android_chrome_strings_grd/IDS_MENU_OPEN_HISTORY.png.sha1
M chrome/browser/ui/android/strings/android_chrome_strings_grd/IDS_MENU_QR_CODE.png.sha1
A chrome/browser/ui/android/strings/android_chrome_strings_grd/IDS_MENU_SHOW_ALL_BOOKMARKS.png.sha1

Change size: L

Delta: 15 files changed, 156 insertions(+), 386 deletions(-)

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Masa Fujita (Gerrit)

unread,

11:45 AM (3 hours ago) 11:45 AM

to Chromium Metrics Reviews, chromium...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, browser-comp...@chromium.org, jmedle...@chromium.org, srahim...@chromium.org

Masa Fujita voted Commit-Queue+1

Commit-Queue