[//gpu] Fix dangling pointers in GpuServiceImpl destruction [chromium/src : main]

0 views
Skip to first unread message

Vasiliy Telezhnikov (Gerrit)

unread,
Sep 25, 2025, 11:29:56 AM (15 hours ago) Sep 25
to Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Colin Blundell

Vasiliy Telezhnikov voted and added 1 comment

Votes added by Vasiliy Telezhnikov

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Vasiliy Telezhnikov . resolved

lgtm, thanks.

Open in Gerrit

Related details

Attention is currently required from:
  • Colin Blundell
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I1fc02cfed8810ed3f86edd17ef0fee7bceb2f36f
Gerrit-Change-Number: 6983025
Gerrit-PatchSet: 4
Gerrit-Owner: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Vasiliy Telezhnikov <vas...@chromium.org>
Gerrit-Attention: Colin Blundell <blun...@chromium.org>
Gerrit-Comment-Date: Thu, 25 Sep 2025 15:29:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Colin Blundell (Gerrit)

unread,
Sep 25, 2025, 11:34:07 AM (15 hours ago) Sep 25
to Colin Blundell, Vasiliy Telezhnikov, Chromium LUCI CQ, chromium...@chromium.org

Colin Blundell voted and added 1 comment

Votes added by Colin Blundell

Commit-Queue+2

1 comment

Patchset-level comments
Colin Blundell . resolved

Thanks!

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I1fc02cfed8810ed3f86edd17ef0fee7bceb2f36f
Gerrit-Change-Number: 6983025
Gerrit-PatchSet: 4
Gerrit-Owner: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Vasiliy Telezhnikov <vas...@chromium.org>
Gerrit-Comment-Date: Thu, 25 Sep 2025 15:33:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Sep 25, 2025, 12:08:47 PM (15 hours ago) Sep 25
to Colin Blundell, Vasiliy Telezhnikov, chromium...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[//gpu] Fix dangling pointers in GpuServiceImpl destruction

Issue that was uncovered by a recent unrelated refactoring; see analysis
in [1] (it turned out that there was the same issue with
`GpuServiceImpl::owned_scheduler_`; this CL fixes both).

[1]: https://issues.chromium.org/u/1/issues/447037086#comment4
Bug: 447037086
Change-Id: I1fc02cfed8810ed3f86edd17ef0fee7bceb2f36f
Reviewed-by: Vasiliy Telezhnikov <vas...@chromium.org>
Commit-Queue: Colin Blundell <blun...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1520656}
Files:
  • M gpu/ipc/service/gpu_channel.cc
  • M gpu/ipc/service/image_decode_accelerator_stub.cc
  • M gpu/ipc/service/image_decode_accelerator_stub.h
Change size: S
Delta: 3 files changed, 8 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Vasiliy Telezhnikov
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I1fc02cfed8810ed3f86edd17ef0fee7bceb2f36f
Gerrit-Change-Number: 6983025
Gerrit-PatchSet: 5
Gerrit-Owner: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Vasiliy Telezhnikov <vas...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages