Add field trial test config for token handle store [chromium/src : main]
0 views
Skip to first unread message
Nico Weber (Gerrit)
Jun 12, 2025, 9:05:36 AM6/12/25
to Elie Maamari, Nico Weber, Robert Kaplow, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org
Attention needed from Elie Maamari and Robert Kaplow
Nico Weber voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Elie Maamari
- Robert Kaplow
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Elie Maamari (Gerrit)
Jun 12, 2025, 11:43:59 AM6/12/25
to Robert Kaplow, Nico Weber, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org
Attention needed from Elie Maamari
Elie Maamari removed Robert Kaplow from this change![]( "Open in Gerrit")
Deleted Reviewers:
- Robert Kaplow
Related details
Attention is currently required from:
- Elie Maamari
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Elie Maamari (Gerrit)
Jun 12, 2025, 11:44:09 AM6/12/25
to Nico Weber, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org
Elie Maamari voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Elie Maamari (Gerrit)
Sep 11, 2025, 5:44:42 AM9/11/25
to Chromium LUCI CQ, Nico Weber, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org
Elie Maamari voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Elie Maamari (Gerrit)
Sep 17, 2025, 7:11:13 AM9/17/25
to Chromium LUCI CQ, Nico Weber, Chromium Metrics Reviews, chromium...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org, asvitkine...@chromium.org
Attention needed from Nico Weber
Elie Maamari added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Elie Maamari . resolved
Hello Nico, can you PTAL at this again? Thanks.
Related details
Attention is currently required from:
- Nico Weber
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nico Weber (Gerrit)
Sep 17, 2025, 7:21:32 AM9/17/25
to Elie Maamari, Nico Weber, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org, asvitkine...@chromium.org
Attention needed from Elie Maamari
Nico Weber voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Elie Maamari
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Elie Maamari (Gerrit)
Sep 17, 2025, 7:21:58 AM9/17/25
to Nico Weber, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org, asvitkine...@chromium.org
Elie Maamari voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nico Weber (Gerrit)
Sep 17, 2025, 7:22:12 AM9/17/25
to Elie Maamari, Nico Weber, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org, asvitkine...@chromium.org
Nico Weber added 1 comment![]( "Open in Gerrit")
File chrome/browser/ash/login/signin/token_handle_store_impl.cc
Line 183, Patchset 3 (Latest):
const std::string& access_token,Nico Weber . unresolved
Why this change?
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Elie Maamari (Gerrit)
Oct 2, 2025, 1:39:05 AM10/2/25
to Nico Weber, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org, asvitkine...@chromium.org
Elie Maamari added 1 comment![]( "Open in Gerrit")
File chrome/browser/ash/login/signin/token_handle_store_impl.cc
Line 183, Patchset 3 (Latest):
const std::string& access_token,Nico Weber . resolved
Elie MaamariWhy this change?
I thought this invariant would always hold up. It actually does in production and in unit/browser tests, but it seems like tast tests can still pass an empty access token.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Elie Maamari (Gerrit)
Oct 2, 2025, 1:39:14 AM10/2/25
to Nico Weber, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org, asvitkine...@chromium.org
Elie Maamari voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Oct 2, 2025, 2:32:20 AM10/2/25
to Elie Maamari, Nico Weber, Chromium Metrics Reviews, chromium...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org, asvitkine...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Add field trial test config for token handle store
Bug: b:383733245
Change-Id: Ib151002fef01898af2447fb0c889dd173ba24729
Commit-Queue: Elie Maamari <emaa...@google.com>
Reviewed-by: Nico Weber <tha...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1524024}
Files:
- M chrome/browser/ash/login/signin/token_handle_store_impl.cc
- M testing/variations/fieldtrial_testing_config.json
Change size: S
Delta: 2 files changed, 15 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Nico Weber
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Piotr Kotynia (Gerrit)
Oct 2, 2025, 4:41:34 AM10/2/25
to Chromium LUCI CQ, Elie Maamari, Nico Weber, Chromium Metrics Reviews, chromium...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org, asvitkine...@chromium.org
Piotr Kotynia has created a revert of this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages