[CodeHealth] Chrome WebUI base::Value refactoring

Claudio DeSouza (Gerrit)

unread,

Aug 8, 2022, 6:04:14 AM8/8/22

to ntp-dev...@chromium.org, print-revi...@chromium.org, Cathy Li, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Cathy Li.

View Change

To view, visit change 3811593. To unsubscribe, or for help writing mail filters, visit settings.

Claudio DeSouza (Gerrit)

unread,

Aug 8, 2022, 6:04:50 AM8/8/22

to Cathy Li, ntp-dev...@chromium.org, print-revi...@chromium.org, Giovanni Ortuno Urquidi, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Giovanni Ortuno Urquidi.

Claudio DeSouza removed Cathy Li from this change.

View Change

To view, visit change 3811593. To unsubscribe, or for help writing mail filters, visit settings.

Giovanni Ortuno Urquidi (Gerrit)

unread,

Aug 9, 2022, 12:37:19 AM8/9/22

to Claudio DeSouza, ntp-dev...@chromium.org, print-revi...@chromium.org, Giovanni Ortuno Urquidi, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Claudio DeSouza.

Patch set 3:Code-Review +1

View Change

To view, visit change 3811593. To unsubscribe, or for help writing mail filters, visit settings.

Claudio DeSouza (Gerrit)

unread,

Aug 9, 2022, 4:15:41 AM8/9/22

to ntp-dev...@chromium.org, print-revi...@chromium.org, Giovanni Ortuno Urquidi, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Claudio DeSouza.

Patch set 3:Commit-Queue +2

View Change

To view, visit change 3811593. To unsubscribe, or for help writing mail filters, visit settings.

Chromium LUCI CQ (Gerrit)

unread,

Aug 9, 2022, 5:58:20 AM8/9/22

to Claudio DeSouza, ntp-dev...@chromium.org, print-revi...@chromium.org, Giovanni Ortuno Urquidi, chromium...@chromium.org

Chromium LUCI CQ submitted this change.

View Change

Approvals:
  Giovanni Ortuno Urquidi: Looks good to me
  Claudio DeSouza: Commit

[CodeHealth] Chrome WebUI base::Value refactoring - Part 2

This CL provides additional base::Value modernisation for Chrome WebUI
handlers, removing the use of all deprecated interfaces for a couple of
files, from handlers under chrome/browser/ui/webui/.

Bug: 1187001
Change-Id: Ia5eb0fb2301f613131324a01931bfa5759674317
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3811593
Commit-Queue: Claudio DeSouza <cdes...@igalia.com>
Reviewed-by: Giovanni Ortuno Urquidi <ort...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1032933}
---
M chrome/browser/ui/webui/ntp/cookie_controls_handler.cc
M chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc
M chrome/browser/ui/webui/policy/policy_ui_handler.cc
M chrome/browser/ui/webui/predictors/predictors_handler.cc
M chrome/browser/ui/webui/print_preview/print_preview_handler_chromeos.cc
M chrome/browser/ui/webui/profile_internals/profile_internals_handler.cc
M chrome/browser/ui/webui/profile_internals/profile_internals_handler.h
M chrome/browser/ui/webui/sandbox/sandbox_handler.cc
M chrome/browser/ui/webui/sandbox/sandbox_handler.h
9 files changed, 119 insertions(+), 112 deletions(-)

To view, visit change 3811593. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward

[CodeHealth] Chrome WebUI base::Value refactoring - Part 2 [chromium/src : main]

Claudio DeSouza (Gerrit)

Claudio DeSouza (Gerrit)

Giovanni Ortuno Urquidi (Gerrit)

Claudio DeSouza (Gerrit)

Chromium LUCI CQ (Gerrit)