jingjing gu (Gerrit)

unread,

Apr 13, 2026, 7:42:04 AMApr 13

to Olivia Saul, Stephen McGruer, Chromium LUCI CQ, chromium...@chromium.org

Attention needed from Olivia Saul and Stephen McGruer

jingjing gu voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention is currently required from:

Olivia Saul
Stephen McGruer

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Olivia Saul (Gerrit)

unread,

Apr 13, 2026, 2:20:06 PMApr 13

to jingjing gu, Siddharth Shah, Olivia Saul, Stephen McGruer, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org

Attention needed from Siddharth Shah and Stephen McGruer

Olivia Saul added 1 comment

Patchset-level comments

File-level comment, Patchset 7 (Latest):

Olivia Saul . resolved

Sid is more familiar with Facilitated Payments code than I am, so I'm going to defer this review to him and move myself to CC. Thank you!

Open in Gerrit

Related details

Attention is currently required from:

Siddharth Shah
Stephen McGruer

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Siddharth Shah (Gerrit)

unread,

Apr 13, 2026, 7:56:12 PMApr 13

to jingjing gu, Olivia Saul, Stephen McGruer, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org

Attention needed from Stephen McGruer and jingjing gu

Siddharth Shah added 1 comment

File chrome/browser/facilitated_payments/ui/android/internal/java/src/org/chromium/chrome/browser/facilitated_payments/FacilitatedPaymentsFopSelectorViewBinder.java

File-level comment, Patchset 7 (Latest):

Siddharth Shah . unresolved

I don't think these belong to a FopSelectorViewBinder. The header/continue button/additional info are common properties of the PaymentMethodsView and thus should be usable for multiple screens instead of just the FopSelector.

Open in Gerrit

Related details

Attention is currently required from:

Stephen McGruer
jingjing gu

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

jingjing gu (Gerrit)

unread,

Apr 19, 2026, 12:14:30 PM (11 days ago) Apr 19

to Siddharth Shah, Olivia Saul, Stephen McGruer, Chromium LUCI CQ, chromium...@chromium.org

Attention needed from Siddharth Shah and Stephen McGruer

jingjing gu added 1 comment

File chrome/browser/facilitated_payments/ui/android/internal/java/src/org/chromium/chrome/browser/facilitated_payments/FacilitatedPaymentsFopSelectorViewBinder.java

File-level comment, Patchset 7:

Siddharth Shah . unresolved

I don't think these belong to a FopSelectorViewBinder. The header/continue button/additional info are common properties of the PaymentMethodsView and thus should be usable for multiple screens instead of just the FopSelector.

jingjing gu

Thanks for the feedback! You're right — header, continue button, and additional info shouldn't be tied to FopSelector since they're reusable across screens.

Extracted them into per-item-type ViewBinder classes following the existing pattern (like BankAccountViewBinder).

Open in Gerrit

Related details

Attention is currently required from:

Siddharth Shah
Stephen McGruer

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Siddharth Shah (Gerrit)

unread,

Apr 20, 2026, 1:50:21 PM (10 days ago) Apr 20

to jingjing gu, Olivia Saul, Stephen McGruer, Chromium LUCI CQ, chromium...@chromium.org

Attention needed from Stephen McGruer and jingjing gu

Siddharth Shah voted and added 2 comments

Votes added by Siddharth Shah

Code-Review

+1

2 comments

Commit Message

Line 9, Patchset 9 (Latest):

Move FOP selector list item binding out of
FacilitatedPaymentsPaymentMethodsViewBinder into a dedicated
FacilitatedPaymentsFopSelectorViewBinder.

This keeps the payment methods view binder focused on screen-level
sequence view setup while the FOP selector screen owns binding for
its header, additional info, continue button, and footer items.

Siddharth Shah . unresolved

Please update the commit message now that the implementation has changed.

File chrome/browser/facilitated_payments/ui/android/internal/java/src/org/chromium/chrome/browser/facilitated_payments/FacilitatedPaymentsFopSelectorViewBinder.java

File-level comment, Patchset 7:

Siddharth Shah . resolved

I don't think these belong to a FopSelectorViewBinder. The header/continue button/additional info are common properties of the PaymentMethodsView and thus should be usable for multiple screens instead of just the FopSelector.

jingjing gu

Thanks for the feedback! You're right — header, continue button, and additional info shouldn't be tied to FopSelector since they're reusable across screens.
Extracted them into per-item-type ViewBinder classes following the existing pattern (like BankAccountViewBinder).

Siddharth Shah

Thanks for doing this!

Open in Gerrit

Related details

Attention is currently required from:

Stephen McGruer
jingjing gu

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

jingjing gu (Gerrit)

unread,

Apr 20, 2026, 7:36:57 PM (10 days ago) Apr 20

to Siddharth Shah, Olivia Saul, Stephen McGruer, Chromium LUCI CQ, chromium...@chromium.org

Attention needed from Stephen McGruer

jingjing gu added 1 comment

File chrome/browser/facilitated_payments/ui/android/internal/java/src/org/chromium/chrome/browser/facilitated_payments/FacilitatedPaymentsFopSelectorViewBinder.java

File-level comment, Patchset 7:

Siddharth Shah . resolved

I don't think these belong to a FopSelectorViewBinder. The header/continue button/additional info are common properties of the PaymentMethodsView and thus should be usable for multiple screens instead of just the FopSelector.

jingjing gu

Thanks for the feedback! You're right — header, continue button, and additional info shouldn't be tied to FopSelector since they're reusable across screens.
Extracted them into per-item-type ViewBinder classes following the existing pattern (like BankAccountViewBinder).

Siddharth Shah

Thanks for doing this!

jingjing gu

Thanks for the reminder! Updated.

Open in Gerrit

Related details

Attention is currently required from:

Stephen McGruer

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Olivia Saul (Gerrit)

unread,

Apr 20, 2026, 7:57:15 PM (10 days ago) Apr 20

to jingjing gu, Olivia Saul, Lei Zhang, Siddharth Shah, Chromium LUCI CQ, chromium...@chromium.org

Attention needed from Lei Zhang and jingjing gu

Olivia Saul added 1 comment

Patchset-level comments

File-level comment, Patchset 11 (Latest):

Olivia Saul . resolved

Is there anything in particular you need my review for? Sid (already LGTM'd) is a code owner for all of these files, as far as I can tell.

Open in Gerrit

Related details

Attention is currently required from:

Lei Zhang
jingjing gu

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Lei Zhang (Gerrit)

unread,

Apr 20, 2026, 8:00:57 PM (10 days ago) Apr 20

to jingjing gu, Sky Malice, Lei Zhang, Olivia Saul, Siddharth Shah, Chromium LUCI CQ, chromium...@chromium.org

Attention needed from Sky Malice and jingjing gu

Lei Zhang added 1 comment

Patchset-level comments

File-level comment, Patchset 11 (Latest):

Lei Zhang . resolved

I don't think you actually need chrome/OWNERS. So replacing myself with someone from chrome/android/OWNERS.

Open in Gerrit

Related details

Attention is currently required from:

Sky Malice
jingjing gu

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Lei Zhang (Gerrit)

unread,

Apr 20, 2026, 8:01:30 PM (10 days ago) Apr 20

to jingjing gu, Sky Malice, Lei Zhang, Olivia Saul, Siddharth Shah, Chromium LUCI CQ, chromium...@chromium.org

Attention needed from Olivia Saul, Sky Malice and jingjing gu

Lei Zhang added 1 comment

Patchset-level comments

File-level comment, Patchset 11 (Latest):

Olivia Saul . resolved

Is there anything in particular you need my review for? Sid (already LGTM'd) is a code owner for all of these files, as far as I can tell.

Lei Zhang

I think the CL just needs a second CR+1.

Open in Gerrit

Related details

Attention is currently required from:

Olivia Saul
Sky Malice
jingjing gu

satisfied_requirement

unsatisfied_requirement

open

diffy

Olivia Saul (Gerrit)

unread,

Apr 20, 2026, 8:06:38 PM (10 days ago) Apr 20

to jingjing gu, Olivia Saul, Sky Malice, Lei Zhang, Siddharth Shah, Chromium LUCI CQ, chromium...@chromium.org

Attention needed from Lei Zhang, Sky Malice and jingjing gu

Olivia Saul voted and added 1 comment

Votes added by Olivia Saul

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 11 (Latest):

Olivia Saul . resolved

Is there anything in particular you need my review for? Sid (already LGTM'd) is a code owner for all of these files, as far as I can tell.

Lei Zhang

I think the CL just needs a second CR+1.

Olivia Saul

Ah, I missed that; thanks!

I would rather Sky be the second CR+1, but in case you're blocked and this is urgent, I'll CR+1 because I trust Sid's judgement and nothing jumps out at me in the CL itself.

Open in Gerrit

Related details

Attention is currently required from:

Lei Zhang
Sky Malice
jingjing gu

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

jingjing gu (Gerrit)

unread,

Apr 20, 2026, 9:27:56 PM (10 days ago) Apr 20

to Olivia Saul, Sky Malice, Lei Zhang, Siddharth Shah, Chromium LUCI CQ, chromium...@chromium.org

Attention needed from Sky Malice

jingjing gu added 1 comment

Commit Message

Line 9, Patchset 9:Move FOP selector list item binding out of


FacilitatedPaymentsPaymentMethodsViewBinder into a dedicated
FacilitatedPaymentsFopSelectorViewBinder.

This keeps the payment methods view binder focused on screen-level
sequence view setup while the FOP selector screen owns binding for
its header, additional info, continue button, and footer items.

Siddharth Shah . resolved

Please update the commit message now that the implementation has changed.

jingjing gu

Thanks for the reminder! Updated.

Open in Gerrit

Related details

Attention is currently required from:

Sky Malice

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

jingjing gu (Gerrit)

unread,

Apr 20, 2026, 9:28:00 PM (10 days ago) Apr 20

to Olivia Saul, Sky Malice, Lei Zhang, Siddharth Shah, Chromium LUCI CQ, chromium...@chromium.org

Attention needed from Sky Malice

jingjing gu voted Commit-Queue+2

Commit-Queue

+2

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Apr 20, 2026, 10:05:20 PM (10 days ago) Apr 20

to jingjing gu, Olivia Saul, Sky Malice, Lei Zhang, Siddharth Shah, chromium...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

[browser] Split facilitated payments FOP selector binder

Extract per-item-type ViewBinder classes from
FacilitatedPaymentsPaymentMethodsViewBinder, following the existing
pattern used by BankAccountViewBinder and similar classes:

- HeaderViewBinder: binds header items
- ContinueButtonViewBinder: binds the continue button
- AdditionalInfoViewBinder: binds additional info items
- FooterViewBinder: binds footer items

This keeps FacilitatedPaymentsPaymentMethodsViewBinder focused on
screen-level setup and makes the individual binders reusable across
different screens.

Bug: 348595414

Change-Id: I2186bc35b8e9e72b1d5bac5d222aa88a5528d57f

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7754540

Reviewed-by: Olivia Saul <os...@google.com>

Reviewed-by: Siddharth Shah <sia...@google.com>

Commit-Queue: jingjing gu <jingj...@microsoft.com>

Cr-Commit-Position: refs/heads/main@{#1617931}

Files:

M chrome/browser/facilitated_payments/ui/android/internal/BUILD.gn
A chrome/browser/facilitated_payments/ui/android/internal/java/src/org/chromium/chrome/browser/facilitated_payments/AdditionalInfoViewBinder.java
A chrome/browser/facilitated_payments/ui/android/internal/java/src/org/chromium/chrome/browser/facilitated_payments/ContinueButtonViewBinder.java
M chrome/browser/facilitated_payments/ui/android/internal/java/src/org/chromium/chrome/browser/facilitated_payments/FacilitatedPaymentsFopSelectorScreen.java
M chrome/browser/facilitated_payments/ui/android/internal/java/src/org/chromium/chrome/browser/facilitated_payments/FacilitatedPaymentsPaymentMethodsViewBinder.java
A chrome/browser/facilitated_payments/ui/android/internal/java/src/org/chromium/chrome/browser/facilitated_payments/FooterViewBinder.java
A chrome/browser/facilitated_payments/ui/android/internal/java/src/org/chromium/chrome/browser/facilitated_payments/HeaderViewBinder.java

Change size: L

Delta: 7 files changed, 285 insertions(+), 234 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Siddharth Shah, +1 by Olivia Saul

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

[browser] Split facilitated payments FOP selector binder [chromium/src : main]

jingjing gu (Gerrit)

jingjing gu voted Commit-Queue+1

Related details

Olivia Saul (Gerrit)

Olivia Saul added 1 comment

Related details

Siddharth Shah (Gerrit)

Siddharth Shah added 1 comment

Related details

jingjing gu (Gerrit)

jingjing gu added 1 comment

Related details

Siddharth Shah (Gerrit)

Siddharth Shah voted and added 2 comments

Votes added by Siddharth Shah

2 comments

Related details

jingjing gu (Gerrit)

jingjing gu added 1 comment

Related details

Olivia Saul (Gerrit)

Olivia Saul added 1 comment

Related details

Lei Zhang (Gerrit)

Lei Zhang added 1 comment

Related details

Lei Zhang (Gerrit)

Lei Zhang added 1 comment

Related details

Olivia Saul (Gerrit)

Olivia Saul voted and added 1 comment

Votes added by Olivia Saul

1 comment

Related details

jingjing gu (Gerrit)

jingjing gu added 1 comment

Related details

jingjing gu (Gerrit)

jingjing gu voted Commit-Queue+2

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information