Modularize signin bound_session_credentials test fakes and mocks [chromium/src : main]
0 views
Skip to first unread message
Erik Chen (Gerrit)
Jul 20, 2026, 10:59:17 PM (20 hours ago) Jul 20
to Thomas Lukaszewicz, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Thomas Lukaszewicz
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Thomas Lukaszewicz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thomas Lukaszewicz (Gerrit)
Jul 20, 2026, 11:19:23 PM (20 hours ago) Jul 20
to Erik Chen, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Erik Chen
Thomas Lukaszewicz voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Erik Chen
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Erik Chen (Gerrit)
1:39 AM (17 hours ago) 1:39 AM
to Thomas Lukaszewicz, Chromium LUCI CQ, chromium...@chromium.org
Erik Chen voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
1:43 AM (17 hours ago) 1:43 AM
to Erik Chen, Thomas Lukaszewicz, chromium...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Modularize signin bound_session_credentials test fakes and mocks
Move the bound_session_credentials fake/mock cookie-refresh
service and refresh-cookie fetcher out of //chrome/test into the
existing //chrome/browser/signin:test_support source_set, under
enable_bound_session_credentials. signin:unit_tests (the only consumer)
already depends on :test_support, so only the source lines move.
Bug: 353332589
AGENT_GENERATED_CL
Change-Id: I6972ebc60becafaa004d56fa14f296149cb73f15
Reviewed-by: Thomas Lukaszewicz <tl...@chromium.org>
Commit-Queue: Erik Chen <erik...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1665194}
Files:
- M chrome/browser/signin/BUILD.gn
- M chrome/test/BUILD.gn
Change size: S
Delta: 2 files changed, 17 insertions(+), 6 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Thomas Lukaszewicz
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
1:57 PM (5 hours ago) 1:57 PM
to Erik Chen, Chromium LUCI CQ, Lei Zhang, Thomas Lukaszewicz, chromium...@chromium.org
Attention needed from Erik Chen
Lei Zhang added 1 comment![]( "Open in Gerrit")
File chrome/test/BUILD.gn
Line 8194, Patchset 2 (Latest):
sources += [Lei Zhang . unresolved
Same unformatted empty list issue here.
Related details
Attention is currently required from:
- Erik Chen
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Erik Chen (Gerrit)
4:34 PM (2 hours ago) 4:34 PM
to Chromium LUCI CQ, Lei Zhang, Thomas Lukaszewicz, chromium...@chromium.org
Erik Chen added 1 comment![]( "Open in Gerrit")
File chrome/test/BUILD.gn
Line 8194, Patchset 2 (Latest):
sources += [Lei Zhang . resolved
Same unformatted empty list issue here.
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages