[iOS][mvt-customization] Add layout guide for first most visited tile [chromium/src : main]
0 views
Skip to first unread message
Ginny Huang (Gerrit)
Jan 12, 2026, 11:22:02 AM (2 days ago) Jan 12
to Gauthier Ambard, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Gauthier Ambard
Ginny Huang voted and added 1 comment![]( "Open in Gerrit")
Votes added by Ginny Huang
| Auto-Submit | +1 |
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Gauthier Ambard
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ginny Huang (Gerrit)
Jan 12, 2026, 11:22:27 AM (2 days ago) Jan 12
to Chromium LUCI CQ, Gauthier Ambard, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Gauthier Ambard
Ginny Huang added 1 comment![]( "Open in Gerrit")
File ios/chrome/browser/content_suggestions/most_visited_tiles/ui/most_visited_tiles_collection_view.mm
Line 226, Patchset 1 (Latest):
} else if ([_layoutGuideCenter
referencedViewUnderName:kNTPFirstMostVisitedTile] == cell) {Related details
Attention is currently required from:
- Gauthier Ambard
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ginny Huang (Gerrit)
Jan 12, 2026, 11:29:30 AM (2 days ago) Jan 12
to Chromium LUCI CQ, Gauthier Ambard, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Gauthier Ambard
Ginny Huang voted![]( "Open in Gerrit")
| Auto-Submit | +1 |
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Gauthier Ambard
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ginny Huang (Gerrit)
Jan 12, 2026, 11:32:04 AM (2 days ago) Jan 12
to Chromium LUCI CQ, Gauthier Ambard, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Gauthier Ambard
Ginny Huang voted![]( "Open in Gerrit")
| Auto-Submit | +1 |
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Gauthier Ambard
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gauthier Ambard (Gerrit)
Jan 12, 2026, 4:29:42 PM (2 days ago) Jan 12
to Ginny Huang, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Ginny Huang
Gauthier Ambard voted and added 2 comments![]( "Open in Gerrit")
Votes added by Gauthier Ambard
| Code-Review | +1 |
2 comments
File ios/chrome/browser/content_suggestions/most_visited_tiles/coordinator/most_visited_tiles_mediator.h
Line 91, Patchset 3 (Latest):
layoutGuideCenter:(LayoutGuideCenter*)layoutGuideCenterGauthier Ambard . resolved
That's a very convoluted initializer, but I don't have a better solution
File ios/chrome/browser/content_suggestions/most_visited_tiles/ui/most_visited_tiles_collection_view.mm
Line 226, Patchset 1:
} else if ([_layoutGuideCenter
referencedViewUnderName:kNTPFirstMostVisitedTile] == cell) {Gauthier Ambard
Yes in the sense that the layout guide won't be attached to a cell displaying something else, but it might be attached to a view that isn't displayed.
I guess make sure that the view it is attached to is in the screen bounds and has a window when you want to use it?
Related details
Attention is currently required from:
- Ginny Huang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ginny Huang (Gerrit)
Jan 13, 2026, 1:29:36 AM (yesterday) Jan 13
to Gauthier Ambard, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Ginny Huang voted and added 1 comment![]( "Open in Gerrit")
Votes added by Ginny Huang
| Auto-Submit | +0 |
| Commit-Queue | +1 |
1 comment
File ios/chrome/browser/content_suggestions/most_visited_tiles/ui/most_visited_tiles_collection_view.mm
Line 226, Patchset 1:
} else if ([_layoutGuideCenter
referencedViewUnderName:kNTPFirstMostVisitedTile] == cell) {Ginny Huang . resolved
Gauthier Ambard@gam...@chromium.org I think this should take care of reuse? Thanks!
Yes in the sense that the layout guide won't be attached to a cell displaying something else, but it might be attached to a view that isn't displayed.
I guess make sure that the view it is attached to is in the screen bounds and has a window when you want to use it?
Ginny Huang
That's my understanding as well... Thanks!
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ginny Huang (Gerrit)
Jan 13, 2026, 1:34:26 AM (yesterday) Jan 13
to Gauthier Ambard, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Ginny Huang removed a vote from this change![]( "Open in Gerrit")
Removed Commit-Queue+1 by Ginny Huang <ginny...@chromium.org>
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ginny Huang (Gerrit)
1:34 PM (10 hours ago) 1:34 PM
to Gauthier Ambard, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Ginny Huang voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ginny Huang (Gerrit)
4:02 PM (7 hours ago) 4:02 PM
to Gauthier Ambard, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Ginny Huang voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ginny Huang (Gerrit)
6:07 PM (5 hours ago) 6:07 PM
to Gauthier Ambard, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Ginny Huang voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
7:45 PM (4 hours ago) 7:45 PM
to Ginny Huang, Gauthier Ambard, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
3 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: ios/chrome/browser/content_suggestions/magic_stack/coordinator/magic_stack_ranking_model_unittest.mm
Insertions: 1, Deletions: 1.
The diff is too large to show. Please review the diff.
```
```
The name of the file: ios/chrome/browser/content_suggestions/most_visited_tiles/coordinator/most_visited_tiles_mediator_unittest.mm
Insertions: 1, Deletions: 1.
The diff is too large to show. Please review the diff.
```
Change information
Commit message:
[iOS][mvt-customization] Add layout guide for first most visited tile
This CL adds a layout guide for the first most visited tile so the in-
product help could anchor its arrow to it.
Bug: 475119329
Change-Id: Ice0d8caa8ccff01fa376a1ae557f0cdade467ad2
Reviewed-by: Gauthier Ambard <gam...@chromium.org>
Commit-Queue: Ginny Huang <ginny...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1569439}
Files:
- M ios/chrome/browser/content_suggestions/coordinator/content_suggestions_coordinator.mm
- M ios/chrome/browser/content_suggestions/magic_stack/coordinator/BUILD.gn
- M ios/chrome/browser/content_suggestions/magic_stack/coordinator/magic_stack_ranking_model_unittest.mm
- M ios/chrome/browser/content_suggestions/most_visited_tiles/coordinator/most_visited_tiles_mediator.h
- M ios/chrome/browser/content_suggestions/most_visited_tiles/coordinator/most_visited_tiles_mediator.mm
- M ios/chrome/browser/content_suggestions/most_visited_tiles/coordinator/most_visited_tiles_mediator_unittest.mm
- M ios/chrome/browser/content_suggestions/most_visited_tiles/ui/BUILD.gn
- M ios/chrome/browser/content_suggestions/most_visited_tiles/ui/most_visited_tiles_collection_view.mm
- M ios/chrome/browser/content_suggestions/most_visited_tiles/ui/most_visited_tiles_config.h
- M ios/chrome/browser/content_suggestions/most_visited_tiles/ui/most_visited_tiles_config.mm
- M ios/chrome/browser/shared/ui/util/layout_guide_names.h
- M ios/chrome/browser/shared/ui/util/layout_guide_names.mm
Change size: M
Delta: 12 files changed, 61 insertions(+), 6 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Gauthier Ambard
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages