Ash: Migrate SocsCookieFetcherTest off RunUntilIdle [chromium/src : main]
0 views
Skip to first unread message
Mohammed Abdon (Gerrit)
May 31, 2026, 11:22:57 PM (1 hour ago) May 31
to Di Wu, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Di Wu
Mohammed Abdon voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Di Wu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Di Wu (Gerrit)
May 31, 2026, 11:44:16 PM (1 hour ago) May 31
to Mohammed Abdon, Chromium LUCI CQ, chromium...@chromium.org
Di Wu voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
12:08 AM (1 hour ago) 12:08 AM
to Di Wu, Mohammed Abdon, chromium...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Ash: Migrate SocsCookieFetcherTest off RunUntilIdle
This changelist is part of an ongoing series to modernize Ash tests by
migrating them away from RunUntilIdle() and toward targeted
synchronization with APIs such as RunUntil(), TestFuture, RunLoop
callbacks, observer waiters, or exact mock-time advancement.
SocsCookieFetcherTest now registers a fetch-complete callback on its
test consumer before starting the request. The test waits for the
consumer callback that reports success or failure, then checks that the
SOCS cookie fetch reached the success path.
Bug: b:506794349
Test: CQ
Change-Id: I2becd15867813acdeecdd953ae75e4f0715dad61
Commit-Queue: Di Wu <di...@google.com>
Reviewed-by: Mohammed Abdon <mohamm...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1639164}
Files:
- M chrome/browser/ash/app_list/search/essential_search/socs_cookie_fetcher_unittest.cc
Change size: S
Delta: 1 file changed, 23 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Mohammed Abdon
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages