[Extensions] Remove nodoc from sidePanel.close() method. [chromium/src : main]

[Harsh Singh (Gerrit)]

Attention needed from Devlin Cronin, Oliver Dunk and Solomon Kinard

Harsh Singh voted and added 1 comment

Votes added by Harsh Singh

Commit-Queue

+1

1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Harsh Singh . resolved

We've tested this in Canary and received approval from WECG, so I think we’re good to go!

Open in Gerrit

Related details

Attention is currently required from:

• Devlin Cronin
• Oliver Dunk
• Solomon Kinard

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Iaf9a54322b4df2958f85d99949bb702cd2418498

Gerrit-Change-Number: 6893345

Gerrit-PatchSet: 1

Gerrit-Owner: Harsh Singh <harshsin...@gmail.com>

Gerrit-Reviewer: Devlin Cronin <rdevlin...@chromium.org>

Gerrit-Reviewer: Harsh Singh <harshsin...@gmail.com>

Gerrit-Reviewer: Oliver Dunk <olive...@chromium.org>

Gerrit-Reviewer: Solomon Kinard <solomo...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Oliver Dunk <olive...@chromium.org>

Gerrit-Attention: Solomon Kinard <solomo...@chromium.org>

Gerrit-Attention: Devlin Cronin <rdevlin...@chromium.org>

Gerrit-Comment-Date: Wed, 27 Aug 2025 23:10:00 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Solomon Kinard (Gerrit)]

Attention needed from Devlin Cronin, Harsh Singh and Oliver Dunk

Solomon Kinard voted and added 1 comment

Votes added by Solomon Kinard

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Solomon Kinard . resolved

Thanks.

Open in Gerrit

Related details

Attention is currently required from:

• Devlin Cronin
• Harsh Singh
• Oliver Dunk

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Iaf9a54322b4df2958f85d99949bb702cd2418498

Gerrit-Change-Number: 6893345

Gerrit-PatchSet: 1

Gerrit-Owner: Harsh Singh <harshsin...@gmail.com>

Gerrit-Reviewer: Devlin Cronin <rdevlin...@chromium.org>

Gerrit-Reviewer: Harsh Singh <harshsin...@gmail.com>

Gerrit-Reviewer: Oliver Dunk <olive...@chromium.org>

Gerrit-Reviewer: Solomon Kinard <solomo...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Harsh Singh <harshsin...@gmail.com>

Gerrit-Attention: Oliver Dunk <olive...@chromium.org>

Gerrit-Attention: Devlin Cronin <rdevlin...@chromium.org>

Gerrit-Comment-Date: Wed, 27 Aug 2025 23:20:40 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Oliver Dunk (Gerrit)]

Attention needed from Devlin Cronin and Harsh Singh

Oliver Dunk added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Harsh Singh . unresolved

We've tested this in Canary and received approval from WECG, so I think we’re good to go!

Oliver Dunk

Sorry for the churn, but there's an open question from Safari around this one which I think we **should** resolve before landing: https://github.com/w3c/webextensions/pull/837#issuecomment-3187114759. I'll try to follow-up on this today.

Open in Gerrit

Related details

Attention is currently required from:

• Devlin Cronin
• Harsh Singh

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Iaf9a54322b4df2958f85d99949bb702cd2418498

Gerrit-Change-Number: 6893345

Gerrit-PatchSet: 1

Gerrit-Owner: Harsh Singh <harshsin...@gmail.com>

Gerrit-Reviewer: Devlin Cronin <rdevlin...@chromium.org>

Gerrit-Reviewer: Harsh Singh <harshsin...@gmail.com>

Gerrit-Reviewer: Oliver Dunk <olive...@chromium.org>

Gerrit-Reviewer: Solomon Kinard <solomo...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Harsh Singh <harshsin...@gmail.com>

Gerrit-Attention: Devlin Cronin <rdevlin...@chromium.org>

Gerrit-Comment-Date: Thu, 28 Aug 2025 09:14:57 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Harsh Singh <harshsin...@gmail.com>

[Oliver Dunk (Gerrit)]

Attention needed from Harsh Singh

Oliver Dunk voted and added 2 comments

Votes added by Oliver Dunk

Code-Review

+1

2 comments

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Oliver Dunk . resolved

Thanks, Harsh!

File-level comment, Patchset 1 (Latest):

Harsh Singh . resolved

We've tested this in Canary and received approval from WECG, so I think we’re good to go!

Oliver Dunk

Sorry for the churn, but there's an open question from Safari around this one which I think we **should** resolve before landing: https://github.com/w3c/webextensions/pull/837#issuecomment-3187114759. I'll try to follow-up on this today.

Oliver Dunk

We resolved this in the WECG and agreed there should not be any fallback [1]. This was updated in a recent CL [2], so we are now good to land this.

[1] https://github.com/w3c/webextensions/blob/5210f657a46dd610e25a00a0ceebfa7c2c6d65a1/_minutes/2025-11-14-wecg-tpac.md?plain=1#L71
[2] https://chromium-review.googlesource.com/c/chromium/src/+/7317143

Open in Gerrit

Related details

Attention is currently required from:

• Harsh Singh

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Iaf9a54322b4df2958f85d99949bb702cd2418498

Gerrit-Change-Number: 6893345

Gerrit-PatchSet: 1

Gerrit-Owner: Harsh Singh <harshsin...@gmail.com>

Gerrit-Reviewer: Devlin Cronin <rdevlin...@chromium.org>

Gerrit-Reviewer: Harsh Singh <harshsin...@gmail.com>

Gerrit-Reviewer: Oliver Dunk <olive...@chromium.org>

Gerrit-Reviewer: Solomon Kinard <solomo...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Harsh Singh <harshsin...@gmail.com>

Gerrit-Comment-Date: Mon, 12 Jan 2026 11:57:36 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

Comment-In-Reply-To: Oliver Dunk <olive...@chromium.org>

Comment-In-Reply-To: Harsh Singh <harshsin...@gmail.com>

[Harsh Singh (Gerrit)]

Attention needed from Oliver Dunk and Solomon Kinard

Harsh Singh added 1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Harsh Singh . resolved

Thanks Solomon and Oliver!

Open in Gerrit

Related details

Attention is currently required from:

• Oliver Dunk
• Solomon Kinard

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Iaf9a54322b4df2958f85d99949bb702cd2418498

Gerrit-Change-Number: 6893345

Gerrit-PatchSet: 4

Gerrit-Owner: Harsh Singh <harshsin...@gmail.com>

Gerrit-Reviewer: Devlin Cronin <rdevlin...@chromium.org>

Gerrit-Reviewer: Harsh Singh <harshsin...@gmail.com>

Gerrit-Reviewer: Oliver Dunk <olive...@chromium.org>

Gerrit-Reviewer: Solomon Kinard <solomo...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Solomon Kinard <solomo...@chromium.org>

Gerrit-Attention: Oliver Dunk <olive...@chromium.org>

Gerrit-Comment-Date: Mon, 12 Jan 2026 12:38:02 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Oliver Dunk (Gerrit)]

Attention needed from Harsh Singh and Solomon Kinard

Oliver Dunk voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Harsh Singh
• Solomon Kinard

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Iaf9a54322b4df2958f85d99949bb702cd2418498

Gerrit-Change-Number: 6893345

Gerrit-PatchSet: 4

Gerrit-Owner: Harsh Singh <harshsin...@gmail.com>

Gerrit-Reviewer: Devlin Cronin <rdevlin...@chromium.org>

Gerrit-Reviewer: Harsh Singh <harshsin...@gmail.com>

Gerrit-Reviewer: Oliver Dunk <olive...@chromium.org>

Gerrit-Reviewer: Solomon Kinard <solomo...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Solomon Kinard <solomo...@chromium.org>

Gerrit-Attention: Harsh Singh <harshsin...@gmail.com>

Gerrit-Comment-Date: Mon, 12 Jan 2026 13:30:12 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Solomon Kinard (Gerrit)]

Attention needed from Harsh Singh

Solomon Kinard voted and added 1 comment

Votes added by Solomon Kinard

Code-Review

+1

1 comment

Commit Message

Line 11, Patchset 4 (Latest):Reference: https://github.com/w3c/webextensions/pull/837
Bug: 403765214

Solomon Kinard . unresolved

I could be wrong, but I think that I've seen a comment before asking for a newline before Bug.

```suggestion
Reference: https://github.com/w3c/webextensions/pull/837

Bug: 403765214
```

Open in Gerrit

Related details

Attention is currently required from:

• Harsh Singh

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Iaf9a54322b4df2958f85d99949bb702cd2418498

Gerrit-Change-Number: 6893345

Gerrit-PatchSet: 4

Gerrit-Owner: Harsh Singh <harshsin...@gmail.com>

Gerrit-Reviewer: Devlin Cronin <rdevlin...@chromium.org>

Gerrit-Reviewer: Harsh Singh <harshsin...@gmail.com>

Gerrit-Reviewer: Oliver Dunk <olive...@chromium.org>

Gerrit-Reviewer: Solomon Kinard <solomo...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Harsh Singh <harshsin...@gmail.com>

Gerrit-Comment-Date: Mon, 12 Jan 2026 16:10:16 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Harsh Singh (Gerrit)]

Harsh Singh voted and added 2 comments

Votes added by Harsh Singh

Commit-Queue

+2

2 comments

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Harsh Singh . resolved

Thanks

Commit Message

Line 11, Patchset 4:Reference: https://github.com/w3c/webextensions/pull/837
Bug: 403765214

Solomon Kinard . resolved

I could be wrong, but I think that I've seen a comment before asking for a newline before Bug.

```suggestion
Reference: https://github.com/w3c/webextensions/pull/837

Bug: 403765214
```

Harsh Singh

Done

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Iaf9a54322b4df2958f85d99949bb702cd2418498

Gerrit-Change-Number: 6893345

Gerrit-PatchSet: 5

Gerrit-Owner: Harsh Singh <harshsin...@gmail.com>

Gerrit-Reviewer: Devlin Cronin <rdevlin...@chromium.org>

Gerrit-Reviewer: Harsh Singh <harshsin...@gmail.com>

Gerrit-Reviewer: Oliver Dunk <olive...@chromium.org>

Gerrit-Reviewer: Solomon Kinard <solomo...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Comment-Date: Mon, 12 Jan 2026 17:27:10 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

Comment-In-Reply-To: Solomon Kinard <solomo...@chromium.org>

[Harsh Singh (Gerrit)]

Attention needed from Devlin Cronin

Harsh Singh added 1 comment

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Harsh Singh . resolved

Hello Devlin, requesting a +1 for code owner approval. Thanks!

Open in Gerrit

Related details

Attention is currently required from:

• Devlin Cronin

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Iaf9a54322b4df2958f85d99949bb702cd2418498

Gerrit-Change-Number: 6893345

Gerrit-PatchSet: 5

Gerrit-Owner: Harsh Singh <harshsin...@gmail.com>

Gerrit-Reviewer: Devlin Cronin <rdevlin...@chromium.org>

Gerrit-Reviewer: Harsh Singh <harshsin...@gmail.com>

Gerrit-Reviewer: Oliver Dunk <olive...@chromium.org>

Gerrit-Reviewer: Solomon Kinard <solomo...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Devlin Cronin <rdevlin...@chromium.org>

Gerrit-Comment-Date: Mon, 12 Jan 2026 17:38:53 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No