[bedrock]: Restore media-permission methods on DocumentPipHost [chromium/src : main]
0 views
Skip to first unread message
Jiayu Chen (Gerrit)
Jun 24, 2026, 9:25:46 PM (4 days ago) Jun 24
to Thomas Lukaszewicz, Qikai Zhong, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Qikai Zhong and Thomas Lukaszewicz
Jiayu Chen added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 6 (Latest):
Jiayu Chen . resolved
Hi, could u help review this when available? Thx.
Related details
Attention is currently required from:
- Qikai Zhong
- Thomas Lukaszewicz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thomas Lukaszewicz (Gerrit)
Jun 24, 2026, 9:31:44 PM (4 days ago) Jun 24
to Jiayu Chen, Qikai Zhong, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Jiayu Chen and Qikai Zhong
Thomas Lukaszewicz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Thomas Lukaszewicz
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Jiayu Chen
- Qikai Zhong
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jiayu Chen (Gerrit)
Jun 24, 2026, 9:37:00 PM (4 days ago) Jun 24
to Thomas Lukaszewicz, Qikai Zhong, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Qikai Zhong
Jiayu Chen voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Qikai Zhong
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jiayu Chen (Gerrit)
Jun 24, 2026, 10:48:52 PM (4 days ago) Jun 24
to Thomas Lukaszewicz, Qikai Zhong, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Qikai Zhong
Jiayu Chen voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Qikai Zhong
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jun 24, 2026, 11:01:34 PM (4 days ago) Jun 24
to Jiayu Chen, Thomas Lukaszewicz, Qikai Zhong, chromium...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
7 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: chrome/browser/ui/views/picture_in_picture/document_pip_host.cc
Insertions: 1, Deletions: 0.
The diff is too large to show. Please review the diff.
```
Change information
Commit message:
[bedrock]: Restore media-permission methods on DocumentPipHost
The shared permission infrastructure now supports non-Browser hosts:
crrev.com/c/7986985 updated the bubble anchor utils to anchor to the
standalone PiP's location icon and dropped the Browser restriction in
CreatePermissionPrompt. With that in place, the host can route media
requests through the normal stack again:
- RequestMediaAccessPermission() forwards to
MediaCaptureDevicesDispatcher::ProcessMediaAccessRequest() with the
resolved extension, matching the Browser-backed behavior.
- CheckMediaAccessPermission() restores the real permission-state
lookup via MediaCaptureDevicesDispatcher.
- Drop the [[maybe_unused]] attribute on GetExtensionForOrigin and the
now-stale TODO comments.
- Create necessary tab helpers for the permission prompt flow.
Bug: 515252142
Change-Id: I2abdb5dc69545d93d9a7cc245ff5fa879e319d17
Commit-Queue: Jiayu Chen <jiay...@microsoft.com>
Reviewed-by: Thomas Lukaszewicz <tl...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1652143}
Files:
- M chrome/browser/ui/views/picture_in_picture/BUILD.gn
- M chrome/browser/ui/views/picture_in_picture/document_pip_host.cc
- M chrome/browser/ui/views/picture_in_picture/document_pip_host.h
- M chrome/browser/ui/views/picture_in_picture/document_pip_host_unittest.cc
Change size: M
Delta: 4 files changed, 101 insertions(+), 41 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Thomas Lukaszewicz
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages