Fix search box icon baseline focus outline disappearing on hover [chromium/src : main]

0 views

Skip to first unread message

Ben Chin (Gerrit)

unread,

12:23 AM (4 hours ago) 12:23 AM

to chromium...@chromium.org

Ben Chin has uploaded the change for review

Commit message

Fix search box icon baseline focus outline disappearing on hover

Previously, search_box_icon_background_selector_baseline.xml used a
single StateListDrawable (<selector>) to manage all interaction states.
Because the state_hovered item was defined above the state_focused item,
hovering over an already-focused search box button would cause the
selector to match the hovered state first, replacing the focus outline
ring with the solid hover background.

This CL fixes the issue by wrapping the selectors in a <layer-list>.
The solid background overlays (hovered, pressed) are now handled
independently on a lower layer, while the focus ring outline is
handled on a higher layer. This ensures the focus ring remains
visible even when the icon is simultaneously being hovered or pressed.

Bug: 487866187

Change-Id: I343002c3adb8f95b3cab9ea8a224748c7b88ffb7

Change diff

Change information

Files:

M components/browser_ui/widget/android/java/res/drawable/search_box_icon_background_selector_baseline.xml

Change size: M

Delta: 1 file changed, 34 insertions(+), 27 deletions(-)

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages