Etienne Dechamps (Gerrit)

unread,

Mar 20, 2026, 11:17:55 AM (3 days ago) Mar 20

to Ziwen Lin, Andrew Grieve, Chromium LUCI CQ, Peter Wen, AyeAye, chromium...@chromium.org, Peter Beverloo, Etienne Dechamps

Attention needed from Andrew Grieve, Peter Wen and Ziwen Lin

Etienne Dechamps has uploaded the change for review

Etienne Dechamps would like Ziwen Lin, Andrew Grieve, Chromium LUCI CQ and Peter Wen to review this change.

Commit message

Revert "[Build] Migrate Log usage." for Cronet

This reverts commit e82c6c9882580d49849afe7029671e25a0a353af.

Reason for revert: this change is not safe for Cronet. It is adding a dependency on a class (org.chromium.base.Log) that Cronet does not ship in the relevant packages. The change also ignored an explicit directive in Cronet's BUILD.gn urging authors to add dependencies to "deps_to_package". Downstream consumers will likely instantly blow up with a "class not found" error at runtime.

Original change's description:
> [Build] Migrate Log usage.
>
> Will enable NoAndroidLog errorprone check in a follow-up CL after migration is complete.
>
> Design Doc:
> https://docs.google.com/document/d/17pKwYfMG7OVyqgOQPplIH5U_dVtXOm8XA_aCbtZgWlQ/edit?usp=sharing
>
> Bug: 481747262
> Change-Id: I42f1e374590d3f98cd27807e0091192d87121fc2
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7555110
> Reviewed-by: Andrew Grieve <agr...@chromium.org>
> Commit-Queue: Ziwen Lin <ziw...@microsoft.com>
> Commit-Queue: Andrew Grieve <agr...@chromium.org>
> Owners-Override: Andrew Grieve <agr...@chromium.org>
> Reviewed-by: Peter Wen <wn...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1583521}

Bug: 481747262

Change-Id: Ie2b5255ae892ff0a0a7f3ec6e6e52d2a82ed9b1d

Change diff

Change information

Files:

M android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java
M android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumAwInit.java
M android_webview/java/src/org/chromium/android_webview/AndroidProtocolHandler.java
M android_webview/java/src/org/chromium/android_webview/AwPdfExporter.java
M android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java
M android_webview/java/src/org/chromium/android_webview/DefaultVideoPosterRequestHandler.java
M android_webview/java/src/org/chromium/android_webview/HttpAuthDatabase.java
M android_webview/java/src/org/chromium/android_webview/SslUtil.java
M android_webview/java/src/org/chromium/android_webview/gfx/JavaBrowserViewRendererHelper.java
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientGetDefaultVideoPosterTest.java
M android_webview/test/shell/src/org/chromium/android_webview/test/NullContentsClient.java
M android_webview/test/shell/src/org/chromium/android_webview/test/TestContentProvider.java
M android_webview/tools/captured_sites_tests/javatests/src/org/chromium/webview_ui_test/test/TestAutofillService.java
M android_webview/tools/captured_sites_tests/javatests/src/org/chromium/webview_ui_test/test/util/AutofillProfile.java
M android_webview/tools/system_webview_shell/apk/src/org/chromium/webview_shell/WebViewTracingActivity.java
M base/android/java/src/org/chromium/base/TraceEvent.java
M base/android/java/src/org/chromium/base/process_launcher/ChildProcessService.java
M build/android/gtest_apk/BUILD.gn
M build/android/gyp/errorprone.py
M build/config/android/internal_rules.gni
M build/config/android/rules.gni
M chrome/android/webapk/libs/client/BUILD.gn
M chrome/android/webapk/libs/runtime_library/BUILD.gn
M chrome/android/webapk/shell_apk/BUILD.gn
M chrome/browser/android/examples/custom_tabs_client/BUILD.gn
M chrome/browser/android/examples/custom_tabs_client/src/java/org/chromium/customtabsclient/ContextualMenuItemReceiver.java
M chrome/browser/android/examples/custom_tabs_client/src/java/org/chromium/customtabsclient/MainActivity.java
M chrome/browser/android/examples/custom_tabs_client/src/java/org/chromium/customtabsclient/shared/CustomTabsHelper.java
M components/android_autofill/browser/java/src/org/chromium/components/autofill/AutofillManagerWrapper.java
M components/bookmarks/common/android/BUILD.gn
M components/bookmarks/common/android/java/src/org/chromium/components/bookmarks/BookmarkId.java
M components/crash/android/java/src/org/chromium/components/crash/PureJavaExceptionReporter.java
M components/cronet/android/BUILD.gn
M components/cronet/android/api/src/org/chromium/net/CronetEngine.java
M components/cronet/android/api/src/org/chromium/net/CronetProvider.java
M components/cronet/android/fake/java/org/chromium/net/test/FakeUrlRequest.java
M components/cronet/android/java/src/org/chromium/net/httpflags/HttpFlagsLoader.java
M components/cronet/android/java/src/org/chromium/net/impl/AndroidHttpEngineBuilderWrapper.java
M components/cronet/android/java/src/org/chromium/net/impl/AndroidHttpEngineWrapper.java
M components/cronet/android/java/src/org/chromium/net/impl/AndroidRequestFinishedInfoWrapper.java
M components/cronet/android/java/src/org/chromium/net/impl/CronetLoggerFactory.java
M components/cronet/android/java/src/org/chromium/net/impl/JavaCronetEngine.java
M components/cronet/android/java/src/org/chromium/net/impl/JavaUrlRequest.java
M components/cronet/android/java/src/org/chromium/net/impl/UrlRequestBuilderImpl.java
M components/cronet/android/java/src/org/chromium/net/telemetry/CronetLoggerImpl.java
M components/cronet/android/java/src/org/chromium/net/telemetry/ExperimentalOptions.java
M components/cronet/android/java/src/org/chromium/net/telemetry/Hash.java
M components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java
M components/cronet/android/platform-only/org/chromium/net/ConnectivityManagerShim.java
M components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java
M components/cronet/android/test/smoketests/src/org/chromium/net/smoke/HttpTestServer.java
M components/embedder_support/android/java/src/org/chromium/components/embedder_support/util/InputStreamUtil.java
M components/webauthn/android/java/src/org/chromium/components/webauthn/WebauthnLogger.java
M content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeBasicsTest.java
M content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellActivity.java
M net/android/java/src/org/chromium/net/AndroidNetworkLibrary.java
M net/android/javatests/src/org/chromium/net/AndroidKeyStoreTestUtil.java
M net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java
M testing/android/reporter/BUILD.gn
M testing/android/reporter/java/src/org/chromium/test/reporter/TestStatusReporter.java
M third_party/android_provider/BUILD.gn
M third_party/androidx/overrides.gni
M tools/android/customtabs_benchmark/BUILD.gn
M tools/android/errorprone_plugin/src/org/chromium/tools/errorprone/plugin/NoAndroidLog.java
M ui/android/java/src/org/chromium/ui/gl/ChromeSurfaceTexture.java

Change size: M

Delta: 65 files changed, 75 insertions(+), 121 deletions(-)

Open in Gerrit

Related details

Attention is currently required from:

Andrew Grieve
Peter Wen
Ziwen Lin

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Rubber Stamper (Gerrit)

unread,

Mar 20, 2026, 11:18:38 AM (3 days ago) Mar 20

to Etienne Dechamps, Ziwen Lin, Andrew Grieve, Chromium LUCI CQ, Peter Wen, AyeAye, chromium...@chromium.org, Peter Beverloo, webauthn...@chromium.org, yfriedm...@chromium.org, lizeb...@chromium.org, torne...@chromium.org, browser-comp...@chromium.org, android-web...@chromium.org, derinel+wat...@google.com, nyquis...@chromium.org, asvitki...@chromium.org, webapks-...@chromium.org, agriev...@chromium.org, wnwen...@chromium.org, pasko...@chromium.org, net-r...@chromium.org

Attention needed from Andrew Grieve, Peter Wen and Ziwen Lin

Message from Rubber Stamper

The change is not in the configured time window. Rubber Stamper is only allowed to review reverts within 14 day(s). Learn more: go/rubber-stamper-user-guide.

Open in Gerrit

Related details

Attention is currently required from:

Andrew Grieve
Peter Wen
Ziwen Lin

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Andrew Grieve (Gerrit)

unread,

Mar 20, 2026, 11:30:20 AM (3 days ago) Mar 20

to Etienne Dechamps, Ziwen Lin, Andrew Grieve, Chromium LUCI CQ, Peter Wen, AyeAye, chromium...@chromium.org, Peter Beverloo, webauthn...@chromium.org, yfriedm...@chromium.org, lizeb...@chromium.org, torne...@chromium.org, browser-comp...@chromium.org, android-web...@chromium.org, derinel+wat...@google.com, nyquis...@chromium.org, asvitki...@chromium.org, webapks-...@chromium.org, agriev...@chromium.org, wnwen...@chromium.org, pasko...@chromium.org, net-r...@chromium.org

Attention needed from Etienne Dechamps, Peter Wen and Ziwen Lin

Andrew Grieve added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Andrew Grieve . resolved

Sorry about that.

I think to get this reverted, you'll need to restrict to the files within //components/cronet, and then add to your android_library targets: `errorprone_args = [ "-Xep:NoAndroidLog:OFF" ]`

Open in Gerrit

Related details

Attention is currently required from:

Etienne Dechamps
Peter Wen
Ziwen Lin

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Etienne Dechamps (Gerrit)

unread,

Mar 20, 2026, 11:52:32 AM (3 days ago) Mar 20

to Etienne Dechamps, Mohannad Farrag, Peter Wen, Andrew Grieve, Ziwen Lin, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Peter Beverloo, webauthn...@chromium.org, yfriedm...@chromium.org, lizeb...@chromium.org, torne...@chromium.org, browser-comp...@chromium.org, android-web...@chromium.org, derinel+wat...@google.com, nyquis...@chromium.org, asvitki...@chromium.org, webapks-...@chromium.org, agriev...@chromium.org, wnwen...@chromium.org, pasko...@chromium.org, net-r...@chromium.org

Attention needed from Mohannad Farrag, Peter Wen and Ziwen Lin

Etienne Dechamps voted

Auto-Submit	+1
Commit-Queue	+1

Open in Gerrit

Related details

Attention is currently required from:

Mohannad Farrag
Peter Wen
Ziwen Lin

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Mohannad Farrag (Gerrit)

unread,

7:04 AM (12 hours ago) 7:04 AM

to Etienne Dechamps, Chromium LUCI CQ, Peter Wen, Andrew Grieve, Ziwen Lin, AyeAye, chromium...@chromium.org, Peter Beverloo, webauthn...@chromium.org, yfriedm...@chromium.org, lizeb...@chromium.org, torne...@chromium.org, browser-comp...@chromium.org, android-web...@chromium.org, derinel+wat...@google.com, nyquis...@chromium.org, asvitki...@chromium.org, webapks-...@chromium.org, agriev...@chromium.org, wnwen...@chromium.org, pasko...@chromium.org, net-r...@chromium.org

Attention needed from Etienne Dechamps, Peter Wen and Ziwen Lin

Mohannad Farrag voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Etienne Dechamps
Peter Wen
Ziwen Lin

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Etienne Dechamps (Gerrit)

unread,

9:09 AM (10 hours ago) 9:09 AM

to Etienne Dechamps, Mohannad Farrag, Chromium LUCI CQ, Peter Wen, Andrew Grieve, Ziwen Lin, AyeAye, chromium...@chromium.org, Peter Beverloo, webauthn...@chromium.org, yfriedm...@chromium.org, lizeb...@chromium.org, torne...@chromium.org, browser-comp...@chromium.org, android-web...@chromium.org, derinel+wat...@google.com, nyquis...@chromium.org, asvitki...@chromium.org, webapks-...@chromium.org, agriev...@chromium.org, wnwen...@chromium.org, pasko...@chromium.org, net-r...@chromium.org

Attention needed from Peter Wen and Ziwen Lin

Etienne Dechamps voted

Auto-Submit	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention is currently required from:

Peter Wen
Ziwen Lin

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Etienne Dechamps (Gerrit)

unread,

9:45 AM (10 hours ago) 9:45 AM

to Etienne Dechamps, Mohannad Farrag, Chromium LUCI CQ, Peter Wen, Andrew Grieve, Ziwen Lin, AyeAye, chromium...@chromium.org, Peter Beverloo, webauthn...@chromium.org, yfriedm...@chromium.org, lizeb...@chromium.org, torne...@chromium.org, browser-comp...@chromium.org, android-web...@chromium.org, derinel+wat...@google.com, nyquis...@chromium.org, asvitki...@chromium.org, webapks-...@chromium.org, agriev...@chromium.org, wnwen...@chromium.org, pasko...@chromium.org, net-r...@chromium.org

Attention needed from Peter Wen and Ziwen Lin

Etienne Dechamps voted

Auto-Submit	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention is currently required from:

Peter Wen
Ziwen Lin

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

10:05 AM (9 hours ago) 10:05 AM

to Etienne Dechamps, Mohannad Farrag, Peter Wen, Andrew Grieve, Ziwen Lin, AyeAye, chromium...@chromium.org, Peter Beverloo, webauthn...@chromium.org, yfriedm...@chromium.org, lizeb...@chromium.org, torne...@chromium.org, browser-comp...@chromium.org, android-web...@chromium.org, derinel+wat...@google.com, nyquis...@chromium.org, asvitki...@chromium.org, webapks-...@chromium.org, agriev...@chromium.org, wnwen...@chromium.org, pasko...@chromium.org, net-r...@chromium.org

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

2 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: components/cronet/android/BUILD.gn
Insertions: 7, Deletions: 0.

The diff is too large to show. Please review the diff.
```

Change information

Commit message:

Revert "[Build] Migrate Log usage." for Cronet

This reverts commit e82c6c9882580d49849afe7029671e25a0a353af.

Reason for revert: this change is not safe for Cronet. It is adding a dependency on a class (org.chromium.base.Log) that Cronet does not ship in the relevant packages. The change also ignored an explicit directive in Cronet's BUILD.gn urging authors to add dependencies to "deps_to_package". Downstream consumers will likely instantly blow up with a "class not found" error at runtime.

Original change's description:
> [Build] Migrate Log usage.
>
> Will enable NoAndroidLog errorprone check in a follow-up CL after migration is complete.
>
> Design Doc:
> https://docs.google.com/document/d/17pKwYfMG7OVyqgOQPplIH5U_dVtXOm8XA_aCbtZgWlQ/edit?usp=sharing
>
> Bug: 481747262
> Change-Id: I42f1e374590d3f98cd27807e0091192d87121fc2
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7555110
> Reviewed-by: Andrew Grieve <agr...@chromium.org>
> Commit-Queue: Ziwen Lin <ziw...@microsoft.com>
> Commit-Queue: Andrew Grieve <agr...@chromium.org>
> Owners-Override: Andrew Grieve <agr...@chromium.org>
> Reviewed-by: Peter Wen <wn...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1583521}

Bug: 481747262, b:494565814

Change-Id: Ie2b5255ae892ff0a0a7f3ec6e6e52d2a82ed9b1d

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7687871

Reviewed-by: Mohannad Farrag <aym...@google.com>

Commit-Queue: Etienne Dechamps <edec...@google.com>

Auto-Submit: Etienne Dechamps <edec...@google.com>

Cr-Commit-Position: refs/heads/main@{#1603438}

Files:

M components/cronet/android/BUILD.gn
M components/cronet/android/api/src/org/chromium/net/CronetEngine.java
M components/cronet/android/api/src/org/chromium/net/CronetProvider.java

M components/cronet/android/breakages.json

M components/cronet/android/fake/java/org/chromium/net/test/FakeUrlRequest.java
M components/cronet/android/java/src/org/chromium/net/httpflags/HttpFlagsLoader.java
M components/cronet/android/java/src/org/chromium/net/impl/AndroidHttpEngineBuilderWrapper.java
M components/cronet/android/java/src/org/chromium/net/impl/AndroidHttpEngineWrapper.java
M components/cronet/android/java/src/org/chromium/net/impl/AndroidRequestFinishedInfoWrapper.java
M components/cronet/android/java/src/org/chromium/net/impl/CronetLoggerFactory.java
M components/cronet/android/java/src/org/chromium/net/impl/JavaCronetEngine.java
M components/cronet/android/java/src/org/chromium/net/impl/JavaUrlRequest.java
M components/cronet/android/java/src/org/chromium/net/impl/UrlRequestBuilderImpl.java
M components/cronet/android/java/src/org/chromium/net/telemetry/CronetLoggerImpl.java
M components/cronet/android/java/src/org/chromium/net/telemetry/ExperimentalOptions.java
M components/cronet/android/java/src/org/chromium/net/telemetry/Hash.java
M components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java
M components/cronet/android/platform-only/org/chromium/net/ConnectivityManagerShim.java
M components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java
M components/cronet/android/test/smoketests/src/org/chromium/net/smoke/HttpTestServer.java

Change size: M

Delta: 20 files changed, 55 insertions(+), 28 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Mohannad Farrag

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

Revert "[Build] Migrate Log usage." for Cronet [chromium/src : main]

Etienne Dechamps (Gerrit)

Etienne Dechamps has uploaded the change for review

Commit message

Change diff

Change information

Related details

Rubber Stamper (Gerrit)

Message from Rubber Stamper

Related details

Andrew Grieve (Gerrit)

Andrew Grieve added 1 comment

Related details

Etienne Dechamps (Gerrit)

Etienne Dechamps voted

Related details

Mohannad Farrag (Gerrit)

Mohannad Farrag voted Code-Review+1

Related details

Etienne Dechamps (Gerrit)

Etienne Dechamps voted

Related details

Etienne Dechamps (Gerrit)

Etienne Dechamps voted

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

Change information