[DW] Fix tab strip fade show up in non-desktop windows [chromium/src : main]

0 views

Skip to first unread message

Zhe Li (Gerrit)

unread,

Jul 24, 2026, 2:40:38 PM (yesterday) Jul 24

to Aishwarya Rajesh, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, peilinwa...@google.com

Attention needed from Aishwarya Rajesh

Zhe Li added 1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Zhe Li . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:

Aishwarya Rajesh

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Aishwarya Rajesh (Gerrit)

unread,

11:42 AM (4 hours ago) 11:42 AM

to Zhe Li, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, peilinwa...@google.com

Attention needed from Zhe Li

Aishwarya Rajesh added 1 comment

File chrome/browser/ui/android/toolbar/java/src/org/chromium/chrome/browser/toolbar/top/tab_strip/FadeTransitionHandler.java

Line 45, Patchset 2 (Latest): if (isInDesktopWindow) {

Aishwarya Rajesh . unresolved

It's not clear to me how this check helps fix this issue; we do need to run the fade transition to force fade in the strip when we're transitioning to non-DW mode in exceptional scenarios (example with a hidden (faded out) strip in a narrow DW, focus on the omnibox and switch to non-DW mode). I wonder if we need to find a better way to determine the input `forceFadeInStrip` below instead of always setting it to false vs adding the DW mode check here - can you explain what the root cause of the issue is and how this update helps fix the issue?