extensions: Handle navigation to options page from details page [chromium/src : main]
0 views
Skip to first unread message
Masa Fujita (Gerrit)
May 13, 2025, 12:22:44 AMMay 13
to chromium...@chromium.org, alexmo...@chromium.org, browser-comp...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, extension...@chromium.org, navigation...@chromium.org
Masa Fujita voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Keigo Oka (Gerrit)
May 13, 2025, 12:57:08 AMMay 13
to Masa Fujita, Chromium LUCI CQ, chromium...@chromium.org, alexmo...@chromium.org, browser-comp...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, extension...@chromium.org, navigation...@chromium.org
Attention needed from Masa Fujita
Keigo Oka added 3 comments![]( "Open in Gerrit")
Patchset-level comments
File chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelImpl.java
Line 985, Patchset 4 (Latest):
public Tab createNewTabForDevTools(GURL url, boolean newWindow) {Keigo Oka . unresolved
This method is for devtools, so I think we shouldn't change it. Isn't using openNewTab not enough? (see the comment below)
File chrome/browser/ui/android/tab_model/tab_model_jni_bridge.cc
Line 118, Patchset 4 (Latest):
if (disposition == WindowOpenDisposition::NEW_POPUP ||Keigo Oka . unresolved
It seems [1] openNewTab can take NEW_POPUP and NEW_WINDOW as disposition. Why do we need this if statement?
Related details
Attention is currently required from:
- Masa Fujita
Submit Requirements:
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Masa Fujita (Gerrit)
May 13, 2025, 1:55:21 AMMay 13
to Keigo Oka, Chromium LUCI CQ, chromium...@chromium.org, alexmo...@chromium.org, browser-comp...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, extension...@chromium.org, navigation...@chromium.org
Attention needed from Keigo Oka
Masa Fujita added 1 comment![]( "Open in Gerrit")
File chrome/browser/ui/android/tab_model/tab_model_jni_bridge.cc
Line 118, Patchset 4 (Latest):
if (disposition == WindowOpenDisposition::NEW_POPUP ||Keigo Oka . unresolved
It seems [1] openNewTab can take NEW_POPUP and NEW_WINDOW as disposition. Why do we need this if statement?
Masa Fujita
unfortunately when openNewTab takes NEW_POPUP and NEW_WINDOW the new tab just opens in the current window. It seems that the implementation inside openNewTab ([2]?) doesn't consider multiinstance
Related details
Attention is currently required from:
- Keigo Oka
Submit Requirements:
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Masa Fujita (Gerrit)
Jun 22, 2025, 9:03:36 PMJun 22
to Keigo Oka, Chromium LUCI CQ, chromium...@chromium.org, alexmo...@chromium.org, browser-comp...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, extension...@chromium.org, navigation...@chromium.org
Masa Fujita abandoned this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages