Min Qin (Gerrit)

unread,

Dec 2, 2025, 6:11:29 PM (3 days ago) Dec 2

to Chromium IPC Reviews, Josiah Kiehl, Chromium LUCI CQ, chromium...@chromium.org, Sophie Chang, christia...@chromium.org, ipc-securi...@chromium.org, jdonnel...@chromium.org, lens-chrome...@google.com, mercer...@google.com, niharm...@google.com, omnibox-...@chromium.org, oshima...@chromium.org, stanfie...@google.com

Attention needed from Chromium IPC Reviews, Josiah Kiehl and Moe Ahmadi

Min Qin added 1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Min Qin . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:

Chromium IPC Reviews
Josiah Kiehl
Moe Ahmadi

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

gwsq (Gerrit)

unread,

Dec 2, 2025, 6:14:13 PM (3 days ago) Dec 2

to Min Qin, Chromium IPC Reviews, Daniel Cheng, Josiah Kiehl, Chromium LUCI CQ, chromium...@chromium.org, Sophie Chang, christia...@chromium.org, ipc-securi...@chromium.org, jdonnel...@chromium.org, lens-chrome...@google.com, mercer...@google.com, niharm...@google.com, omnibox-...@chromium.org, oshima...@chromium.org, stanfie...@google.com

Attention needed from Daniel Cheng, Josiah Kiehl and Moe Ahmadi

Message from gwsq

From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: dch...@chromium.org

📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).

IPC reviewer(s): dch...@chromium.org

Reviewer source(s):
dch...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)

Open in Gerrit

Related details

Attention is currently required from:

Daniel Cheng
Josiah Kiehl
Moe Ahmadi

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Josiah Kiehl (Gerrit)

unread,

Dec 2, 2025, 6:47:50 PM (3 days ago) Dec 2

to Min Qin, Chromium IPC Reviews, Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, Sophie Chang, christia...@chromium.org, ipc-securi...@chromium.org, jdonnel...@chromium.org, lens-chrome...@google.com, mercer...@google.com, niharm...@google.com, omnibox-...@chromium.org, oshima...@chromium.org, stanfie...@google.com

Attention needed from Daniel Cheng, Min Qin and Moe Ahmadi

Josiah Kiehl voted and added 4 comments

Votes added by Josiah Kiehl

Code-Review

+1

4 comments

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Josiah Kiehl . resolved

Bit of bikeshedding on naming, but otherwise LGTM

File chrome/browser/contextual_tasks/contextual_tasks_ui.h

Line 153, Patchset 2 (Latest): void DisableTabContextSuggestion();

Josiah Kiehl . unresolved

"TabContext" might be a bit too generic, as we'll have other types of tab context soon (ie: not the current tab). Perhaps this should be:

```suggestion
  void DisableActiveTabContextSuggestion();
```

File chrome/browser/ui/lens/lens_composebox_handler.cc

Line 191, Patchset 2 (Latest): bool from_suggested_chip) {

Josiah Kiehl . unresolved

This is more than a suggestion, as it's automatically added.

Perhaps:
```suggestion
    bool from_automatic_chip) {
```

File ui/webui/resources/cr_components/composebox/contextual_entrypoint_and_carousel.ts

Line 202, Patchset 2 (Latest): private suggestedTabToken_: UnguessableToken|null = null;

Josiah Kiehl . unresolved

If we change the parameters to "automatic", we'll want to change this, too. Can also be done as a followup CL if you agree it's a good idea.


```suggestion
  private automaticActiveTabChipToken_: UnguessableToken|null = null;
```

Open in Gerrit

Related details

Attention is currently required from:

Daniel Cheng
Min Qin
Moe Ahmadi

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Min Qin (Gerrit)

unread,

Dec 3, 2025, 1:07:32 PM (3 days ago) Dec 3

to Josiah Kiehl, Chromium IPC Reviews, Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, Sophie Chang, christia...@chromium.org, ipc-securi...@chromium.org, jdonnel...@chromium.org, lens-chrome...@google.com, mercer...@google.com, niharm...@google.com, omnibox-...@chromium.org, oshima...@chromium.org, stanfie...@google.com

Attention needed from Daniel Cheng, Josiah Kiehl and Moe Ahmadi

Min Qin added 4 comments

Patchset-level comments

File-level comment, Patchset 2:

Min Qin . resolved

Done. Renamed some of the methods and variables to match the reviewer comments

File chrome/browser/contextual_tasks/contextual_tasks_ui.h

Line 153, Patchset 2: void DisableTabContextSuggestion();

Josiah Kiehl . resolved

"TabContext" might be a bit too generic, as we'll have other types of tab context soon (ie: not the current tab). Perhaps this should be:
```suggestion
  void DisableActiveTabContextSuggestion();
```

Min Qin

Done

File chrome/browser/ui/lens/lens_composebox_handler.cc

Line 191, Patchset 2: bool from_suggested_chip) {

Josiah Kiehl . resolved

This is more than a suggestion, as it's automatically added.
Perhaps:
```suggestion
    bool from_automatic_chip) {
```

Min Qin

Done

File ui/webui/resources/cr_components/composebox/contextual_entrypoint_and_carousel.ts

Line 202, Patchset 2: private suggestedTabToken_: UnguessableToken|null = null;

Josiah Kiehl . resolved

If we change the parameters to "automatic", we'll want to change this, too. Can also be done as a followup CL if you agree it's a good idea.
```suggestion
  private automaticActiveTabChipToken_: UnguessableToken|null = null;
```

Min Qin

Done

Open in Gerrit

Related details

Attention is currently required from:

Daniel Cheng
Josiah Kiehl
Moe Ahmadi

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Daniel Cheng (Gerrit)

unread,

Dec 3, 2025, 1:16:38 PM (3 days ago) Dec 3

to Min Qin, Daniel Cheng, Josiah Kiehl, Chromium IPC Reviews, Chromium LUCI CQ, chromium...@chromium.org, Sophie Chang, christia...@chromium.org, ipc-securi...@chromium.org, jdonnel...@chromium.org, lens-chrome...@google.com, mercer...@google.com, niharm...@google.com, omnibox-...@chromium.org, oshima...@chromium.org, stanfie...@google.com

Attention needed from Josiah Kiehl, Min Qin and Moe Ahmadi

Daniel Cheng voted and added 1 comment

Votes added by Daniel Cheng

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Daniel Cheng . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:

Josiah Kiehl
Min Qin
Moe Ahmadi

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Josiah Kiehl (Gerrit)

unread,

Dec 3, 2025, 4:25:04 PM (2 days ago) Dec 3

to Min Qin, Daniel Cheng, Chromium IPC Reviews, Chromium LUCI CQ, chromium...@chromium.org, Sophie Chang, christia...@chromium.org, ipc-securi...@chromium.org, jdonnel...@chromium.org, lens-chrome...@google.com, mercer...@google.com, niharm...@google.com, omnibox-...@chromium.org, oshima...@chromium.org, stanfie...@google.com

Attention needed from Min Qin and Moe Ahmadi

Josiah Kiehl voted and added 1 comment

Votes added by Josiah Kiehl

Code-Review

+1

1 comment

File chrome/browser/ui/webui/searchbox/contextual_searchbox_handler_unittest.cc

Line 621, Patchset 3 (Latest): handler().DeleteContext(file_token, /*from_suggested_chip=*/false);

Josiah Kiehl . unresolved

This comment needs to be updated to the new name.


```suggestion
  handler().DeleteContext(file_token, /*from_automatic_chip=*/false);
```

Open in Gerrit

Related details

Attention is currently required from:

Min Qin
Moe Ahmadi

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Moe Ahmadi (Gerrit)

unread,

Dec 3, 2025, 9:39:48 PM (2 days ago) Dec 3

to Min Qin, Josiah Kiehl, Daniel Cheng, Chromium IPC Reviews, Chromium LUCI CQ, chromium...@chromium.org, Sophie Chang, christia...@chromium.org, ipc-securi...@chromium.org, jdonnel...@chromium.org, lens-chrome...@google.com, mercer...@google.com, niharm...@google.com, omnibox-...@chromium.org, oshima...@chromium.org, stanfie...@google.com

Attention needed from Min Qin

Moe Ahmadi voted and added 2 comments

Votes added by Moe Ahmadi

Code-Review

+1

2 comments

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Moe Ahmadi . resolved

LGTM, thanks Min!

File chrome/browser/ui/webui/searchbox/composebox_handler_unittest.cc

Line 308, Patchset 3 (Latest): handler().DeleteContext(delete_file_token, /*from_suggested_chip=*/false);

Moe Ahmadi . unresolved

Please fix this WARNING reported by ClangTidy: check: bugprone-argument-comment

argument name 'from_suggested_chip' in comment...

check: bugprone-argument-comment

argument name 'from_suggested_chip' in comment does not match parameter name 'from_automatic_chip' (https://clang.llvm.org/extra/clang-tidy/checks/bugprone/argument-comment.html)

(Note: You can add `Skip-Clang-Tidy-Checks: bugprone-argument-comment` footer to the CL description to skip the check)

(Lint observed on `linux-clang-tidy-rel`, but not on `android-clang-tidy-rel`)

Open in Gerrit

Related details

Attention is currently required from:

Min Qin

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Min Qin (Gerrit)

unread,

Dec 4, 2025, 1:25:05 PM (2 days ago) Dec 4

to Josiah Kiehl, Daniel Cheng, Chromium IPC Reviews, Chromium LUCI CQ, chromium...@chromium.org, Sophie Chang, christia...@chromium.org, ipc-securi...@chromium.org, jdonnel...@chromium.org, lens-chrome...@google.com, mercer...@google.com, niharm...@google.com, omnibox-...@chromium.org, oshima...@chromium.org, stanfie...@google.com

Min Qin added 2 comments

File chrome/browser/ui/webui/searchbox/composebox_handler_unittest.cc

Line 308, Patchset 3: handler().DeleteContext(delete_file_token, /*from_suggested_chip=*/false);

Moe Ahmadi . resolved

Please fix this WARNING reported by ClangTidy: check: bugprone-argument-comment
argument name 'from_suggested_chip' in comment...
check: bugprone-argument-comment
argument name 'from_suggested_chip' in comment does not match parameter name 'from_automatic_chip' (https://clang.llvm.org/extra/clang-tidy/checks/bugprone/argument-comment.html)
(Note: You can add `Skip-Clang-Tidy-Checks: bugprone-argument-comment` footer to the CL description to skip the check)
(Lint observed on `linux-clang-tidy-rel`, but not on `android-clang-tidy-rel`)

Min Qin

Done

File chrome/browser/ui/webui/searchbox/contextual_searchbox_handler_unittest.cc

Line 621, Patchset 3: handler().DeleteContext(file_token, /*from_suggested_chip=*/false);

Josiah Kiehl . resolved

This comment needs to be updated to the new name.
```suggestion
  handler().DeleteContext(file_token, /*from_automatic_chip=*/false);
```

Min Qin

Done

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Min Qin (Gerrit)

unread,

Dec 4, 2025, 1:25:09 PM (2 days ago) Dec 4

to Josiah Kiehl, Daniel Cheng, Chromium IPC Reviews, Chromium LUCI CQ, chromium...@chromium.org, Sophie Chang, christia...@chromium.org, ipc-securi...@chromium.org, jdonnel...@chromium.org, lens-chrome...@google.com, mercer...@google.com, niharm...@google.com, omnibox-...@chromium.org, oshima...@chromium.org, stanfie...@google.com

Min Qin voted Commit-Queue+2

Commit-Queue

+2

satisfied_requirement

open

diffy

Josiah Kiehl (Gerrit)

unread,

Dec 4, 2025, 1:55:24 PM (2 days ago) Dec 4

to Min Qin, AyeAye, Daniel Cheng, Chromium IPC Reviews, Chromium LUCI CQ, chromium...@chromium.org, Sophie Chang, ananyasee...@google.com, christia...@chromium.org, ipc-securi...@chromium.org, jdonnel...@chromium.org, lens-chrome...@google.com, mercer...@google.com, niharm...@google.com, omnibox-...@chromium.org, oshima...@chromium.org, stanfie...@google.com

Attention needed from Daniel Cheng, Min Qin and Moe Ahmadi

Josiah Kiehl voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Daniel Cheng
Min Qin
Moe Ahmadi

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Daniel Cheng (Gerrit)

unread,

Dec 4, 2025, 2:25:36 PM (2 days ago) Dec 4

to Min Qin, Josiah Kiehl, AyeAye, Daniel Cheng, Chromium IPC Reviews, Chromium LUCI CQ, chromium...@chromium.org, Sophie Chang, ananyasee...@google.com, christia...@chromium.org, ipc-securi...@chromium.org, jdonnel...@chromium.org, lens-chrome...@google.com, mercer...@google.com, niharm...@google.com, omnibox-...@chromium.org, oshima...@chromium.org, stanfie...@google.com

Attention needed from Min Qin and Moe Ahmadi

Daniel Cheng added 1 comment

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Daniel Cheng . resolved

Looks like the build is broken; I'll review once that's fixed.

Open in Gerrit

Related details

Attention is currently required from:

Min Qin
Moe Ahmadi

satisfied_requirement

unsatisfied_requirement

open

diffy

Min Qin (Gerrit)

unread,

Dec 4, 2025, 3:49:02 PM (2 days ago) Dec 4

to Josiah Kiehl, AyeAye, Daniel Cheng, Chromium IPC Reviews, Chromium LUCI CQ, chromium...@chromium.org, Sophie Chang, ananyasee...@google.com, christia...@chromium.org, ipc-securi...@chromium.org, jdonnel...@chromium.org, lens-chrome...@google.com, mercer...@google.com, niharm...@google.com, omnibox-...@chromium.org, oshima...@chromium.org, stanfie...@google.com

Attention needed from Daniel Cheng and Moe Ahmadi

Min Qin voted and added 1 comment

Votes added by Min Qin

Commit-Queue

+1

1 comment

Patchset-level comments

File-level comment, Patchset 5:

Daniel Cheng . resolved

Looks like the build is broken; I'll review once that's fixed.

Min Qin

There is a new test added by others, and it didn't have the extra parameter added in this CL. So rebased and fixed the test.
Interestingly, if rebase involves a file that is moved during code review, it will invalidate the previous lgtm.

Open in Gerrit

Related details

Attention is currently required from:

Daniel Cheng
Moe Ahmadi

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Moe Ahmadi (Gerrit)

unread,

Dec 5, 2025, 2:19:17 PM (13 hours ago) Dec 5

to Min Qin, Josiah Kiehl, AyeAye, Daniel Cheng, Chromium IPC Reviews, Chromium LUCI CQ, chromium...@chromium.org, Sophie Chang, ananyasee...@google.com, christia...@chromium.org, ipc-securi...@chromium.org, jdonnel...@chromium.org, lens-chrome...@google.com, mercer...@google.com, niharm...@google.com, omnibox-...@chromium.org, oshima...@chromium.org, stanfie...@google.com

Attention needed from Daniel Cheng and Min Qin

Moe Ahmadi voted and added 1 comment

Votes added by Moe Ahmadi

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 6 (Latest):

Moe Ahmadi . resolved

still LGTM

Open in Gerrit

Related details

Attention is currently required from:

Daniel Cheng
Min Qin

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Min Qin (Gerrit)

unread,

Dec 5, 2025, 3:03:14 PM (13 hours ago) Dec 5

to Josiah Kiehl, AyeAye, Daniel Cheng, Chromium IPC Reviews, Chromium LUCI CQ, chromium...@chromium.org, Sophie Chang, ananyasee...@google.com, christia...@chromium.org, ipc-securi...@chromium.org, jdonnel...@chromium.org, lens-chrome...@google.com, mercer...@google.com, niharm...@google.com, omnibox-...@chromium.org, oshima...@chromium.org, stanfie...@google.com

Attention needed from Daniel Cheng

Min Qin voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention is currently required from:

Daniel Cheng

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Daniel Cheng (Gerrit)

unread,

Dec 5, 2025, 4:32:30 PM (11 hours ago) Dec 5

to Min Qin, Daniel Cheng, Josiah Kiehl, AyeAye, Chromium IPC Reviews, Chromium LUCI CQ, chromium...@chromium.org, Sophie Chang, ananyasee...@google.com, christia...@chromium.org, ipc-securi...@chromium.org, jdonnel...@chromium.org, lens-chrome...@google.com, mercer...@google.com, niharm...@google.com, omnibox-...@chromium.org, oshima...@chromium.org, stanfie...@google.com

Attention needed from Min Qin

Daniel Cheng voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Min Qin

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Min Qin (Gerrit)

unread,

Dec 5, 2025, 9:00:32 PM (7 hours ago) Dec 5

to Daniel Cheng, Josiah Kiehl, AyeAye, Chromium IPC Reviews, Chromium LUCI CQ, chromium...@chromium.org, Sophie Chang, ananyasee...@google.com, christia...@chromium.org, ipc-securi...@chromium.org, jdonnel...@chromium.org, lens-chrome...@google.com, mercer...@google.com, niharm...@google.com, omnibox-...@chromium.org, oshima...@chromium.org, stanfie...@google.com

Min Qin voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Dec 5, 2025, 9:04:01 PM (7 hours ago) Dec 5

to Min Qin, Daniel Cheng, Josiah Kiehl, AyeAye, Chromium IPC Reviews, chromium...@chromium.org, Sophie Chang, ananyasee...@google.com, christia...@chromium.org, ipc-securi...@chromium.org, jdonnel...@chromium.org, lens-chrome...@google.com, mercer...@google.com, niharm...@google.com, omnibox-...@chromium.org, oshima...@chromium.org, stanfie...@google.com

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

6 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: chrome/browser/contextual_tasks/contextual_tasks_ui_service_interactive_uitest.cc
Insertions: 30, Deletions: 0.

The diff is too large to show. Please review the diff.
```

Change information

Commit message:

[ContextualTask] Don't show tab suggestion again if user removes it

Bug: 465511936

Change-Id: Ia75f2ac67b0da61afc828509991e73e0dc338eec

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7218896

Reviewed-by: Daniel Cheng <dch...@chromium.org>

Reviewed-by: Josiah Kiehl <ki...@google.com>

Commit-Queue: Min Qin <qin...@chromium.org>

Reviewed-by: Moe Ahmadi <mah...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1555032}

Files:

M chrome/browser/contextual_tasks/contextual_tasks_composebox_handler.cc
M chrome/browser/contextual_tasks/contextual_tasks_composebox_handler.h
M chrome/browser/contextual_tasks/contextual_tasks_ui.cc
M chrome/browser/contextual_tasks/contextual_tasks_ui.h
M chrome/browser/contextual_tasks/contextual_tasks_ui_service.h
M chrome/browser/contextual_tasks/contextual_tasks_ui_service_interactive_uitest.cc
M chrome/browser/ui/lens/lens_composebox_handler.cc
M chrome/browser/ui/lens/lens_composebox_handler.h
M chrome/browser/ui/webui/cr_components/composebox/composebox_handler.cc
M chrome/browser/ui/webui/cr_components/composebox/composebox_handler_unittest.cc
M chrome/browser/ui/webui/cr_components/searchbox/contextual_searchbox_handler.cc
M chrome/browser/ui/webui/cr_components/searchbox/contextual_searchbox_handler.h
M chrome/browser/ui/webui/cr_components/searchbox/searchbox_handler.h
M chrome/browser/ui/webui/searchbox/contextual_searchbox_handler_unittest.cc
M chrome/browser/ui/webui/searchbox/realbox_handler_browsertest.cc
M chrome/browser/ui/webui/searchbox/searchbox_test_utils.h
M chrome/test/data/webui/new_tab_page/composebox/composebox_test.ts
M components/omnibox/browser/searchbox.mojom
M ui/webui/resources/cr_components/composebox/composebox.ts
M ui/webui/resources/cr_components/composebox/contextual_entrypoint_and_carousel.ts
M ui/webui/resources/cr_components/composebox/file_thumbnail.ts

Change size: M

Delta: 21 files changed, 128 insertions(+), 38 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Moe Ahmadi, +1 by Daniel Cheng, +1 by Josiah Kiehl

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

[ContextualTask] Don't show tab suggestion again if user removes it [chromium/src : main]

Min Qin (Gerrit)

Min Qin added 1 comment

Related details

gwsq (Gerrit)

Message from gwsq

Related details

Josiah Kiehl (Gerrit)

Josiah Kiehl voted and added 4 comments

Votes added by Josiah Kiehl

4 comments

Related details

Min Qin (Gerrit)

Min Qin added 4 comments

Related details

Daniel Cheng (Gerrit)

Daniel Cheng voted and added 1 comment

Votes added by Daniel Cheng

1 comment

Related details

Josiah Kiehl (Gerrit)

Josiah Kiehl voted and added 1 comment

Votes added by Josiah Kiehl

1 comment

Related details

Moe Ahmadi (Gerrit)

Moe Ahmadi voted and added 2 comments

Votes added by Moe Ahmadi

2 comments

Related details

Min Qin (Gerrit)

Min Qin added 2 comments

Related details

Min Qin (Gerrit)

Min Qin voted Commit-Queue+2

Josiah Kiehl (Gerrit)

Josiah Kiehl voted Code-Review+1

Related details

Daniel Cheng (Gerrit)

Daniel Cheng added 1 comment

Related details

Min Qin (Gerrit)

Min Qin voted and added 1 comment

Votes added by Min Qin

1 comment

Related details

Moe Ahmadi (Gerrit)

Moe Ahmadi voted and added 1 comment

Votes added by Moe Ahmadi

1 comment

Related details

Min Qin (Gerrit)

Min Qin voted Commit-Queue+2

Related details

Daniel Cheng (Gerrit)

Daniel Cheng voted Code-Review+1

Related details

Min Qin (Gerrit)

Min Qin voted Commit-Queue+2

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

Change information