[BAM] Migrate bookmark submenu metrics logging to AppMenuModel::LogSubmenuAction [chromium/src : main]

0 views

Skip to first unread message

Darryl James (Gerrit)

unread,

6:41 PM (4 hours ago) 6:41 PM

to Chromium LUCI CQ, Kunal Daftari, chromium...@chromium.org

Attention needed from Darryl James and Kunal Daftari

Message from Darryl James

Set Ready For Review

Open in Gerrit

Related details

Attention is currently required from:

Darryl James
Kunal Daftari

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Kunal Daftari (Gerrit)

unread,

6:44 PM (4 hours ago) 6:44 PM

to Darryl James, Chromium LUCI CQ, chromium...@chromium.org

Attention needed from Darryl James

Kunal Daftari added 3 comments

Commit Message

Line 22, Patchset 2 (Latest):

CONV=9cdfa583-d9a2-4f72-b35d-d56b1d04fb67


[BAM] Refactor Recent Tabs submenu metrics logging and remove kActionOpenRecentTab

Kunal Daftari . unresolved

I think you have two commit messages here.

File chrome/browser/ui/toolbar/app_menu_model.h

Line 297, Patchset 2 (Latest): void LogSubmenuAction(AppMenuAction action_id);

Kunal Daftari . unresolved

Probably have to change location in .cc file to match declaration order.

File chrome/browser/ui/views/toolbar/app_menu.h

Line 51, Patchset 2 (Latest): void RegisterLogSubmenuActionCallback(LogSubmenuActionCallback callback);

Kunal Daftari . unresolved

Should this go after the destructor, maybe? Or later in the file.

Open in Gerrit

Related details

Attention is currently required from:

Darryl James

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages