[rust] Cover `rustc_nightly_capability` via `buildflag_header`. [chromium/src : main]
Łukasz Anforowicz (Gerrit)
Łukasz Anforowicz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Łukasz Anforowicz
| Auto-Submit | +1 |
1 comment
@dcheng, can you PTAL? /cc @mfarazma - this is a follow-up to the comment left at https://chromium-review.googlesource.com/c/chromium/src/+/7050763/8#message-97d1f8c87b95752277b9179b102a9a08f4dc5401
Related details
- Daniel Cheng
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel Cheng (Gerrit)
Daniel Cheng voted![]( "Open in Gerrit")
- Łukasz Anforowicz
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Milad Farazmand (Gerrit)
Milad Farazmand added 1 comment![]( "Open in Gerrit")
@dcheng, can you PTAL? /cc @mfarazma - this is a follow-up to the comment left at https://chromium-review.googlesource.com/c/chromium/src/+/7050763/8#message-97d1f8c87b95752277b9179b102a9a08f4dc5401
Thank you for your help.
Related details
- Łukasz Anforowicz
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
[rust] Cover `rustc_nightly_capability` via `buildflag_header`.
https://crrev.com/c/7050763 accidentally removed `rustflags += [
"--cfg=rust_allocator_no_nightly_capability" ]` without replacing it
with a `buildflag_header` equivalent. This CL fixes this.
- M build/rust/allocator/BUILD.gn
- M build/rust/allocator/lib.rs
Code-Review: +1 by Daniel Cheng
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
luci-bisection@appspot.gserviceaccount.com (Gerrit)
Message from luci-bi...@appspot.gserviceaccount.com![]( "Open in Gerrit")
LUCI Bisection has identified this change as the culprit of a build failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/compile-analysis/b/8692747594532272513
A revert for this change was not created because the builder that this CL broke is not watched by gardeners, therefore less important. You can consider revert this CL, fix forward or let builder owners resolve it themselves.
Sample failed build: https://ci.chromium.org/b/8692747594532272513
If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F7465178&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Fcompile-analysis%2Fb%2F8692747594532272513&type=BUG
Related details
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
luci-bisection@appspot.gserviceaccount.com (Gerrit)
luci-bi...@appspot.gserviceaccount.com has created a revert of this change![]( "Open in Gerrit")
Related details
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Milad Farazmand (Gerrit)
Milad Farazmand added 1 comment![]( "Open in Gerrit")
Hi Łukasz,
This CL was reverted but even applying it on a ppc64 machine still failed our builds. I thought maybe your condition was wrong and had to be negated with:
```
"RUST_ALLOCATOR_NO_NIGHTLY_CAPABILITY=!$rustc_nightly_capability",
```
But even this still failed our build. Is it possible to re add what was previously working for now since it takes time for it to propagate back to V8:
https://chromium-review.googlesource.com/c/chromium/src/+/7467869
Related details
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Milad Farazmand (Gerrit)
Milad Farazmand added 1 comment![]( "Open in Gerrit")
Hi Łukasz,
This CL was reverted but even applying it on a ppc64 machine still failed our builds. I thought maybe your condition was wrong and had to be negated with:
```
"RUST_ALLOCATOR_NO_NIGHTLY_CAPABILITY=!$rustc_nightly_capability",
```
But even this still failed our build. Is it possible to re add what was previously working for now since it takes time for it to propagate back to V8:
https://chromium-review.googlesource.com/c/chromium/src/+/7467869
Actually I think I found what the issue was, you reject all the non-true flags with `if (_value == "true" || _value == "1") {` under `build/buildflag_header.gni` so I just changed the condition during `cfg` instead in the above CL, please take another look.
Related details
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |