Introduce const version of GetCachedFormAndField [chromium/src : main]

0 views
Skip to first unread message

Jan Keitel (Gerrit)

unread,
5:29 AM (2 hours ago) 5:29 AM
to Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org
Attention needed from Christoph Schwering

Jan Keitel voted Commit-Queue+0

Commit-Queue+0
Open in Gerrit

Related details

Attention is currently required from:
  • Christoph Schwering
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7666d637c16c52a8011b8a74b5d68f0cb8d0c06c
Gerrit-Change-Number: 8071101
Gerrit-PatchSet: 1
Gerrit-Owner: Jan Keitel <jke...@google.com>
Gerrit-Reviewer: Christoph Schwering <schw...@google.com>
Gerrit-Reviewer: Jan Keitel <jke...@google.com>
Gerrit-Attention: Christoph Schwering <schw...@google.com>
Gerrit-Comment-Date: Fri, 10 Jul 2026 09:29:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Christoph Schwering (Gerrit)

unread,
6:45 AM (1 hour ago) 6:45 AM
to Jan Keitel, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org
Attention needed from Jan Keitel

Christoph Schwering voted and added 1 comment

Votes added by Christoph Schwering

Code-Review+1

1 comment

File components/autofill/core/browser/foundations/autofill_manager.h
Line 408, Patchset 3 (Latest): // returned `FormAndField` may not contain form or field, if the form is not
Christoph Schwering . unresolved

"a form"?

Open in Gerrit

Related details

Attention is currently required from:
  • Jan Keitel
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I7666d637c16c52a8011b8a74b5d68f0cb8d0c06c
    Gerrit-Change-Number: 8071101
    Gerrit-PatchSet: 3
    Gerrit-Owner: Jan Keitel <jke...@google.com>
    Gerrit-Reviewer: Christoph Schwering <schw...@google.com>
    Gerrit-Reviewer: Jan Keitel <jke...@google.com>
    Gerrit-Attention: Jan Keitel <jke...@google.com>
    Gerrit-Comment-Date: Fri, 10 Jul 2026 10:44:58 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages