[Desktop Android] Support 16dp favicons in FaviconDriverImpl [chromium/src : main]
Shakti Sahu (Gerrit)
Shakti Sahu added 1 comment![]( "Open in Gerrit")
Peter KotwiczMy understanding is that that:
- The side panel wants a desktop-sized favicon
- The website dynamically changes which favicons it offers based on the OS. Specifically, the website - classpop.com - does not offer desktop-sized favicons for Android because large screen Android devices are new (and desktop form factor Android devices are super new)
The best fix in my opinion (and the easiest one) seems to be for Android to change the user agent string to pretend to be a desktop Chrome browser (as opposed to an Android Chrome browser)
Downsampling large icons is discouraged because doing so looks visually bad.
Peter KotwiczIf changing the user agent string is not possible (I suspect it is not possible because the website should know whether to display Google Play app install URLs)
changing the FaviconDriverImpl to instantiate FaviconDriverObserver::NON_TOUCH_16_DIP) on large screen Android devices seems reasonable.
Shakti SahuMore specifically, I suspect you likely need a new FaviconDriverObserver enum value to better reflect the icon specs desired on desktop Android.
The user agent on these devices is desktop user agent. Hence changed FaviconDriverImpl to register NON_TOUCH_16_DIP handler. PTAL
Related details
- Calder Kitagawa
- Nihar Majmudar
- Peter Kotwicz
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |