Finalize section type titles. [chromium/src : main]

0 views
Skip to first unread message

Darren Shen (Gerrit)

unread,
3:58 AM (20 hours ago) 3:58 AM
to Michelle Chen, chromium...@chromium.org
Attention needed from Michelle Chen

Darren Shen voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Michelle Chen
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib9e8785bd018644033aa64a754250a4902d39750
Gerrit-Change-Number: 5672159
Gerrit-PatchSet: 2
Gerrit-Owner: Darren Shen <sh...@chromium.org>
Gerrit-Reviewer: Darren Shen <sh...@chromium.org>
Gerrit-Reviewer: Michelle Chen <miche...@google.com>
Gerrit-Attention: Michelle Chen <miche...@google.com>
Gerrit-Comment-Date: Tue, 02 Jul 2024 07:58:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Michelle Chen (Gerrit)

unread,
4:00 AM (20 hours ago) 4:00 AM
to Darren Shen, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Darren Shen

Michelle Chen voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Darren Shen
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib9e8785bd018644033aa64a754250a4902d39750
Gerrit-Change-Number: 5672159
Gerrit-PatchSet: 2
Gerrit-Owner: Darren Shen <sh...@chromium.org>
Gerrit-Reviewer: Darren Shen <sh...@chromium.org>
Gerrit-Reviewer: Michelle Chen <miche...@google.com>
Gerrit-Attention: Darren Shen <sh...@chromium.org>
Gerrit-Comment-Date: Tue, 02 Jul 2024 07:59:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Michelle Chen (Gerrit)

unread,
8:10 PM (4 hours ago) 8:10 PM
to Darren Shen, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Darren Shen

Michelle Chen voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Darren Shen
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib9e8785bd018644033aa64a754250a4902d39750
Gerrit-Change-Number: 5672159
Gerrit-PatchSet: 3
Gerrit-Owner: Darren Shen <sh...@chromium.org>
Gerrit-Reviewer: Darren Shen <sh...@chromium.org>
Gerrit-Reviewer: Michelle Chen <miche...@google.com>
Gerrit-Attention: Darren Shen <sh...@chromium.org>
Gerrit-Comment-Date: Wed, 03 Jul 2024 00:09:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
9:12 PM (3 hours ago) 9:12 PM
to Darren Shen, Michelle Chen, chromium...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Finalize section type titles.

Certain sections do not have a title.
Bug: b:345303965
Change-Id: Ib9e8785bd018644033aa64a754250a4902d39750
Reviewed-by: Michelle Chen <miche...@google.com>
Commit-Queue: Darren Shen <sh...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1322510}
Files:
  • M ash/picker/views/picker_search_results_view_unittest.cc
  • M ash/picker/views/picker_strings.cc
  • M ash/picker/views/picker_view_unittest.cc
Change size: M
Delta: 3 files changed, 38 insertions(+), 47 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Michelle Chen
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib9e8785bd018644033aa64a754250a4902d39750
Gerrit-Change-Number: 5672159
Gerrit-PatchSet: 4
Gerrit-Owner: Darren Shen <sh...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Darren Shen <sh...@chromium.org>
Gerrit-Reviewer: Michelle Chen <miche...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages