[renderer] Fix input mode using PerformanceScenario [chromium/src : main]

0 views
Skip to first unread message

Etienne Pierre-Doray (Gerrit)

unread,
Jan 13, 2026, 12:33:07 PMJan 13
to Thiabaud Engelbrecht, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, chikamu...@chromium.org, kinuko...@chromium.org, scheduler-...@chromium.org
Attention needed from Thiabaud Engelbrecht

Etienne Pierre-Doray added 1 comment

File third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.h
Line 139, Patchset 1 (Latest): public performance_scenarios::PerformanceScenarioObserver {
Etienne Pierre-Doray . unresolved

You're missing Add(Matching)Observer() registration

Open in Gerrit

Related details

Attention is currently required from:
  • Thiabaud Engelbrecht
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iff355344e7aca3d5bb0f052e4f84e029236b5e30
Gerrit-Change-Number: 7452593
Gerrit-PatchSet: 1
Gerrit-Owner: Thiabaud Engelbrecht <thia...@google.com>
Gerrit-Reviewer: Thiabaud Engelbrecht <thia...@google.com>
Gerrit-CC: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Attention: Thiabaud Engelbrecht <thia...@google.com>
Gerrit-Comment-Date: Tue, 13 Jan 2026 17:32:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Thiabaud Engelbrecht (Gerrit)

unread,
Jan 13, 2026, 2:42:57 PMJan 13
to Etienne Pierre-Doray, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, chikamu...@chromium.org, kinuko...@chromium.org, scheduler-...@chromium.org
Attention needed from Etienne Pierre-Doray

Thiabaud Engelbrecht added 1 comment

File third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.h
Line 139, Patchset 1: public performance_scenarios::PerformanceScenarioObserver {
Etienne Pierre-Doray . resolved

You're missing Add(Matching)Observer() registration

Thiabaud Engelbrecht

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Etienne Pierre-Doray
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iff355344e7aca3d5bb0f052e4f84e029236b5e30
    Gerrit-Change-Number: 7452593
    Gerrit-PatchSet: 2
    Gerrit-Owner: Thiabaud Engelbrecht <thia...@google.com>
    Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Thiabaud Engelbrecht <thia...@google.com>
    Gerrit-Attention: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Comment-Date: Tue, 13 Jan 2026 19:42:49 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Etienne Pierre-Doray <etie...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Etienne Pierre-Doray (Gerrit)

    unread,
    Jan 13, 2026, 2:48:45 PMJan 13
    to Thiabaud Engelbrecht, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, chikamu...@chromium.org, kinuko...@chromium.org, scheduler-...@chromium.org
    Attention needed from Thiabaud Engelbrecht

    Etienne Pierre-Doray voted and added 1 comment

    Votes added by Etienne Pierre-Doray

    Code-Review+1

    1 comment

    Patchset-level comments
    File-level comment, Patchset 2 (Latest):
    Etienne Pierre-Doray . resolved

    LGTM

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Thiabaud Engelbrecht
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Iff355344e7aca3d5bb0f052e4f84e029236b5e30
      Gerrit-Change-Number: 7452593
      Gerrit-PatchSet: 2
      Gerrit-Owner: Thiabaud Engelbrecht <thia...@google.com>
      Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
      Gerrit-Reviewer: Thiabaud Engelbrecht <thia...@google.com>
      Gerrit-Attention: Thiabaud Engelbrecht <thia...@google.com>
      Gerrit-Comment-Date: Tue, 13 Jan 2026 19:48:35 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Joe Mason (Gerrit)

      unread,
      Jan 13, 2026, 4:05:07 PMJan 13
      to Thiabaud Engelbrecht, Etienne Pierre-Doray, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, chikamu...@chromium.org, kinuko...@chromium.org, scheduler-...@chromium.org
      Attention needed from Thiabaud Engelbrecht

      Joe Mason voted and added 2 comments

      Votes added by Joe Mason

      Code-Review+1

      2 comments

      File third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.h
      Line 213, Patchset 2 (Latest): void OnInputScenarioChanged(
      Joe Mason . unresolved

      Nit: add a `// PerformanceScenarioObserver implementation:` comment.

      File third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc
      Line 466, Patchset 2 (Latest): if (base::FeatureList::IsEnabled(kInputHandlingModeFromPerformanceScenario)) {
      Joe Mason . unresolved

      Nit: I would put the feature check around `AddObserver()` and `RemoveObserver()`. That way you don't get extra do-nothing notifications if the feature is disabled. This function will just never be called if the observer's never added.

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Thiabaud Engelbrecht
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement is not satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement is not satisfiedNo-Unresolved-Comments
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Iff355344e7aca3d5bb0f052e4f84e029236b5e30
        Gerrit-Change-Number: 7452593
        Gerrit-PatchSet: 2
        Gerrit-Owner: Thiabaud Engelbrecht <thia...@google.com>
        Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
        Gerrit-Reviewer: Joe Mason <joenot...@google.com>
        Gerrit-Reviewer: Thiabaud Engelbrecht <thia...@google.com>
        Gerrit-Attention: Thiabaud Engelbrecht <thia...@google.com>
        Gerrit-Comment-Date: Tue, 13 Jan 2026 21:04:57 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Thiabaud Engelbrecht (Gerrit)

        unread,
        Jan 14, 2026, 11:17:20 AMJan 14
        to Etienne Pierre-Doray, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, chikamu...@chromium.org, kinuko...@chromium.org, scheduler-...@chromium.org

        Thiabaud Engelbrecht voted and added 2 comments

        Votes added by Thiabaud Engelbrecht

        Commit-Queue+1

        2 comments

        File third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.h
        Line 213, Patchset 2: void OnInputScenarioChanged(
        Joe Mason . resolved

        Nit: add a `// PerformanceScenarioObserver implementation:` comment.

        Thiabaud Engelbrecht

        Done

        File third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc
        Line 466, Patchset 2: if (base::FeatureList::IsEnabled(kInputHandlingModeFromPerformanceScenario)) {
        Joe Mason . resolved

        Nit: I would put the feature check around `AddObserver()` and `RemoveObserver()`. That way you don't get extra do-nothing notifications if the feature is disabled. This function will just never be called if the observer's never added.

        Thiabaud Engelbrecht

        Done

        Open in Gerrit

        Related details

        Attention set is empty
        Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement is not satisfiedCode-Owners
          • requirement satisfiedCode-Review
          • requirement satisfiedReview-Enforcement
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: Iff355344e7aca3d5bb0f052e4f84e029236b5e30
          Gerrit-Change-Number: 7452593
          Gerrit-PatchSet: 4
          Gerrit-Owner: Thiabaud Engelbrecht <thia...@google.com>
          Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
          Gerrit-Reviewer: Joe Mason <joenot...@google.com>
          Gerrit-Reviewer: Thiabaud Engelbrecht <thia...@google.com>
          Gerrit-Comment-Date: Wed, 14 Jan 2026 16:17:09 +0000
          Gerrit-HasComments: Yes
          Gerrit-Has-Labels: Yes
          Comment-In-Reply-To: Joe Mason <joenot...@google.com>
          satisfied_requirement
          unsatisfied_requirement
          open
          diffy

          Francois Pierre Doray (Gerrit)

          unread,
          Jan 14, 2026, 3:09:30 PMJan 14
          to Thiabaud Engelbrecht, Etienne Pierre-Doray, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, chikamu...@chromium.org, kinuko...@chromium.org, scheduler-...@chromium.org
          Attention needed from Thiabaud Engelbrecht

          Francois Pierre Doray voted Code-Review+1

          Code-Review+1
          Open in Gerrit

          Related details

          Attention is currently required from:
          • Thiabaud Engelbrecht
          Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement satisfiedCode-Owners
          • requirement satisfiedCode-Review
          • requirement satisfiedReview-Enforcement
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: Iff355344e7aca3d5bb0f052e4f84e029236b5e30
          Gerrit-Change-Number: 7452593
          Gerrit-PatchSet: 4
          Gerrit-Owner: Thiabaud Engelbrecht <thia...@google.com>
          Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
          Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
          Gerrit-Reviewer: Joe Mason <joenot...@google.com>
          Gerrit-Reviewer: Thiabaud Engelbrecht <thia...@google.com>
          Gerrit-Attention: Thiabaud Engelbrecht <thia...@google.com>
          Gerrit-Comment-Date: Wed, 14 Jan 2026 20:09:19 +0000
          Gerrit-HasComments: No
          Gerrit-Has-Labels: Yes
          satisfied_requirement
          open
          diffy

          Thiabaud Engelbrecht (Gerrit)

          unread,
          Jan 15, 2026, 11:40:44 AMJan 15
          to Francois Pierre Doray, Etienne Pierre-Doray, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, chikamu...@chromium.org, kinuko...@chromium.org, scheduler-...@chromium.org

          Thiabaud Engelbrecht voted Commit-Queue+2

          Commit-Queue+2
          Open in Gerrit

          Related details

          Attention set is empty
          Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement satisfiedCode-Owners
          • requirement satisfiedCode-Review
          • requirement satisfiedReview-Enforcement
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: Iff355344e7aca3d5bb0f052e4f84e029236b5e30
          Gerrit-Change-Number: 7452593
          Gerrit-PatchSet: 4
          Gerrit-Owner: Thiabaud Engelbrecht <thia...@google.com>
          Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
          Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
          Gerrit-Reviewer: Joe Mason <joenot...@google.com>
          Gerrit-Reviewer: Thiabaud Engelbrecht <thia...@google.com>
          Gerrit-Comment-Date: Thu, 15 Jan 2026 16:40:31 +0000
          Gerrit-HasComments: No
          Gerrit-Has-Labels: Yes
          satisfied_requirement
          open
          diffy

          Chromium LUCI CQ (Gerrit)

          unread,
          Jan 15, 2026, 12:41:36 PMJan 15
          to Thiabaud Engelbrecht, Francois Pierre Doray, Etienne Pierre-Doray, chromium...@chromium.org, blink-...@chromium.org, chikamu...@chromium.org, kinuko...@chromium.org, scheduler-...@chromium.org

          Chromium LUCI CQ submitted the change

          Change information

          Commit message:
          [renderer] Fix input mode using PerformanceScenario
          Bug: 444705203
          Change-Id: Iff355344e7aca3d5bb0f052e4f84e029236b5e30
          Reviewed-by: Joe Mason <joenot...@google.com>
          Reviewed-by: Francois Pierre Doray <fdo...@chromium.org>
          Reviewed-by: Etienne Pierre-Doray <etie...@chromium.org>
          Commit-Queue: Thiabaud Engelbrecht <thia...@google.com>
          Cr-Commit-Position: refs/heads/main@{#1569826}
          Files:
          • M third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc
          • M third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.h
          Change size: M
          Delta: 2 files changed, 41 insertions(+), 12 deletions(-)
          Branch: refs/heads/main
          Submit Requirements:
          • requirement satisfiedCode-Review: +1 by Joe Mason, +1 by Etienne Pierre-Doray, +1 by Francois Pierre Doray
          Open in Gerrit
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: merged
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: Iff355344e7aca3d5bb0f052e4f84e029236b5e30
          Gerrit-Change-Number: 7452593
          Gerrit-PatchSet: 5
          Gerrit-Owner: Thiabaud Engelbrecht <thia...@google.com>
          Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
          Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
          Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
          Gerrit-Reviewer: Joe Mason <joenot...@google.com>
          Gerrit-Reviewer: Thiabaud Engelbrecht <thia...@google.com>
          open
          diffy
          satisfied_requirement
          Reply all
          Reply to author
          Forward
          0 new messages