[iOS] Add ButtonStackViewController to VC Catalog [chromium/src : main]
0 views
Skip to first unread message
Anis Chara (Gerrit)
Jul 8, 2026, 4:23:03 AM (2 days ago) Jul 8
to chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Anis Chara abandoned this change.
Abandoned
Anis Chara abandoned this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ewann Pellé (Gerrit)
Jul 8, 2026, 5:22:49 AM (2 days ago) Jul 8
to Anis Chara, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Anis Chara
Ewann Pellé added 2 comments![]( "Open in Gerrit")
Commit Message
Line 10, Patchset 3 (Latest):
catalog.File ios/chrome/browser/catalogs/ui/view_controller_catalog_view_controller.mm
Line 133, Patchset 3 (Latest):
ButtonStackViewController* buttonStackViewController =Ewann Pellé . unresolved
can you also configure its contentView ? you can add an UILabel with a dummy text ans also configure its background color to highlight its size.
Related details
Attention is currently required from:
- Anis Chara
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Anis Chara (Gerrit)
Jul 9, 2026, 5:23:20 AM (yesterday) Jul 9
to Ewann Pellé, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Ewann Pellé
Anis Chara added 2 comments![]( "Open in Gerrit")
Commit Message
nit: add a screenshot (https://screenshot.googleplex.com/)
Anis Chara
Done
File ios/chrome/browser/catalogs/ui/view_controller_catalog_view_controller.mm
can you also configure its contentView ? you can add an UILabel with a dummy text ans also configure its background color to highlight its size.
Attention is currently required from:
- Ewann Pellé
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ewann Pellé (Gerrit)
Jul 9, 2026, 5:50:47 AM (yesterday) Jul 9
to Anis Chara, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Anis Chara
Ewann Pellé voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Anis Chara
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gauthier Ambard (Gerrit)
Jul 9, 2026, 11:48:58 AM (20 hours ago) Jul 9
to Anis Chara, Ewann Pellé, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Anis Chara
Gauthier Ambard voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Anis Chara
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Anis Chara (Gerrit)
5:30 AM (2 hours ago) 5:30 AM
to Gauthier Ambard, Ewann Pellé, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Anis Chara voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
6:27 AM (1 hour ago) 6:27 AM
to Anis Chara, Gauthier Ambard, Ewann Pellé, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[iOS] Add ButtonStackViewController to VC Catalog
This CL adds the ButtonStackViewController to the ViewController
catalog.
screenshot:https://screenshot.googleplex.com/api/7LyJkQjfDsabgUf.png
Bug: 522151908
Change-Id: Idb168ea7d2e4a08364a1269bdcf32788104da541
Reviewed-by: Ewann Pellé <ewa...@chromium.org>
Reviewed-by: Gauthier Ambard <gam...@chromium.org>
Commit-Queue: Anis Chara <ach...@google.com>
Cr-Commit-Position: refs/heads/main@{#1660158}
Files:
- M ios/chrome/browser/catalogs/ui/BUILD.gn
- A ios/chrome/browser/catalogs/ui/demo_button_stack_view_controller.h
- A ios/chrome/browser/catalogs/ui/demo_button_stack_view_controller.mm
- M ios/chrome/browser/catalogs/ui/view_controller_catalog_view_controller.mm
Change size: M
Delta: 4 files changed, 73 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Ewann Pellé, +1 by Gauthier Ambard
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages