webrtc-internals: move getStats polling to C+ [chromium/src : main]
0 views
Skip to first unread message
Philipp Hancke (Gerrit)
5:49 AM (3 hours ago) 5:49 AM
to Elad Alon, Guido Urdaneta, chromium...@chromium.org
Attention needed from Elad Alon and Guido Urdaneta
Philipp Hancke added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2:
Philipp Hancke . resolved
this ended up being less complicated than "prevent the JS from being frozen" - but thank you Elad for showing how that would work!
Related details
Attention is currently required from:
- Elad Alon
- Guido Urdaneta
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Guido Urdaneta (Gerrit)
6:08 AM (3 hours ago) 6:08 AM
to Philipp Hancke, Elad Alon, chromium...@chromium.org
Attention needed from Elad Alon and Philipp Hancke
Guido Urdaneta added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 4 (Latest):
Guido Urdaneta . unresolved
the code lgtm, but shouldn't you also remove references to statsInterval from content/browser/webrtc/resources/stats_graph_helper.js?
Related details
Attention is currently required from:
- Elad Alon
- Philipp Hancke
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Philipp Hancke (Gerrit)
6:12 AM (2 hours ago) 6:12 AM
to Elad Alon, Guido Urdaneta, chromium...@chromium.org
Attention needed from Elad Alon and Guido Urdaneta
Philipp Hancke added 1 comment![]( "Open in Gerrit")
Patchset-level comments
the code lgtm, but shouldn't you also remove references to statsInterval from content/browser/webrtc/resources/stats_graph_helper.js?
Attention is currently required from:
- Elad Alon
- Guido Urdaneta
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Guido Urdaneta (Gerrit)
7:26 AM (1 hour ago) 7:26 AM
to Philipp Hancke, Elad Alon, chromium...@chromium.org
Attention needed from Elad Alon and Philipp Hancke
Guido Urdaneta voted and added 1 comment![]( "Open in Gerrit")
Votes added by Guido Urdaneta
| Code-Review | +1 |
1 comment
Commit Message
Line 7, Patchset 5 (Latest):
webrtc-internals: move getStats polling to C+Guido Urdaneta . unresolved
C+ -> C++
Related details
Attention is currently required from:
- Elad Alon
- Philipp Hancke
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages