Introduce TestSuiteMapper agent skill [chromium/src : main]

0 views
Skip to first unread message

Brian Sheedy (Gerrit)

unread,
Jun 5, 2026, 5:18:08 PMJun 5
to Aadarsh Battula, Bryan Kim, chromium...@chromium.org, Prakhar Asthana
Attention needed from Aadarsh Battula and Prakhar Asthana

Brian Sheedy voted and added 2 comments

Votes added by Brian Sheedy

Code-Review+1

2 comments

Patchset-level comments
File-level comment, Patchset 8 (Latest):
Brian Sheedy . resolved

LGTM % nit

+cc bryankim since this adds a couple more evals that will need to be promoted to stable at some point.

File agents/skills/experimental-test-suite-mapper/SKILL.md
Line 103, Patchset 8 (Latest):## Technical Architecture (GN Tracing Mechanism)

The mapping executes in four distinct steps:

1. **Build Configuration Validation:** Verifies that the build directory
contains `args.gn` and is configured for `target_os = "linux"` (or defaults
to Linux host).
2. **Path Normalization:** Converts the target path to standard GN syntax
starting with `//`.
3. **GN Graph Resolution:** Resolves the transitive dependency closure compiling
the target file, including runtime data dependencies.
4. **Isolate Map Lookup and Proximity Filtering:** Filters the resolved targets
against the bot-active test suites list. If multiple suites are found, they
are scored based on directory proximity to the source file to prioritize the
most relevant test suite.
Brian Sheedy . unresolved

Nit: This seems irrelevant for a skill? The script should (hopefully) work in all cases, and if it doesn't for some reason, the agent will likely just look at the source code to figure out what it's doing anyways.

Open in Gerrit

Related details

Attention is currently required from:
  • Aadarsh Battula
  • Prakhar Asthana
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie1fbfc9dc1f2c07009a31de1a58efe54b81c7241
Gerrit-Change-Number: 7906078
Gerrit-PatchSet: 8
Gerrit-Owner: Aadarsh Battula <aada...@google.com>
Gerrit-Reviewer: Brian Sheedy <bsh...@chromium.org>
Gerrit-Reviewer: Prakhar Asthana <past...@google.com>
Gerrit-CC: Bryan Kim <brya...@google.com>
Gerrit-Attention: Aadarsh Battula <aada...@google.com>
Gerrit-Attention: Prakhar Asthana <past...@google.com>
Gerrit-Comment-Date: Fri, 05 Jun 2026 21:17:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Aadarsh Battula (Gerrit)

unread,
Jun 5, 2026, 5:58:40 PMJun 5
to Brian Sheedy, Bryan Kim, chromium...@chromium.org, Prakhar Asthana
Attention needed from Brian Sheedy and Prakhar Asthana

Aadarsh Battula added 1 comment

File agents/skills/experimental-test-suite-mapper/SKILL.md
Line 103, Patchset 8:## Technical Architecture (GN Tracing Mechanism)


The mapping executes in four distinct steps:

1. **Build Configuration Validation:** Verifies that the build directory
contains `args.gn` and is configured for `target_os = "linux"` (or defaults
to Linux host).
2. **Path Normalization:** Converts the target path to standard GN syntax
starting with `//`.
3. **GN Graph Resolution:** Resolves the transitive dependency closure compiling
the target file, including runtime data dependencies.
4. **Isolate Map Lookup and Proximity Filtering:** Filters the resolved targets
against the bot-active test suites list. If multiple suites are found, they
are scored based on directory proximity to the source file to prioritize the
most relevant test suite.
Brian Sheedy . resolved

Nit: This seems irrelevant for a skill? The script should (hopefully) work in all cases, and if it doesn't for some reason, the agent will likely just look at the source code to figure out what it's doing anyways.

Aadarsh Battula

Marked as resolved.

Open in Gerrit

Related details

Attention is currently required from:
  • Brian Sheedy
  • Prakhar Asthana
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie1fbfc9dc1f2c07009a31de1a58efe54b81c7241
    Gerrit-Change-Number: 7906078
    Gerrit-PatchSet: 15
    Gerrit-Owner: Aadarsh Battula <aada...@google.com>
    Gerrit-Reviewer: Brian Sheedy <bsh...@chromium.org>
    Gerrit-Reviewer: Prakhar Asthana <past...@google.com>
    Gerrit-CC: Bryan Kim <brya...@google.com>
    Gerrit-Attention: Prakhar Asthana <past...@google.com>
    Gerrit-Attention: Brian Sheedy <bsh...@chromium.org>
    Gerrit-Comment-Date: Fri, 05 Jun 2026 21:58:29 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Brian Sheedy <bsh...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Brian Sheedy (Gerrit)

    unread,
    Jun 5, 2026, 6:08:40 PMJun 5
    to Aadarsh Battula, Bryan Kim, chromium...@chromium.org, Prakhar Asthana
    Attention needed from Aadarsh Battula and Prakhar Asthana

    Brian Sheedy voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Aadarsh Battula
    • Prakhar Asthana
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ie1fbfc9dc1f2c07009a31de1a58efe54b81c7241
      Gerrit-Change-Number: 7906078
      Gerrit-PatchSet: 15
      Gerrit-Owner: Aadarsh Battula <aada...@google.com>
      Gerrit-Reviewer: Brian Sheedy <bsh...@chromium.org>
      Gerrit-Reviewer: Prakhar Asthana <past...@google.com>
      Gerrit-CC: Bryan Kim <brya...@google.com>
      Gerrit-Attention: Aadarsh Battula <aada...@google.com>
      Gerrit-Attention: Prakhar Asthana <past...@google.com>
      Gerrit-Comment-Date: Fri, 05 Jun 2026 22:08:24 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Brian Sheedy (Gerrit)

      unread,
      Jun 8, 2026, 2:05:17 PMJun 8
      to Aadarsh Battula, Bryan Kim, chromium...@chromium.org, Prakhar Asthana
      Attention needed from Aadarsh Battula and Prakhar Asthana

      Brian Sheedy voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Aadarsh Battula
      • Prakhar Asthana
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ie1fbfc9dc1f2c07009a31de1a58efe54b81c7241
      Gerrit-Change-Number: 7906078
      Gerrit-PatchSet: 18
      Gerrit-Owner: Aadarsh Battula <aada...@google.com>
      Gerrit-Reviewer: Brian Sheedy <bsh...@chromium.org>
      Gerrit-Reviewer: Prakhar Asthana <past...@google.com>
      Gerrit-CC: Bryan Kim <brya...@google.com>
      Gerrit-Attention: Aadarsh Battula <aada...@google.com>
      Gerrit-Attention: Prakhar Asthana <past...@google.com>
      Gerrit-Comment-Date: Mon, 08 Jun 2026 18:05:03 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Prakhar Asthana (Gerrit)

      unread,
      4:10 PM (2 hours ago) 4:10 PM
      to Aadarsh Battula, Code Review Nudger, Brian Sheedy, Bryan Kim, chromium...@chromium.org
      Attention needed from Aadarsh Battula

      Prakhar Asthana voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Aadarsh Battula
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Ie1fbfc9dc1f2c07009a31de1a58efe54b81c7241
        Gerrit-Change-Number: 7906078
        Gerrit-PatchSet: 18
        Gerrit-Owner: Aadarsh Battula <aada...@google.com>
        Gerrit-Reviewer: Brian Sheedy <bsh...@chromium.org>
        Gerrit-Reviewer: Prakhar Asthana <past...@google.com>
        Gerrit-CC: Bryan Kim <brya...@google.com>
        Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
        Gerrit-Attention: Aadarsh Battula <aada...@google.com>
        Gerrit-Comment-Date: Wed, 08 Jul 2026 20:10:16 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        Aadarsh Battula (Gerrit)

        unread,
        4:16 PM (2 hours ago) 4:16 PM
        to Chromium LUCI CQ, Prakhar Asthana, Code Review Nudger, Brian Sheedy, Bryan Kim, chromium...@chromium.org

        Aadarsh Battula voted Commit-Queue+2

        Commit-Queue+2
        Open in Gerrit

        Related details

        Attention set is empty
        Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Ie1fbfc9dc1f2c07009a31de1a58efe54b81c7241
        Gerrit-Change-Number: 7906078
        Gerrit-PatchSet: 18
        Gerrit-Owner: Aadarsh Battula <aada...@google.com>
        Gerrit-Reviewer: Aadarsh Battula <aada...@google.com>
        Gerrit-Reviewer: Brian Sheedy <bsh...@chromium.org>
        Gerrit-Reviewer: Prakhar Asthana <past...@google.com>
        Gerrit-CC: Bryan Kim <brya...@google.com>
        Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
        Gerrit-Comment-Date: Wed, 08 Jul 2026 20:15:44 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy
        Reply all
        Reply to author
        Forward
        0 new messages