extensions: Decouple EventRouter from g_browser_process [chromium/src : main]
0 views
Skip to first unread message
Jun Ishiguro (Gerrit)
5:19 AM (7 hours ago) 5:19 AM
to Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, filesapp...@chromium.org, rginda...@chromium.org
Jun Ishiguro added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hidehiko Abe (Gerrit)
8:13 AM (4 hours ago) 8:13 AM
to Jun Ishiguro, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, filesapp...@chromium.org, rginda...@chromium.org
Attention needed from Jun Ishiguro
Hidehiko Abe voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Jun Ishiguro
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jun Ishiguro (Gerrit)
9:40 AM (3 hours ago) 9:40 AM
to Hidehiko Abe, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, filesapp...@chromium.org, rginda...@chromium.org
Jun Ishiguro voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
9:44 AM (3 hours ago) 9:44 AM
to Jun Ishiguro, Hidehiko Abe, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, filesapp...@chromium.org, rginda...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
extensions: Decouple EventRouter from g_browser_process
Replace direct access to g_browser_process->local_state() in EventRouter
with explicit constructor dependency injection of PrefService. Global
singleton retrieval is now cleanly bounded to EventRouterFactory, and
unit tests inject local state using TestingBrowserProcess test fakes.
TAG=agy
Bug: b:404131876
Change-Id: I970b8e141eb34f6cf48d837240302e7b7a5dd5a4
Reviewed-by: Hidehiko Abe <hide...@chromium.org>
Commit-Queue: Jun Ishiguro <ju...@google.com>
Cr-Commit-Position: refs/heads/main@{#1658699}
Files:
- M chrome/browser/ash/extensions/file_manager/event_router.cc
- M chrome/browser/ash/extensions/file_manager/event_router.h
- M chrome/browser/ash/extensions/file_manager/event_router_factory.cc
- M chrome/browser/ash/extensions/file_manager/event_router_unittest.cc
Change size: S
Delta: 4 files changed, 18 insertions(+), 10 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Hidehiko Abe
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages