Delete tools/run-swarmed.py [chromium/src : main]
Ben Pastene (Gerrit)
Ben Pastene voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
- Brian Sheedy
- Struan Shrimpton
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brian Sheedy (Gerrit)
Brian Sheedy voted Code-Review+1![]( "Open in Gerrit")
- Ben Pastene
- Struan Shrimpton
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Struan Shrimpton (Gerrit)
Struan Shrimpton voted and added 1 comment![]( "Open in Gerrit")
Votes added by Struan Shrimpton
| Code-Review | +1 |
1 comment
even fix them! See [utr/README.md](../../tools/utr/README.md) for more tips onSame nit as the other cl, might be better to put this first. lgtm either way though
Related details
- Ben Pastene
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ben Pastene (Gerrit)
Ben Pastene voted and added 1 comment![]( "Open in Gerrit")
Votes added by Ben Pastene
| Commit-Queue | +1 |
1 comment
even fix them! See [utr/README.md](../../tools/utr/README.md) for more tips onSame nit as the other cl, might be better to put this first. lgtm either way though
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ben Pastene (Gerrit)
Ben Pastene added 1 comment![]( "Open in Gerrit")
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nico Weber (Gerrit)
Nico Weber added 1 comment![]( "Open in Gerrit")
Can you put a pointer on what to use instead (like a link to the UTR docs, or a "before command: `...`, after command `...`) in the CL description?
Related details
- Ben Pastene
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nico Weber (Gerrit)
Nico Weber added 1 comment![]( "Open in Gerrit")
...and how hard is it possible to make run-swarmed.py call the new thing, so that this is transparent to users?
Ben Pastene (Gerrit)
Ben Pastene added 2 comments![]( "Open in Gerrit")
...and how hard is it possible to make run-swarmed.py call the new thing, so that this is transparent to users?
Doable with a little magic. But normal invocations of run-swarmed.py have been immediately failing with a deprecation notice and pointer to the new tool since feb of last year (which can be bypassed via `--force`). I think that's enough time for folks to migrate? At some point we'd like to be able to delete the old stuff IMO.
Can you put a pointer on what to use instead (like a link to the UTR docs, or a "before command: `...`, after command `...`) in the CL description?
- Nico Weber
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nico Weber (Gerrit)
Nico Weber added 2 comments![]( "Open in Gerrit")
Ben Pastene...and how hard is it possible to make run-swarmed.py call the new thing, so that this is transparent to users?
Doable with a little magic. But normal invocations of run-swarmed.py have been immediately failing with a deprecation notice and pointer to the new tool since feb of last year (which can be bypassed via `--force`). I think that's enough time for folks to migrate? At some point we'd like to be able to delete the old stuff IMO.
The ideas was that tools/run-swarmed.py just wrapped whatever the current way is, so that people don't have to re-learn the command du jour is. The old invocation in your CL description requires knowing More Stuff ("-p chromium -B try -b linux-rel").
I won't stop you if you've made up your mind, but imho updating the script instead of deleting it seems nicer. (There's at least one internal page referring to it, etc.)
Related details
- Ben Pastene
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ben Pastene (Gerrit)
Ben Pastene added 1 comment![]( "Open in Gerrit")
Ben Pastene...and how hard is it possible to make run-swarmed.py call the new thing, so that this is transparent to users?
Nico WeberDoable with a little magic. But normal invocations of run-swarmed.py have been immediately failing with a deprecation notice and pointer to the new tool since feb of last year (which can be bypassed via `--force`). I think that's enough time for folks to migrate? At some point we'd like to be able to delete the old stuff IMO.
The ideas was that tools/run-swarmed.py just wrapped whatever the current way is, so that people don't have to re-learn the command du jour is. The old invocation in your CL description requires knowing More Stuff ("-p chromium -B try -b linux-rel").
tools/run-swarmed.py has been fast-failing with a deprecation notice for nearly a year (with a pointer to the new tool). If it was insufficient, I imagine/hope we would have gotten feedback from the old run-swarmed.py users about it. eg: `UTR requires knowing too much "More Stuff"` - but I don't believe we've gotten that feedback.
And I don't think it's fair to paint it as a "du jour" tool. It has official support from the infra team + owners + telemetry + tests. It even has builder coverage to ensure it doesn't regress: https://ci.chromium.org/ui/builder-search?q=utr-tester. It's the tool we the infra team want folks using when interacting with the infra.
Related details
- Nico Weber
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |