[bedrock] Support UnownedUserData for SidePanelUI [chromium/src : main]

0 views
Skip to first unread message

Thomas Lukaszewicz (Gerrit)

unread,
May 27, 2026, 12:42:10 AM (yesterday) May 27
to Keren Zhu, Moe Adel, chromium...@chromium.org, Charles Hager, Linyu He, Mark Schillaci, Neil Coronado, Shu Yang, Sinan Sahin
Attention needed from Keren Zhu

Thomas Lukaszewicz voted and added 1 comment

Votes added by Thomas Lukaszewicz

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Thomas Lukaszewicz . resolved

Keren ptal

Open in Gerrit

Related details

Attention is currently required from:
  • Keren Zhu
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iffdd2e778f5f9be5fb0d47e31de1edaa37429713
Gerrit-Change-Number: 7877906
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Lukaszewicz <tl...@chromium.org>
Gerrit-Reviewer: Keren Zhu <kere...@chromium.org>
Gerrit-Reviewer: Thomas Lukaszewicz <tl...@chromium.org>
Gerrit-CC: Charles Hager <clh...@google.com>
Gerrit-CC: Linyu He <lin...@google.com>
Gerrit-CC: Mark Schillaci <mschi...@google.com>
Gerrit-CC: Moe Adel <ad...@google.com>
Gerrit-CC: Neil Coronado <ne...@google.com>
Gerrit-CC: Shu Yang <shu...@google.com>
Gerrit-CC: Sinan Sahin <sinan...@google.com>
Gerrit-Attention: Keren Zhu <kere...@chromium.org>
Gerrit-Comment-Date: Wed, 27 May 2026 04:41:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Thomas Lukaszewicz (Gerrit)

unread,
2:04 AM (15 hours ago) 2:04 AM
to Keren Zhu, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Moe Adel, chromium...@chromium.org, Charles Hager, Linyu He, Mark Schillaci, Neil Coronado, Shu Yang, Sinan Sahin, chromiumme...@microsoft.com, asvitki...@chromium.org
Attention needed from Keren Zhu

Thomas Lukaszewicz voted and added 1 comment

Votes added by Thomas Lukaszewicz

Commit-Queue+1

1 comment

Patchset-level comments
Thomas Lukaszewicz . resolved

Keren ptal

Open in Gerrit

Related details

Attention is currently required from:
  • Keren Zhu
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iffdd2e778f5f9be5fb0d47e31de1edaa37429713
Gerrit-Change-Number: 7877906
Gerrit-PatchSet: 7
Gerrit-Owner: Thomas Lukaszewicz <tl...@chromium.org>
Gerrit-Reviewer: Keren Zhu <kere...@chromium.org>
Gerrit-Reviewer: Thomas Lukaszewicz <tl...@chromium.org>
Gerrit-CC: Charles Hager <clh...@google.com>
Gerrit-CC: Linyu He <lin...@google.com>
Gerrit-CC: Mark Schillaci <mschi...@google.com>
Gerrit-CC: Moe Adel <ad...@google.com>
Gerrit-CC: Neil Coronado <ne...@google.com>
Gerrit-CC: Shu Yang <shu...@google.com>
Gerrit-CC: Sinan Sahin <sinan...@google.com>
Gerrit-Attention: Keren Zhu <kere...@chromium.org>
Gerrit-Comment-Date: Thu, 28 May 2026 06:04:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Keren Zhu (Gerrit)

unread,
12:37 PM (4 hours ago) 12:37 PM
to Thomas Lukaszewicz, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Moe Adel, chromium...@chromium.org, Charles Hager, Linyu He, Mark Schillaci, Neil Coronado, Shu Yang, Sinan Sahin, chromiumme...@microsoft.com, asvitki...@chromium.org
Attention needed from Thomas Lukaszewicz

Keren Zhu added 2 comments

Commit Message
Line 14, Patchset 9 (Latest):180 callsites for the original BWF accessor, these will be
Keren Zhu . unresolved

Do you mean BWI?

File chrome/browser/contextual_tasks/contextual_tasks_panel_host_desktop_unittest.cc
Line 82, Patchset 9 (Latest): std::optional<NiceMock<MockSidePanelUI>> mock_side_panel_ui_;
Keren Zhu . unresolved
nit: can we remove `std::optional`? This object seems always avaiable.
```suggestion
  NiceMock<MockSidePanelUI> mock_side_panel_ui_{unowned_user_data_host_};
```
Open in Gerrit

Related details

Attention is currently required from:
  • Thomas Lukaszewicz
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iffdd2e778f5f9be5fb0d47e31de1edaa37429713
    Gerrit-Change-Number: 7877906
    Gerrit-PatchSet: 9
    Gerrit-Owner: Thomas Lukaszewicz <tl...@chromium.org>
    Gerrit-Reviewer: Keren Zhu <kere...@chromium.org>
    Gerrit-Reviewer: Thomas Lukaszewicz <tl...@chromium.org>
    Gerrit-CC: Charles Hager <clh...@google.com>
    Gerrit-CC: Linyu He <lin...@google.com>
    Gerrit-CC: Mark Schillaci <mschi...@google.com>
    Gerrit-CC: Moe Adel <ad...@google.com>
    Gerrit-CC: Neil Coronado <ne...@google.com>
    Gerrit-CC: Shu Yang <shu...@google.com>
    Gerrit-CC: Sinan Sahin <sinan...@google.com>
    Gerrit-Attention: Thomas Lukaszewicz <tl...@chromium.org>
    Gerrit-Comment-Date: Thu, 28 May 2026 16:37:22 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Keren Zhu (Gerrit)

    unread,
    1:06 PM (4 hours ago) 1:06 PM
    to Thomas Lukaszewicz, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Moe Adel, chromium...@chromium.org, Charles Hager, Linyu He, Mark Schillaci, Neil Coronado, Shu Yang, Sinan Sahin, chromiumme...@microsoft.com, asvitki...@chromium.org
    Attention needed from Thomas Lukaszewicz

    Keren Zhu voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Thomas Lukaszewicz
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Iffdd2e778f5f9be5fb0d47e31de1edaa37429713
      Gerrit-Change-Number: 7877906
      Gerrit-PatchSet: 9
      Gerrit-Owner: Thomas Lukaszewicz <tl...@chromium.org>
      Gerrit-Reviewer: Keren Zhu <kere...@chromium.org>
      Gerrit-Reviewer: Thomas Lukaszewicz <tl...@chromium.org>
      Gerrit-CC: Charles Hager <clh...@google.com>
      Gerrit-CC: Linyu He <lin...@google.com>
      Gerrit-CC: Mark Schillaci <mschi...@google.com>
      Gerrit-CC: Moe Adel <ad...@google.com>
      Gerrit-CC: Neil Coronado <ne...@google.com>
      Gerrit-CC: Shu Yang <shu...@google.com>
      Gerrit-CC: Sinan Sahin <sinan...@google.com>
      Gerrit-Attention: Thomas Lukaszewicz <tl...@chromium.org>
      Gerrit-Comment-Date: Thu, 28 May 2026 17:06:47 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Thomas Lukaszewicz (Gerrit)

      unread,
      3:38 PM (1 hour ago) 3:38 PM
      to Keren Zhu, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Moe Adel, chromium...@chromium.org, Charles Hager, Linyu He, Mark Schillaci, Neil Coronado, Shu Yang, Sinan Sahin, chromiumme...@microsoft.com, asvitki...@chromium.org

      Thomas Lukaszewicz voted and added 2 comments

      Votes added by Thomas Lukaszewicz

      Commit-Queue+2

      2 comments

      Commit Message
      Line 14, Patchset 9:180 callsites for the original BWF accessor, these will be
      Keren Zhu . resolved

      Do you mean BWI?

      Thomas Lukaszewicz

      In this case its BrowserWindowFeatures - there's a getter there that we can remove and have clients call `SidePanelUI::From()` instead.

      File chrome/browser/contextual_tasks/contextual_tasks_panel_host_desktop_unittest.cc
      Line 82, Patchset 9: std::optional<NiceMock<MockSidePanelUI>> mock_side_panel_ui_;
      Keren Zhu . resolved
      nit: can we remove `std::optional`? This object seems always avaiable.
      ```suggestion
        NiceMock<MockSidePanelUI> mock_side_panel_ui_{unowned_user_data_host_};
      ```
      Thomas Lukaszewicz

      Good point - done.

      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Iffdd2e778f5f9be5fb0d47e31de1edaa37429713
        Gerrit-Change-Number: 7877906
        Gerrit-PatchSet: 10
        Gerrit-Owner: Thomas Lukaszewicz <tl...@chromium.org>
        Gerrit-Reviewer: Keren Zhu <kere...@chromium.org>
        Gerrit-Reviewer: Thomas Lukaszewicz <tl...@chromium.org>
        Gerrit-CC: Charles Hager <clh...@google.com>
        Gerrit-CC: Linyu He <lin...@google.com>
        Gerrit-CC: Mark Schillaci <mschi...@google.com>
        Gerrit-CC: Moe Adel <ad...@google.com>
        Gerrit-CC: Neil Coronado <ne...@google.com>
        Gerrit-CC: Shu Yang <shu...@google.com>
        Gerrit-CC: Sinan Sahin <sinan...@google.com>
        Gerrit-Comment-Date: Thu, 28 May 2026 19:38:28 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        Comment-In-Reply-To: Keren Zhu <kere...@chromium.org>
        satisfied_requirement
        open
        diffy

        Keren Zhu (Gerrit)

        unread,
        3:43 PM (1 hour ago) 3:43 PM
        to Thomas Lukaszewicz, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Moe Adel, chromium...@chromium.org, Charles Hager, Linyu He, Mark Schillaci, Neil Coronado, Shu Yang, Sinan Sahin, chromiumme...@microsoft.com, asvitki...@chromium.org
        Attention needed from Thomas Lukaszewicz

        Keren Zhu voted and added 2 comments

        Votes added by Keren Zhu

        Code-Review+1

        2 comments

        File chrome/browser/metrics/tab_stats/tab_stats_tracker_unittest.cc
        Line 567, Patchset 10 (Latest): std::optional<MockSidePanelUI> side_panel_ui_;
        Keren Zhu . unresolved

        here as well.

        File chrome/browser/renderer_context_menu/render_view_context_menu_unittest.cc
        Line 513, Patchset 10 (Latest): std::optional<MockSidePanelUI> side_panel_ui_;
        Keren Zhu . unresolved

        here as well.

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Thomas Lukaszewicz
        Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement satisfiedCode-Owners
          • requirement satisfiedCode-Review
          • requirement is not satisfiedNo-Unresolved-Comments
          • requirement satisfiedReview-Enforcement
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: Iffdd2e778f5f9be5fb0d47e31de1edaa37429713
          Gerrit-Change-Number: 7877906
          Gerrit-PatchSet: 10
          Gerrit-Owner: Thomas Lukaszewicz <tl...@chromium.org>
          Gerrit-Reviewer: Keren Zhu <kere...@chromium.org>
          Gerrit-Reviewer: Thomas Lukaszewicz <tl...@chromium.org>
          Gerrit-CC: Charles Hager <clh...@google.com>
          Gerrit-CC: Linyu He <lin...@google.com>
          Gerrit-CC: Mark Schillaci <mschi...@google.com>
          Gerrit-CC: Moe Adel <ad...@google.com>
          Gerrit-CC: Neil Coronado <ne...@google.com>
          Gerrit-CC: Shu Yang <shu...@google.com>
          Gerrit-CC: Sinan Sahin <sinan...@google.com>
          Gerrit-Attention: Thomas Lukaszewicz <tl...@chromium.org>
          Gerrit-Comment-Date: Thu, 28 May 2026 19:43:29 +0000
          Gerrit-HasComments: Yes
          Gerrit-Has-Labels: Yes
          satisfied_requirement
          unsatisfied_requirement
          open
          diffy
          Reply all
          Reply to author
          Forward
          0 new messages