[Immersive] Reduce accidental submenu opens from hover. [chromium/src : main]
0 views
Skip to first unread message
Lauren Winston (Gerrit)
7:44 PM (3 hours ago) 7:44 PM
to Kristi Saney, Jacobo Tapia, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, jatapiaro+wat...@google.com, lwinston+watc...@google.com, trewin...@google.com
Attention needed from Jacobo Tapia and Kristi Saney
Lauren Winston added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Lauren Winston . resolved
I think we definitely want to clear the timer, but the additional delay changes may be a bit too agressive, so I'm okay with reverting those for now. Playing with the menu hover with these changes definitely makes it much less likely to accidentally trigger something though!
Related details
Attention is currently required from:
- Jacobo Tapia
- Kristi Saney
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kristi Saney (Gerrit)
7:49 PM (3 hours ago) 7:49 PM
to Lauren Winston, Jacobo Tapia, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, jatapiaro+wat...@google.com, lwinston+watc...@google.com, trewin...@google.com
Attention needed from Jacobo Tapia and Lauren Winston
Kristi Saney voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Jacobo Tapia
- Lauren Winston
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jacobo Tapia (Gerrit)
8:10 PM (3 hours ago) 8:10 PM
to Lauren Winston, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, jatapiaro+wat...@google.com, lwinston+watc...@google.com, trewin...@google.com
Attention needed from Lauren Winston
Jacobo Tapia voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Lauren Winston
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lauren Winston (Gerrit)
8:11 PM (3 hours ago) 8:11 PM
to Jacobo Tapia, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, jatapiaro+wat...@google.com, lwinston+watc...@google.com, trewin...@google.com
Lauren Winston voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lauren Winston (Gerrit)
8:50 PM (2 hours ago) 8:50 PM
to Jacobo Tapia, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, jatapiaro+wat...@google.com, lwinston+watc...@google.com, trewin...@google.com
Lauren Winston voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
10:14 PM (1 hour ago) 10:14 PM
to Lauren Winston, Jacobo Tapia, Kristi Saney, AyeAye, chromium...@chromium.org, jatapiaro+wat...@google.com, lwinston+watc...@google.com, trewin...@google.com
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: chrome/test/data/webui/side_panel/read_anything/settings_menu_test.ts
Insertions: 11, Deletions: 1.
The diff is too large to show. Please review the diff.
```
```
The name of the file: chrome/browser/resources/side_panel/read_anything/menus/settings_menu.ts
Insertions: 6, Deletions: 1.
The diff is too large to show. Please review the diff.
```
```
The name of the file: chrome/browser/resources/side_panel/read_anything/read_anything.ts
Insertions: 1, Deletions: 1.
The diff is too large to show. Please review the diff.
```
Change information
Commit message:
[Immersive] Reduce accidental submenu opens from hover.
This CL:
- Clears the open timer after leaving the submenu
- Adds more of a delay to opening a submenu if
a submenu was recently opened
This might be a bit more aggressive than we want, so we
can gradually make it less aggressive when we have more
time to dedicate to it.
Bug: 475572729
Change-Id: I2b1fb85e63bd23fa1e1808f8e8784320f182b8f5
Reviewed-by: Jacobo Tapia <jata...@google.com>
Commit-Queue: Lauren Winston <lwin...@google.com>
Reviewed-by: Kristi Saney <krist...@google.com>
Cr-Commit-Position: refs/heads/main@{#1568874}
Files:
- M chrome/browser/resources/side_panel/read_anything/menus/settings_menu.ts
- M chrome/browser/resources/side_panel/read_anything/read_anything.ts
- M chrome/test/data/webui/side_panel/read_anything/settings_menu_test.ts
Change size: M
Delta: 3 files changed, 60 insertions(+), 5 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Jacobo Tapia, +1 by Kristi Saney
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages