policy: Remove g_browser_process from EnrollmentHandler [chromium/src : main]
0 views
Skip to first unread message
Jun Ishiguro (Gerrit)
Jun 16, 2026, 2:39:59 AM (8 days ago) Jun 16
to Hidehiko Abe, Chromium LUCI CQ, chromium...@chromium.org, Enterprise Policy Reviews, asumane...@google.com, rrsilva+wat...@google.com, tbarzi...@chromium.org
Attention needed from Hidehiko Abe
Jun Ishiguro added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Hidehiko Abe
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hidehiko Abe (Gerrit)
Jun 16, 2026, 2:47:30 AM (8 days ago) Jun 16
to Jun Ishiguro, Chromium LUCI CQ, chromium...@chromium.org, Enterprise Policy Reviews, asumane...@google.com, rrsilva+wat...@google.com, tbarzi...@chromium.org
Attention needed from Jun Ishiguro
Hidehiko Abe voted and added 2 comments![]( "Open in Gerrit")
Votes added by Hidehiko Abe
| Code-Review | +1 |
2 comments
Patchset-level comments
Hidehiko Abe . resolved
LGTM with a comment.
File chrome/browser/ash/policy/enrollment/enrollment_handler.cc
Line 616, Patchset 1 (Latest):
EnrollmentHandler::GetURLLoaderFactory() {Hidehiko Abe . unresolved
(optional) this is probably not needed, if we pass the instance to DeviceAccountInitializer at L571.
Related details
Attention is currently required from:
- Jun Ishiguro
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jun Ishiguro (Gerrit)
Jun 18, 2026, 1:38:52 AM (6 days ago) Jun 18
to Hidehiko Abe, Chromium LUCI CQ, chromium...@chromium.org, Enterprise Policy Reviews, asumane...@google.com, rrsilva+wat...@google.com, tbarzi...@chromium.org
Jun Ishiguro voted and added 2 comments![]( "Open in Gerrit")
Votes added by Jun Ishiguro
| Commit-Queue | +2 |
2 comments
Patchset-level comments
Jun Ishiguro . resolved
Thank you for the review!
File chrome/browser/ash/policy/enrollment/enrollment_handler.cc
Line 616, Patchset 1 (Latest):
EnrollmentHandler::GetURLLoaderFactory() {Hidehiko Abe . resolved
(optional) this is probably not needed, if we pass the instance to DeviceAccountInitializer at L571.
Jun Ishiguro
Thanks for the suggestion. Let me follow-up in a separate CL since I need to touch another delegate.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jun 18, 2026, 2:07:42 AM (6 days ago) Jun 18
to Jun Ishiguro, Hidehiko Abe, chromium...@chromium.org, Enterprise Policy Reviews, asumane...@google.com, rrsilva+wat...@google.com, tbarzi...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
policy: Remove g_browser_process from EnrollmentHandler
Inject PrefService and SharedURLLoaderFactory into the constructor of
EnrollmentHandler instead of retrieving them from the global
g_browser_process pointer. This improves component encapsulation and
testability.
TAG=agy
Bug: b:404133022
Change-Id: If0aec405bf97de2ab2687d3cc9ed97202041b99e
Commit-Queue: Jun Ishiguro <ju...@google.com>
Reviewed-by: Hidehiko Abe <hide...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1648813}
Files:
- M chrome/browser/ash/login/enrollment/enrollment_launcher.cc
- M chrome/browser/ash/policy/core/device_cloud_policy_manager_ash_unittest.cc
- M chrome/browser/ash/policy/enrollment/enrollment_handler.cc
- M chrome/browser/ash/policy/enrollment/enrollment_handler.h
Change size: M
Delta: 4 files changed, 37 insertions(+), 21 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Hidehiko Abe
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages