Johannes Henkel (Gerrit)

unread,

Jul 10, 2026, 2:26:15 AM (yesterday) Jul 10

to Michal Mocny, Scott Haseley, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, alexmo...@chromium.org, creis...@chromium.org, navigation...@chromium.org, mac-r...@chromium.org, blink-revi...@chromium.org, dtapuska+...@chromium.org, zol...@webkit.org, blink-...@chromium.org, core-timi...@chromium.org, speed-metrics...@chromium.org

Attention needed from Michal Mocny and Scott Haseley

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:

Michal Mocny
Scott Haseley

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Johannes Henkel (Gerrit)

unread,

Jul 10, 2026, 2:34:46 AM (yesterday) Jul 10

to Stefan Zager, Michal Mocny, Scott Haseley, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, alexmo...@chromium.org, creis...@chromium.org, navigation...@chromium.org, mac-r...@chromium.org, blink-revi...@chromium.org, dtapuska+...@chromium.org, zol...@webkit.org, blink-...@chromium.org, core-timi...@chromium.org, speed-metrics...@chromium.org

Attention needed from Michal Mocny, Scott Haseley and Stefan Zager

Johannes Henkel voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention is currently required from:

Michal Mocny
Scott Haseley
Stefan Zager

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Michal Mocny (Gerrit)

unread,

Jul 10, 2026, 7:49:56 AM (yesterday) Jul 10

to Johannes Henkel, Stefan Zager, Scott Haseley, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, alexmo...@chromium.org, creis...@chromium.org, navigation...@chromium.org, mac-r...@chromium.org, blink-revi...@chromium.org, dtapuska+...@chromium.org, zol...@webkit.org, blink-...@chromium.org, core-timi...@chromium.org, speed-metrics...@chromium.org

Attention needed from Johannes Henkel, Scott Haseley and Stefan Zager

Michal Mocny voted and added 3 comments

Votes added by Michal Mocny

Code-Review

+1

3 comments

File content/renderer/render_view_browsertest_mac.mm

Line 90, Patchset 8 (Latest): input::NativeWebKeyboardEvent arrowDownKeyDown(base::apple::OwnedNSEvent(

Michal Mocny . unresolved

Previously this test would create new events (create new objects) for each call to SendNativeKeyEvent() and now it sends the exact same value. I don't know if there are potentially any differences / issues with that.

File third_party/blink/renderer/core/layout/layout_shift_tracker_test.cc

Line 579, Patchset 8 (Latest): event1.SetTimeStamp(base::TimeTicks::Now());

Michal Mocny . resolved

This is fine for now, but especially since this is our code, would be good to consolidate how we similate input with shared helpers across similar perf timeline tests (eventually).

File third_party/blink/renderer/core/timing/soft_navigation_context.cc

Line 38, Patchset 8 (Latest): // If this trips in a unittest, you may need to set the timestamps on the

Michal Mocny . resolved

Sweet!

Open in Gerrit

Related details

Attention is currently required from:

Johannes Henkel
Scott Haseley
Stefan Zager

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Scott Haseley (Gerrit)

unread,

Jul 10, 2026, 12:05:11 PM (yesterday) Jul 10

to Johannes Henkel, Michal Mocny, Stefan Zager, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, alexmo...@chromium.org, creis...@chromium.org, navigation...@chromium.org, mac-r...@chromium.org, blink-revi...@chromium.org, dtapuska+...@chromium.org, zol...@webkit.org, blink-...@chromium.org, core-timi...@chromium.org, speed-metrics...@chromium.org

Attention needed from Johannes Henkel and Stefan Zager

Scott Haseley voted and added 1 comment

Votes added by Scott Haseley

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 8 (Latest):

Scott Haseley . resolved

LGTM % Michal's comment

Open in Gerrit

Related details

Attention is currently required from:

Johannes Henkel
Stefan Zager

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Johannes Henkel (Gerrit)

unread,

Jul 10, 2026, 12:30:37 PM (yesterday) Jul 10

to Scott Haseley, Michal Mocny, Stefan Zager, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, alexmo...@chromium.org, creis...@chromium.org, navigation...@chromium.org, mac-r...@chromium.org, blink-revi...@chromium.org, dtapuska+...@chromium.org, zol...@webkit.org, blink-...@chromium.org, core-timi...@chromium.org, speed-metrics...@chromium.org

Attention needed from Stefan Zager

Johannes Henkel voted and added 1 comment

Votes added by Johannes Henkel

Commit-Queue

+0

1 comment

File content/renderer/render_view_browsertest_mac.mm

Line 90, Patchset 8: input::NativeWebKeyboardEvent arrowDownKeyDown(base::apple::OwnedNSEvent(

Michal Mocny . resolved

Previously this test would create new events (create new objects) for each call to SendNativeKeyEvent() and now it sends the exact same value. I don't know if there are potentially any differences / issues with that.

Johannes Henkel

Good point, made it so it's four different events.

Open in Gerrit

Related details

Attention is currently required from:

Stefan Zager

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Stefan Zager (Gerrit)

unread,

Jul 10, 2026, 1:46:10 PM (yesterday) Jul 10

to Johannes Henkel, Scott Haseley, Michal Mocny, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, alexmo...@chromium.org, creis...@chromium.org, navigation...@chromium.org, mac-r...@chromium.org, blink-revi...@chromium.org, dtapuska+...@chromium.org, zol...@webkit.org, blink-...@chromium.org, core-timi...@chromium.org, speed-metrics...@chromium.org

Attention needed from Johannes Henkel

Stefan Zager voted and added 1 comment

Votes added by Stefan Zager

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 9 (Latest):

Stefan Zager . resolved

lgtm

Open in Gerrit

Related details

Attention is currently required from:

Johannes Henkel

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Johannes Henkel (Gerrit)

unread,

Jul 10, 2026, 2:02:00 PM (yesterday) Jul 10

to Stefan Zager, Scott Haseley, Michal Mocny, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, alexmo...@chromium.org, creis...@chromium.org, navigation...@chromium.org, mac-r...@chromium.org, blink-revi...@chromium.org, dtapuska+...@chromium.org, zol...@webkit.org, blink-...@chromium.org, core-timi...@chromium.org, speed-metrics...@chromium.org

Johannes Henkel voted and added 1 comment

Votes added by Johannes Henkel

Commit-Queue

+2

1 comment

Patchset-level comments

File-level comment, Patchset 9 (Latest):

Johannes Henkel . resolved

Thanks a lot!

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Jul 10, 2026, 2:07:06 PM (yesterday) Jul 10

to Johannes Henkel, Stefan Zager, Scott Haseley, Michal Mocny, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, alexmo...@chromium.org, creis...@chromium.org, navigation...@chromium.org, mac-r...@chromium.org, blink-revi...@chromium.org, dtapuska+...@chromium.org, zol...@webkit.org, blink-...@chromium.org, core-timi...@chromium.org, speed-metrics...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

[soft navs] CHECK(!TimeOrigin().is_null()) for any SoftNavigationContext

This fixes the remaining tests that create input events that don't
have a timestamp by calling SetTimeStamp(base::TimeTicks::Now()), and
adds a CHECK statement to the constructor of SoftNavigationContext.

Change-Id: I6b390ea920235d60e2ddf6787efacf1dcfe3f827

Bug: 490814752

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8072864

Reviewed-by: Scott Haseley <shas...@chromium.org>

Commit-Queue: Johannes Henkel <joha...@chromium.org>

Reviewed-by: Stefan Zager <sza...@chromium.org>

Reviewed-by: Michal Mocny <mmo...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1660393}

Files:

M content/renderer/render_view_browsertest_mac.mm
M third_party/blink/renderer/core/input/event_handler_test.cc
M third_party/blink/renderer/core/layout/layout_shift_tracker_test.cc
M third_party/blink/renderer/core/timing/soft_navigation_context.cc

Change size: S

Delta: 4 files changed, 31 insertions(+), 17 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Michal Mocny, +1 by Stefan Zager, +1 by Scott Haseley

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

luci-bisection@appspot.gserviceaccount.com (Gerrit)

unread,

Jul 10, 2026, 9:30:20 PM (18 hours ago) Jul 10

to Johannes Henkel, Chromium LUCI CQ, Stefan Zager, Scott Haseley, Michal Mocny, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, alexmo...@chromium.org, creis...@chromium.org, navigation...@chromium.org, mac-r...@chromium.org, blink-revi...@chromium.org, dtapuska+...@chromium.org, zol...@webkit.org, blink-...@chromium.org, core-timi...@chromium.org, speed-metrics...@chromium.org

luci-bi...@appspot.gserviceaccount.com has created a revert of this change

Open original change

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chrome Crash (Prod) (Gerrit)

unread,

8:19 AM (7 hours ago) 8:19 AM

to Johannes Henkel, Chromium LUCI CQ, Stefan Zager, Scott Haseley, Michal Mocny, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, alexmo...@chromium.org, creis...@chromium.org, navigation...@chromium.org, mac-r...@chromium.org, blink-revi...@chromium.org, dtapuska+...@chromium.org, zol...@webkit.org, blink-...@chromium.org, core-timi...@chromium.org, speed-metrics...@chromium.org

Chrome Crash (Prod) has created a revert of this change

satisfied_requirement

open

diffy

Reply all

Reply to author

Forward

[soft navs] CHECK(!TimeOrigin().is_null()) for any SoftNavigationContext [chromium/src : main]

Johannes Henkel (Gerrit)

New activity on the change

Related details

Johannes Henkel (Gerrit)

Johannes Henkel voted Commit-Queue+1

Related details

Michal Mocny (Gerrit)

Michal Mocny voted and added 3 comments

Votes added by Michal Mocny

3 comments

Related details

Scott Haseley (Gerrit)

Scott Haseley voted and added 1 comment

Votes added by Scott Haseley

1 comment

Related details

Johannes Henkel (Gerrit)

Johannes Henkel voted and added 1 comment

Votes added by Johannes Henkel

1 comment

Related details

Stefan Zager (Gerrit)

Stefan Zager voted and added 1 comment

Votes added by Stefan Zager

1 comment

Related details

Johannes Henkel (Gerrit)

Johannes Henkel voted and added 1 comment

Votes added by Johannes Henkel

1 comment

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information

luci-bisection@appspot.gserviceaccount.com (Gerrit)

luci-bi...@appspot.gserviceaccount.com has created a revert of this change

Related details

Chrome Crash (Prod) (Gerrit)

Chrome Crash (Prod) has created a revert of this change