win: use /maxilksize on link to avoid LNK1248 'exceeds maximum allowable size (80000000)' (issue 740603002 by scottmg@chromium.org)

sco...@chromium.org

unread,

Nov 18, 2014, 6:49:28 PM11/18/14

to tha...@chromium.org, chromium...@chromium.org

Reviewers: Nico,

Description:
win: use /maxilksize on link to avoid LNK1248 'exceeds maximum allowable
size
(80000000)'

This error is happening more frequently on various configurations
and targets after the switch to VS2013 Update 4. MS dev rel suggested
the flag as a workaround and it appears to alleviate the problem.

This also reverts https://codereview.chromium.org/725173003 as it is
no longer required.

R=tha...@chromium.org
BUG=432748

Please review this at https://codereview.chromium.org/740603002/

Base URL: https://chromium.googlesource.com/chromium/src.git@master

Affected files (+7, -2 lines):
M build/common.gypi
M chrome/chrome_tests_unit.gypi

Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index
41ecb9cb2f994dad76a0e98e1574bff63ec3c6a1..5961e0d5f22ade029530c3538b67cc0ab3ab69c3
100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -3163,6 +3163,12 @@
'credui.lib',
'netapi32.lib',
],
+ 'AdditionalOptions': [
+ # Suggested by Microsoft Devrel to avoid
+ # LINK : fatal error LNK1248: image size (80000000)
exceeds maximum allowable size (80000000)
+ # which started happening more regularly after VS2013 Update
4.
+ '/maxilksize:2147483647',
+ ],
},
},
},
Index: chrome/chrome_tests_unit.gypi
diff --git a/chrome/chrome_tests_unit.gypi b/chrome/chrome_tests_unit.gypi
index
160ad2eac373b7c8938975e8c29c5127eb6c8b39..4369083b6c4b8b946b238f7367d96aa4dcb73e26
100644
--- a/chrome/chrome_tests_unit.gypi
+++ b/chrome/chrome_tests_unit.gypi
@@ -1962,8 +1962,7 @@
'msvs_settings': {
'VCLinkerTool': {
'conditions': [
- # Incremental linking on x64 causes LNK1248.
- ['incremental_chrome_dll==1 and target_arch!="x64"', {
+ ['incremental_chrome_dll==1', {
'UseLibraryDependencyInputs': "true",
}],
],