Add category-specific query latency histograms for AtMemory [chromium/src : main]

0 views

Skip to first unread message

Jan Keitel (Gerrit)

unread,

5:21 AM (3 hours ago) 5:21 AM

to Sophie Chang, Ireneusz Szulc, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, browser-comp...@chromium.org

Attention needed from Ireneusz Szulc and Sophie Chang

Jan Keitel added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Jan Keitel . unresolved

PTAL. I handled the case with multiple returned types of data a bit differently from what was discussed in the bug.

Let me know what you prefer - thanks!

Open in Gerrit

Related details

Attention is currently required from:

Ireneusz Szulc
Sophie Chang

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Ireneusz Szulc (Gerrit)

unread,

7:48 AM (1 hour ago) 7:48 AM

to Jan Keitel, Sophie Chang, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, browser-comp...@chromium.org

Attention needed from Jan Keitel and Sophie Chang

Ireneusz Szulc voted and added 1 comment

Votes added by Ireneusz Szulc

Code-Review

1 comment

File components/autofill/core/browser/at_memory/at_memory_metrics_recorder.cc

Line 177, Patchset 1 (Latest):std::string_view GetQueryLatencyCategory(const MemorySearchResults& result) {

Ireneusz Szulc . unresolved

nitpick: it can be called `GetQueryDataTypeCategory` as it's not latency-specific.