a11y sync: Add icon to the conflict resolution dialog header [chromium/src : main]
0 views
Skip to first unread message
Antonio Gomes Netto (Gerrit)
May 4, 2026, 3:57:21 PM (17 hours ago) May 4
to Antonio Gomes Netto, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, Aida Zolic, Katie D, chromium...@chromium.org, (Julie)Jeongeun Kim, abigailbk...@google.com, dtseng...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
Attention needed from Aida Zolic and Katie D
Antonio Gomes Netto voted and added 1 comment![]( "Open in Gerrit")
Votes added by Antonio Gomes Netto
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Aida Zolic
- Katie D
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Katie D (Gerrit)
May 4, 2026, 6:40:19 PM (14 hours ago) May 4
to Antonio Gomes Netto, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, Aida Zolic, chromium...@chromium.org, (Julie)Jeongeun Kim, abigailbk...@google.com, dtseng...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
Attention needed from Aida Zolic and Antonio Gomes Netto
Katie D voted and added 2 comments![]( "Open in Gerrit")
Votes added by Katie D
| Code-Review | +1 |
2 comments
Patchset-level comments
Katie D . resolved
LGTM % chromevox testing
File ash/accessibility/accessibility_prefs_merge_conflict_dialog.cc
Line 150, Patchset 2 (Latest):
SetTopContentView(views::Builder<views::ImageView>()Katie D . unresolved
do we need to explicitly set the content description to nothing or ignored for a11y? (does this work fine with ChromeVox?)
Related details
Attention is currently required from:
- Aida Zolic
- Antonio Gomes Netto
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Antonio Gomes Netto (Gerrit)
May 4, 2026, 10:28:09 PM (10 hours ago) May 4
to Antonio Gomes Netto, Katie D, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, Aida Zolic, chromium...@chromium.org, (Julie)Jeongeun Kim, abigailbk...@google.com, dtseng...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
Attention needed from Aida Zolic
Antonio Gomes Netto added 1 comment![]( "Open in Gerrit")
File ash/accessibility/accessibility_prefs_merge_conflict_dialog.cc
Line 150, Patchset 2 (Latest):
SetTopContentView(views::Builder<views::ImageView>()Katie D . resolved
do we need to explicitly set the content description to nothing or ignored for a11y? (does this work fine with ChromeVox?)
Antonio Gomes Netto
The icon is purely decorative in this case, and it implicitly ignored for a11y. It does not get focused, and ChromeVox does not work with it.
Related details
Attention is currently required from:
- Aida Zolic
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Aida Zolic (Gerrit)
6:38 AM (2 hours ago) 6:38 AM
to Antonio Gomes Netto, Katie D, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, (Julie)Jeongeun Kim, abigailbk...@google.com, dtseng...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
Attention needed from Antonio Gomes Netto
Aida Zolic voted and added 1 comment![]( "Open in Gerrit")
Votes added by Aida Zolic
| Code-Review | +1 |
1 comment
File ash/accessibility/accessibility_prefs_merge_conflict_dialog.cc
Line 150, Patchset 2 (Latest):
SetTopContentView(views::Builder<views::ImageView>()Katie D . unresolved
Antonio Gomes Nettodo we need to explicitly set the content description to nothing or ignored for a11y? (does this work fine with ChromeVox?)
The icon is purely decorative in this case, and it implicitly ignored for a11y. It does not get focused, and ChromeVox does not work with it.
Attention is currently required from:
- Antonio Gomes Netto
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Antonio Gomes Netto (Gerrit)
7:29 AM (1 hour ago) 7:29 AM
to Antonio Gomes Netto, Aida Zolic, Katie D, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, (Julie)Jeongeun Kim, abigailbk...@google.com, dtseng...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
Antonio Gomes Netto added 1 comment![]( "Open in Gerrit")
File ash/accessibility/accessibility_prefs_merge_conflict_dialog.cc
Line 150, Patchset 2 (Latest):
SetTopContentView(views::Builder<views::ImageView>()Katie D . resolved
Antonio Gomes Nettodo we need to explicitly set the content description to nothing or ignored for a11y? (does this work fine with ChromeVox?)
Aida ZolicThe icon is purely decorative in this case, and it implicitly ignored for a11y. It does not get focused, and ChromeVox does not work with it.
Just to confirm, this is how other icons behave in dialogs?
Antonio Gomes Netto
This API is used once else in the source base [1]. This dialog shows up coincidentally in the second login for me and informs the user about restore session. It icon isnt chromevox-aware there, and purely informative/decorative.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Antonio Gomes Netto (Gerrit)
7:53 AM (1 hour ago) 7:53 AM
to Antonio Gomes Netto, Aida Zolic, Katie D, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, (Julie)Jeongeun Kim, abigailbk...@google.com, dtseng...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
Antonio Gomes Netto voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Chromium LUCI CQ (Gerrit)
8:02 AM (1 hour ago) 8:02 AM
to Antonio Gomes Netto, Aida Zolic, Katie D, android-bu...@system.gserviceaccount.com, Akihiro Ota, chromium...@chromium.org, (Julie)Jeongeun Kim, abigailbk...@google.com, dtseng...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
a11y sync: Add icon to the conflict resolution dialog header
... as per the UX [1] - see [2] for an screenshot.
[1] https://docs.google.com/presentation/d/14XfLlq3pksDNjM8se_HFibB1EK5MvSwMzT4ookN5gcU/
[2] https://drive.google.com/file/d/1QE1_etosBX8_SB-BzW8L2HS09xVpEwaq/view?usp=sharing
R=aida...@chromium.org, ka...@chromium.org
Bug: 479890756, 507302792
Change-Id: I05c264472723f8248ba1cdff8a129a011004b73c
Reviewed-by: Katie D <ka...@chromium.org>
Reviewed-by: Aida Zolic <aida...@chromium.org>
Commit-Queue: Antonio Gomes Netto <toni...@igalia.com>
Cr-Commit-Position: refs/heads/main@{#1625330}
Files:
- M ash/accessibility/accessibility_prefs_merge_conflict_dialog.cc
Change size: XS
Delta: 1 file changed, 5 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Katie D, +1 by Aida Zolic
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages