[iOS] Present tabpicker through picker presenter and cleanup coordinator [chromium/src : main]

0 views
Skip to first unread message

Radu Nitescu (Gerrit)

unread,
May 4, 2026, 9:06:23 AM (24 hours ago) May 4
to Ameur Hosni, Christian Xu, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Ameur Hosni and Christian Xu

Radu Nitescu voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Ameur Hosni
  • Christian Xu
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic01259807967888359cba81e3be52989f24a69b0
Gerrit-Change-Number: 7806238
Gerrit-PatchSet: 2
Gerrit-Owner: Radu Nitescu <radun...@google.com>
Gerrit-Reviewer: Ameur Hosni <ameur...@google.com>
Gerrit-Reviewer: Christian Xu <chris...@chromium.org>
Gerrit-Reviewer: Radu Nitescu <radun...@google.com>
Gerrit-Attention: Ameur Hosni <ameur...@google.com>
Gerrit-Attention: Christian Xu <chris...@chromium.org>
Gerrit-Comment-Date: Mon, 04 May 2026 13:06:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Christian Xu (Gerrit)

unread,
May 4, 2026, 4:38:07 PM (16 hours ago) May 4
to Radu Nitescu, Ameur Hosni, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Ameur Hosni and Radu Nitescu

Christian Xu voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Ameur Hosni
  • Radu Nitescu
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic01259807967888359cba81e3be52989f24a69b0
    Gerrit-Change-Number: 7806238
    Gerrit-PatchSet: 2
    Gerrit-Owner: Radu Nitescu <radun...@google.com>
    Gerrit-Reviewer: Ameur Hosni <ameur...@google.com>
    Gerrit-Reviewer: Christian Xu <chris...@chromium.org>
    Gerrit-Reviewer: Radu Nitescu <radun...@google.com>
    Gerrit-Attention: Ameur Hosni <ameur...@google.com>
    Gerrit-Attention: Radu Nitescu <radun...@google.com>
    Gerrit-Comment-Date: Mon, 04 May 2026 20:37:47 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Radu Nitescu (Gerrit)

    unread,
    May 4, 2026, 5:25:40 PM (15 hours ago) May 4
    to Christian Xu, Ameur Hosni, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
    Attention needed from Ameur Hosni

    Radu Nitescu voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Ameur Hosni
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic01259807967888359cba81e3be52989f24a69b0
    Gerrit-Change-Number: 7806238
    Gerrit-PatchSet: 3
    Gerrit-Owner: Radu Nitescu <radun...@google.com>
    Gerrit-Reviewer: Ameur Hosni <ameur...@google.com>
    Gerrit-Reviewer: Christian Xu <chris...@chromium.org>
    Gerrit-Reviewer: Radu Nitescu <radun...@google.com>
    Gerrit-Attention: Ameur Hosni <ameur...@google.com>
    Gerrit-Comment-Date: Mon, 04 May 2026 21:25:23 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Radu Nitescu (Gerrit)

    unread,
    3:03 AM (6 hours ago) 3:03 AM
    to Christian Xu, Ameur Hosni, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
    Attention needed from Ameur Hosni

    Radu Nitescu voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Ameur Hosni
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic01259807967888359cba81e3be52989f24a69b0
    Gerrit-Change-Number: 7806238
    Gerrit-PatchSet: 4
    Gerrit-Owner: Radu Nitescu <radun...@google.com>
    Gerrit-Reviewer: Ameur Hosni <ameur...@google.com>
    Gerrit-Reviewer: Christian Xu <chris...@chromium.org>
    Gerrit-Reviewer: Radu Nitescu <radun...@google.com>
    Gerrit-Attention: Ameur Hosni <ameur...@google.com>
    Gerrit-Comment-Date: Tue, 05 May 2026 07:03:25 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Radu Nitescu (Gerrit)

    unread,
    5:38 AM (3 hours ago) 5:38 AM
    to Christian Xu, Ameur Hosni, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
    Attention needed from Ameur Hosni

    Radu Nitescu voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Ameur Hosni
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic01259807967888359cba81e3be52989f24a69b0
    Gerrit-Change-Number: 7806238
    Gerrit-PatchSet: 5
    Gerrit-Owner: Radu Nitescu <radun...@google.com>
    Gerrit-Reviewer: Ameur Hosni <ameur...@google.com>
    Gerrit-Reviewer: Christian Xu <chris...@chromium.org>
    Gerrit-Reviewer: Radu Nitescu <radun...@google.com>
    Gerrit-Attention: Ameur Hosni <ameur...@google.com>
    Gerrit-Comment-Date: Tue, 05 May 2026 09:37:57 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Radu Nitescu (Gerrit)

    unread,
    7:15 AM (1 hour ago) 7:15 AM
    to Christian Xu, Ameur Hosni, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
    Attention needed from Ameur Hosni

    Radu Nitescu voted and added 1 comment

    Votes added by Radu Nitescu

    Auto-Submit+1

    1 comment

    Patchset-level comments
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Ameur Hosni
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ic01259807967888359cba81e3be52989f24a69b0
      Gerrit-Change-Number: 7806238
      Gerrit-PatchSet: 5
      Gerrit-Owner: Radu Nitescu <radun...@google.com>
      Gerrit-Reviewer: Ameur Hosni <ameur...@google.com>
      Gerrit-Reviewer: Christian Xu <chris...@chromium.org>
      Gerrit-Reviewer: Radu Nitescu <radun...@google.com>
      Gerrit-Attention: Ameur Hosni <ameur...@google.com>
      Gerrit-Comment-Date: Tue, 05 May 2026 11:14:54 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Radu Nitescu (Gerrit)

      unread,
      8:16 AM (26 minutes ago) 8:16 AM
      to Christian Xu, Ameur Hosni, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
      Attention needed from Ameur Hosni

      Radu Nitescu voted and added 1 comment

      Votes added by Radu Nitescu

      Auto-Submit+1
      Commit-Queue+2

      1 comment

      Patchset-level comments
      File-level comment, Patchset 5:
      Radu Nitescu . resolved
      Radu Nitescu

      Done

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Ameur Hosni
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Ic01259807967888359cba81e3be52989f24a69b0
        Gerrit-Change-Number: 7806238
        Gerrit-PatchSet: 6
        Gerrit-Owner: Radu Nitescu <radun...@google.com>
        Gerrit-Reviewer: Ameur Hosni <ameur...@google.com>
        Gerrit-Reviewer: Christian Xu <chris...@chromium.org>
        Gerrit-Reviewer: Radu Nitescu <radun...@google.com>
        Gerrit-Attention: Ameur Hosni <ameur...@google.com>
        Gerrit-Comment-Date: Tue, 05 May 2026 12:16:26 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        Comment-In-Reply-To: Radu Nitescu <radun...@google.com>
        satisfied_requirement
        open
        diffy
        Reply all
        Reply to author
        Forward
        0 new messages