Fix Float-cast-overflow in IO rootMargin [chromium/src : main]
0 views
Skip to first unread message
Philip Rogers (Gerrit)
Jan 9, 2026, 7:47:57 PM (20 hours ago) Jan 9
to Stefan Zager, chromium...@chromium.org, blink-...@chromium.org
Attention needed from Stefan Zager
Philip Rogers voted![]( "Open in Gerrit")
| Auto-Submit | +1 |
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Stefan Zager
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Stefan Zager (Gerrit)
Jan 9, 2026, 10:02:24 PM (18 hours ago) Jan 9
to Philip Rogers, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org
Attention needed from Philip Rogers
Stefan Zager voted and added 1 comment![]( "Open in Gerrit")
Attention is currently required from:
- Philip Rogers
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jan 9, 2026, 10:05:57 PM (18 hours ago) Jan 9
to Philip Rogers, Stefan Zager, chromium...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Fix Float-cast-overflow in IO rootMargin
Percentages in rootMargin can exceed the range of a 32-bit integer,
causing a float-cast-overflow when IntValue() is called. This patch
fixes the issue by using Percent(), which returns a float, for
percentage values.
Fixed: 441524792
Change-Id: If2bb452673c4dd190a23248036b75b5f624b4711
Auto-Submit: Philip Rogers <p...@chromium.org>
Commit-Queue: Stefan Zager <sza...@chromium.org>
Reviewed-by: Stefan Zager <sza...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1567337}
Files:
- M third_party/blink/renderer/core/intersection_observer/intersection_observer.cc
- M third_party/blink/renderer/core/intersection_observer/intersection_observer_test.cc
Change size: S
Delta: 2 files changed, 20 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Stefan Zager
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages