Revert "[omnibox][webui] SubframeTaskBrowserTest & SubframeTaskPDFBrowserTest" [chromium/src : main]
0 views
Skip to first unread message
luci-bisection@appspot.gserviceaccount.com (Gerrit)
Feb 7, 2026, 1:55:37 PM (12 hours ago) Feb 7
to Michael Wojcicka, Chromium LUCI CQ, manuk hovanesian, chromium...@chromium.org
Attention needed from Michael Wojcicka and manuk hovanesian
luci-bi...@appspot.gserviceaccount.com has uploaded the change for review![]( "Open in Gerrit")
luci-bi...@appspot.gserviceaccount.com would like Michael Wojcicka, Chromium LUCI CQ and manuk hovanesian to review this change.
Commit message
Revert "[omnibox][webui] SubframeTaskBrowserTest & SubframeTaskPDFBrowserTest"
This reverts commit 1b476b7b72ace268b71fa396d3d7bbeba1bdd02c.
Reason for revert:
LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/6680828655435776
Sample build with failed test: https://ci.chromium.org/b/8690566305596659585
Affected test(s):
[://chrome/test\:browser_tests!gtest::SubframeTaskPDFBrowserTest#TaskManagerShowsIncognitoPDFSubframeTask/All.0](https://ci.chromium.org/ui/test/chromium/:%2F%2Fchrome%2Ftest%5C:browser_tests%21gtest::SubframeTaskPDFBrowserTest%23TaskManagerShowsIncognitoPDFSubframeTask%2FAll.0?q=VHash%3A21063c918fd9bbef)
[://chrome/test\:browser_tests!gtest::SubframeTaskPDFBrowserTest#TaskManagerShowsIncognitoPDFSubframeTask/All.1](https://ci.chromium.org/ui/test/chromium/:%2F%2Fchrome%2Ftest%5C:browser_tests%21gtest::SubframeTaskPDFBrowserTest%23TaskManagerShowsIncognitoPDFSubframeTask%2FAll.1?q=VHash%3A21063c918fd9bbef)
[://chrome/test\:browser_tests!gtest::SubframeTaskPDFBrowserTest#TaskManagerShowsPDFSubframeTask/All.0](https://ci.chromium.org/ui/test/chromium/:%2F%2Fchrome%2Ftest%5C:browser_tests%21gtest::SubframeTaskPDFBrowserTest%23TaskManagerShowsPDFSubframeTask%2FAll.0?q=VHash%3A21063c918fd9bbef)
[://chrome/test\:browser_tests!gtest::SubframeTaskPDFBrowserTest#TaskManagerShowsPDFSubframeTask/All.1](https://ci.chromium.org/ui/test/chromium/:%2F%2Fchrome%2Ftest%5C:browser_tests%21gtest::SubframeTaskPDFBrowserTest%23TaskManagerShowsPDFSubframeTask%2FAll.1?q=VHash%3A21063c918fd9bbef)
If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F6680828655435776&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F7546190&type=BUG
Original change's description:
> [omnibox][webui] SubframeTaskBrowserTest & SubframeTaskPDFBrowserTest
>
> Enable `kWebUIOmniboxPopup` & `kWebUIOmniboxAimPopup` and update 6
> failing tests to pass with the features enabled:
>
> SubframeTaskBrowserTest.TaskManagerHungSubframe
> SubframeTaskBrowserTest.TaskManagerShowsSubframeTasks
> All/SubframeTaskPDFBrowserTest.TaskManagerShowsIncognitoPDFSubframeTask/0
> All/SubframeTaskPDFBrowserTest.TaskManagerShowsIncognitoPDFSubframeTask/1
> All/SubframeTaskPDFBrowserTest.TaskManagerShowsPDFSubframeTask/0
> All/SubframeTaskPDFBrowserTest.TaskManagerShowsPDFSubframeTask/1
>
> The tests now expect 2 additional omnibox tasks.
>
> Also makes the test expectations more complete:
> EXPECT_THAT(actual_tasks, ElementsAre("task_0", "task_1", "task_2"))
>
> instead of previously:
> EXPECT_TRUE(StartsWith(actual_tasks[2], "task")
>
> Bug: 452061489
> Change-Id: I4866a6249728e99b4a3cac34433360aca99753ba
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7546190
> Auto-Submit: manuk hovanesian <man...@chromium.org>
> Reviewed-by: Michael Wojcicka <mw...@google.com>
> Commit-Queue: manuk hovanesian <man...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1581215}
>
Bug: 452061489
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I51849f9f93942dd74e6977f74793ca2ae4be8212
Change diff
Change information
Files:
- M chrome/browser/task_manager/mock_web_contents_task_manager.h
- M chrome/browser/task_manager/providers/web_contents/subframe_task_browsertest.cc
Change size: L
Delta: 2 files changed, 87 insertions(+), 169 deletions(-)
Related details
Attention is currently required from:
- Michael Wojcicka
- manuk hovanesian
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
luci-bisection@appspot.gserviceaccount.com (Gerrit)
Feb 7, 2026, 1:55:53 PM (12 hours ago) Feb 7
to Rubber Stamper, Michael Wojcicka, Chromium LUCI CQ, manuk hovanesian, chromium...@chromium.org
Attention needed from Michael Wojcicka and manuk hovanesian
Message from luci-bi...@appspot.gserviceaccount.com![]( "Open in Gerrit")
LUCI Bisection could not automatically submit this revert because LUCI Bisection has not yet support auto-commit of revert CL for test failure.
Related details
Attention is currently required from:
- Michael Wojcicka
- manuk hovanesian
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rubber Stamper (Gerrit)
Feb 7, 2026, 1:56:12 PM (12 hours ago) Feb 7
to luci-bi...@appspot.gserviceaccount.com, Michael Wojcicka, Chromium LUCI CQ, manuk hovanesian, chromium...@chromium.org
Attention needed from Michael Wojcicka and manuk hovanesian
Rubber Stamper voted Bot-Commit+1![]( "Open in Gerrit")
| Bot-Commit | +1 |
Related details
Attention is currently required from:
- Michael Wojcicka
- manuk hovanesian
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages