[Code health] Use format specifiers in chromecast/shell [chromium/src : main]

0 views
Skip to first unread message

Gazal Agarwal (Gerrit)

unread,
Jul 19, 2026, 8:32:58 PM (2 days ago) Jul 19
to Shawn Quereshi, Chromium LUCI CQ, chromium...@chromium.org, halliwe...@chromium.org
Attention needed from Shawn Quereshi

Gazal Agarwal voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Shawn Quereshi
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8f98c173209d0f83cad0fcf7fa39a74d3066a216
Gerrit-Change-Number: 8121380
Gerrit-PatchSet: 2
Gerrit-Owner: Gazal Agarwal <aga...@google.com>
Gerrit-Reviewer: Gazal Agarwal <aga...@google.com>
Gerrit-Reviewer: Shawn Quereshi <sha...@google.com>
Gerrit-Attention: Shawn Quereshi <sha...@google.com>
Gerrit-Comment-Date: Mon, 20 Jul 2026 00:32:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Shawn Quereshi (Gerrit)

unread,
Jul 20, 2026, 12:14:55 PM (yesterday) Jul 20
to Gazal Agarwal, Chromium LUCI CQ, chromium...@chromium.org, halliwe...@chromium.org
Attention needed from Gazal Agarwal

Shawn Quereshi voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Gazal Agarwal
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8f98c173209d0f83cad0fcf7fa39a74d3066a216
Gerrit-Change-Number: 8121380
Gerrit-PatchSet: 2
Gerrit-Owner: Gazal Agarwal <aga...@google.com>
Gerrit-Reviewer: Gazal Agarwal <aga...@google.com>
Gerrit-Reviewer: Shawn Quereshi <sha...@google.com>
Gerrit-Attention: Gazal Agarwal <aga...@google.com>
Gerrit-Comment-Date: Mon, 20 Jul 2026 16:14:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Jul 20, 2026, 1:08:46 PM (yesterday) Jul 20
to Gazal Agarwal, Shawn Quereshi, chromium...@chromium.org, halliwe...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[Code health] Use format specifiers in chromecast/shell

Convert debug log statements in Chromecast shell helper components to
use format specifiers instead of string concatenation. This avoids
unnecessary StringBuilder allocations at runtime when logging is
disabled.

This applies to CastContentWindowAndroid, CastCrashUploader,
CastWebContentsComponent, CastWebContentsSurfaceHelper, and
TaskRemovedMonitorService.

TAG=agy CONV=3d7bfbf2-c0bf-4e72-9548-8bc718bee88a
Bug: b:529082276
Change-Id: I8f98c173209d0f83cad0fcf7fa39a74d3066a216
Reviewed-by: Shawn Quereshi <sha...@google.com>
Auto-Submit: Gazal Agarwal <aga...@google.com>
Commit-Queue: Shawn Quereshi <sha...@google.com>
Cr-Commit-Position: refs/heads/main@{#1664772}
Files:
  • M chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastContentWindowAndroid.java
  • M chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastCrashUploader.java
  • M chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastWebContentsComponent.java
  • M chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastWebContentsSurfaceHelper.java
  • M chromecast/browser/android/apk/src/org/chromium/chromecast/shell/TaskRemovedMonitorService.java
Change size: M
Delta: 5 files changed, 24 insertions(+), 27 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Shawn Quereshi
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8f98c173209d0f83cad0fcf7fa39a74d3066a216
Gerrit-Change-Number: 8121380
Gerrit-PatchSet: 3
Gerrit-Owner: Gazal Agarwal <aga...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Gazal Agarwal <aga...@google.com>
Gerrit-Reviewer: Shawn Quereshi <sha...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages