[Vertical Tabs] Adds onHover for tab group header [chromium/src : main]

0 views

Skip to first unread message

Joel Tan-Aristy (Gerrit)

unread,

Aug 7, 2026, 7:39:46 PM (2 days ago) Aug 7

to Gazal Agarwal, Chromium LUCI CQ, chromium...@chromium.org, davidj...@chromium.org, gogeral...@chromium.org, mattsimm...@chromium.org, meilian...@chromium.org, wychen...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org

Attention needed from Gazal Agarwal

Joel Tan-Aristy voted Auto-Submit+1

Auto-Submit

Open in Gerrit

Related details

Attention is currently required from:

Gazal Agarwal

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Gazal Agarwal (Gerrit)

unread,

3:57 PM (4 hours ago) 3:57 PM

to Joel Tan-Aristy, Chromium LUCI CQ, chromium...@chromium.org, davidj...@chromium.org, gogeral...@chromium.org, mattsimm...@chromium.org, meilian...@chromium.org, wychen...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org

Attention needed from Joel Tan-Aristy

Gazal Agarwal added 2 comments

File chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/vertical_tabs/VerticalTabListCoordinator.java

Line 241, Patchset 3 (Latest):

                        public void run(
                                View view, int tabId, @Nullable MotionEventInfo triggeringMotion) {
                            Token tabGroupId = tab.getTabGroupId();
                            if (tabGroupId == null) {
                                tabGroupId = model.get(TabProperties.TAB_GROUP_HEADER_ID);
                            }
                            if (tabGroupId != null) {
                                showTabGroupHeaderContextMenu(view, tabGroupId);
                            }
                        }

Gazal Agarwal . unresolved

TabListMediator ensures that this override is only called for a header. And `tabGroupId` should suffice for fetching the tab group token. You can simplify this to return if `tab.getTabGroupId()` is null.

Line 257, Patchset 3 (Latest):

                            Token tabGroupId = tab.getTabGroupId();
                            if (tabGroupId == null) {
                                tabGroupId = model.get(TabProperties.TAB_GROUP_HEADER_ID);
                            }
                            if (tabGroupId != null) {
                                showTabGroupHeaderContextMenu(view, tabGroupId);
                            }

Gazal Agarwal . unresolved

We don't support synced groups in VT. You can remove the logic and add comment like
`// Intentional no-op: Sync groups are not supported in Vertical Tabs.`