[iOS] CloseEntityImportBubble should close the entity import bottomsheet [chromium/src : main]

0 views
Skip to first unread message

Alexis Hétu (Gerrit)

unread,
8:49 AM (9 hours ago) 8:49 AM
to Vidhan Jain, Leo Zhao, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, tmartino+tran...@chromium.org
Attention needed from Vidhan Jain

Alexis Hétu voted and added 1 comment

Votes added by Alexis Hétu

Code-Review+1

1 comment

File ios/chrome/browser/browser_view/ui_bundled/browser_coordinator.mm
Line 2377, Patchset 1 (Latest): if (_autofillAISaveEntityCoordinator) {
[_autofillAISaveEntityCoordinator stop];
}
Alexis Hétu . unresolved

Is this change necessary? `[_autofillAISaveEntityCoordinator stop];` already does nothing if `_autofillAISaveEntityCoordinator` is nil.

Open in Gerrit

Related details

Attention is currently required from:
  • Vidhan Jain
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I3697e975e6f02e3aca201c06331ba4a9b4bca78d
Gerrit-Change-Number: 7691134
Gerrit-PatchSet: 1
Gerrit-Owner: Vidhan Jain <vid...@google.com>
Gerrit-Reviewer: Alexis Hétu <su...@chromium.org>
Gerrit-Reviewer: Vidhan Jain <vid...@google.com>
Gerrit-CC: Leo Zhao <leo...@google.com>
Gerrit-Attention: Vidhan Jain <vid...@google.com>
Gerrit-Comment-Date: Mon, 23 Mar 2026 12:48:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Vidhan Jain (Gerrit)

unread,
9:09 AM (9 hours ago) 9:09 AM
to Alexis Hétu, Leo Zhao, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, tmartino+tran...@chromium.org
Attention needed from Alexis Hétu

Vidhan Jain added 2 comments

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Vidhan Jain . resolved

Lost +1, could you stamp again?

File ios/chrome/browser/browser_view/ui_bundled/browser_coordinator.mm
Line 2377, Patchset 1: if (_autofillAISaveEntityCoordinator) {
[_autofillAISaveEntityCoordinator stop];
}
Alexis Hétu . resolved

Is this change necessary? `[_autofillAISaveEntityCoordinator stop];` already does nothing if `_autofillAISaveEntityCoordinator` is nil.

Vidhan Jain

Ah yes!

Open in Gerrit

Related details

Attention is currently required from:
  • Alexis Hétu
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I3697e975e6f02e3aca201c06331ba4a9b4bca78d
Gerrit-Change-Number: 7691134
Gerrit-PatchSet: 2
Gerrit-Owner: Vidhan Jain <vid...@google.com>
Gerrit-Reviewer: Alexis Hétu <su...@chromium.org>
Gerrit-Reviewer: Vidhan Jain <vid...@google.com>
Gerrit-CC: Leo Zhao <leo...@google.com>
Gerrit-Attention: Alexis Hétu <su...@chromium.org>
Gerrit-Comment-Date: Mon, 23 Mar 2026 13:09:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Alexis Hétu <su...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Alexis Hétu (Gerrit)

unread,
9:36 AM (8 hours ago) 9:36 AM
to Vidhan Jain, Leo Zhao, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, tmartino+tran...@chromium.org
Attention needed from Vidhan Jain

Alexis Hétu voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Vidhan Jain
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I3697e975e6f02e3aca201c06331ba4a9b4bca78d
    Gerrit-Change-Number: 7691134
    Gerrit-PatchSet: 2
    Gerrit-Owner: Vidhan Jain <vid...@google.com>
    Gerrit-Reviewer: Alexis Hétu <su...@chromium.org>
    Gerrit-Reviewer: Vidhan Jain <vid...@google.com>
    Gerrit-CC: Leo Zhao <leo...@google.com>
    Gerrit-Attention: Vidhan Jain <vid...@google.com>
    Gerrit-Comment-Date: Mon, 23 Mar 2026 13:36:28 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Vidhan Jain (Gerrit)

    unread,
    9:45 AM (8 hours ago) 9:45 AM
    to Alexis Hétu, Leo Zhao, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, tmartino+tran...@chromium.org

    Vidhan Jain voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I3697e975e6f02e3aca201c06331ba4a9b4bca78d
    Gerrit-Change-Number: 7691134
    Gerrit-PatchSet: 2
    Gerrit-Owner: Vidhan Jain <vid...@google.com>
    Gerrit-Reviewer: Alexis Hétu <su...@chromium.org>
    Gerrit-Reviewer: Vidhan Jain <vid...@google.com>
    Gerrit-CC: Leo Zhao <leo...@google.com>
    Gerrit-Comment-Date: Mon, 23 Mar 2026 13:45:02 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    10:07 AM (8 hours ago) 10:07 AM
    to Vidhan Jain, Alexis Hétu, Leo Zhao, chromium...@chromium.org, browser-comp...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, tmartino+tran...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [iOS] CloseEntityImportBubble should close the entity import bottomsheet

    Here's the call flow:
    1. Once the user accepts the save bubble, if it is a synchronous bubble,
    the entity is saved right away and the bottomsheet is closed.
    2. If the save is asynchronous, the view shows the loading state and
    the callback is run.
    3. AutofillAiManager::HandlePromptResult does the api call from the
    client.
    4. Once the response is received, HandleWalletUpsertResponse is called
    which depending on the response on api call, calls either
    `ShowAutofillAiLocalSaveNotification` or the error method
    `ShowAutofillAiSaveToWalletFailureNotification`
    Bug: 493913161
    Change-Id: I3697e975e6f02e3aca201c06331ba4a9b4bca78d
    Commit-Queue: Vidhan Jain <vid...@google.com>
    Reviewed-by: Alexis Hétu <su...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1603441}
    Files:
    Change size: S
    Delta: 1 file changed, 10 insertions(+), 9 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Alexis Hétu
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I3697e975e6f02e3aca201c06331ba4a9b4bca78d
    Gerrit-Change-Number: 7691134
    Gerrit-PatchSet: 3
    Gerrit-Owner: Vidhan Jain <vid...@google.com>
    Gerrit-Reviewer: Alexis Hétu <su...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Vidhan Jain <vid...@google.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages