nested app menu: Add SubmenusInAppMenuLff feature flag [chromium/src : main]

0 views
Skip to first unread message

Masa Fujita (Gerrit)

unread,
Jul 10, 2026, 12:46:24 PM (yesterday) Jul 10
to chromium...@chromium.org, Chromium Metrics Reviews, asvitkine...@chromium.org, jmedle...@chromium.org, meilian...@chromium.org, davidj...@chromium.org, wychen...@chromium.org, yusufo...@chromium.org, gogeral...@chromium.org, yuezhang...@chromium.org, browser-comp...@chromium.org, hanxi...@chromium.org, asvitki...@chromium.org, mattsimm...@chromium.org, android-web...@chromium.org

Masa Fujita has uploaded the change for review

Commit message

nested app menu: Add SubmenusInAppMenuLff feature flag

We add a flag that enables submenus in the app menu specifically on
LFFs.
Bug: 530498012
Change-Id: I6e03cdccf38f62713182e518315387daa367f8e7

Change diff


Change information

Files:
  • M chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/BookmarksItemBuilder.java
  • M chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/HistoryItemBuilder.java
  • M chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/MoreToolsItemBuilder.java
  • M chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/TabGroupItemBuilder.java
  • M chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/TabbedAppMenuPropertiesDelegate.java
  • M chrome/browser/about_flags.cc
  • M chrome/browser/flag-metadata.json
  • M chrome/browser/flag_descriptions.h
  • M chrome/browser/flags/android/chrome_feature_list.cc
  • M chrome/browser/flags/android/chrome_feature_list.h
  • M chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/ChromeFeatureList.java
  • M tools/metrics/histograms/enums.xml
Change size: M
Delta: 12 files changed, 42 insertions(+), 15 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6e03cdccf38f62713182e518315387daa367f8e7
Gerrit-Change-Number: 8069521
Gerrit-PatchSet: 1
Gerrit-Owner: Masa Fujita <mas...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Masa Fujita (Gerrit)

unread,
Jul 10, 2026, 1:02:08 PM (yesterday) Jul 10
to Chromium Metrics Reviews, chromium...@chromium.org, android-web...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, browser-comp...@chromium.org, davidj...@chromium.org, gogeral...@chromium.org, hanxi...@chromium.org, jmedle...@chromium.org, mattsimm...@chromium.org, meilian...@chromium.org, wychen...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org

Masa Fujita voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6e03cdccf38f62713182e518315387daa367f8e7
Gerrit-Change-Number: 8069521
Gerrit-PatchSet: 2
Gerrit-Owner: Masa Fujita <mas...@google.com>
Gerrit-Reviewer: Masa Fujita <mas...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Comment-Date: Fri, 10 Jul 2026 17:01:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Masa Fujita (Gerrit)

unread,
Jul 10, 2026, 1:02:55 PM (yesterday) Jul 10
to Calder Kitagawa, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, android-web...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, browser-comp...@chromium.org, davidj...@chromium.org, gogeral...@chromium.org, hanxi...@chromium.org, jmedle...@chromium.org, mattsimm...@chromium.org, meilian...@chromium.org, wychen...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org
Attention needed from Calder Kitagawa

Masa Fujita added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Masa Fujita . resolved

We want to finch on LFFs - ptal!

Open in Gerrit

Related details

Attention is currently required from:
  • Calder Kitagawa
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6e03cdccf38f62713182e518315387daa367f8e7
Gerrit-Change-Number: 8069521
Gerrit-PatchSet: 2
Gerrit-Owner: Masa Fujita <mas...@google.com>
Gerrit-Reviewer: Calder Kitagawa <ckit...@chromium.org>
Gerrit-Reviewer: Masa Fujita <mas...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Attention: Calder Kitagawa <ckit...@chromium.org>
Gerrit-Comment-Date: Fri, 10 Jul 2026 17:02:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Calder Kitagawa (Gerrit)

unread,
Jul 10, 2026, 3:02:56 PM (yesterday) Jul 10
to Masa Fujita, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, android-web...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, browser-comp...@chromium.org, davidj...@chromium.org, gogeral...@chromium.org, hanxi...@chromium.org, jmedle...@chromium.org, mattsimm...@chromium.org, meilian...@chromium.org, wychen...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org
Attention needed from Masa Fujita

Calder Kitagawa voted and added 1 comment

Votes added by Calder Kitagawa

Code-Review+1

1 comment

Patchset-level comments
Calder Kitagawa . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Masa Fujita
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6e03cdccf38f62713182e518315387daa367f8e7
Gerrit-Change-Number: 8069521
Gerrit-PatchSet: 2
Gerrit-Owner: Masa Fujita <mas...@google.com>
Gerrit-Reviewer: Calder Kitagawa <ckit...@chromium.org>
Gerrit-Reviewer: Masa Fujita <mas...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Attention: Masa Fujita <mas...@google.com>
Gerrit-Comment-Date: Fri, 10 Jul 2026 19:02:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Masa Fujita (Gerrit)

unread,
6:18 AM (11 hours ago) 6:18 AM
to Calder Kitagawa, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, android-web...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, browser-comp...@chromium.org, davidj...@chromium.org, gogeral...@chromium.org, hanxi...@chromium.org, jmedle...@chromium.org, mattsimm...@chromium.org, meilian...@chromium.org, wychen...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org
Attention needed from Calder Kitagawa

Masa Fujita voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Calder Kitagawa
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6e03cdccf38f62713182e518315387daa367f8e7
Gerrit-Change-Number: 8069521
Gerrit-PatchSet: 3
Gerrit-Owner: Masa Fujita <mas...@google.com>
Gerrit-Reviewer: Calder Kitagawa <ckit...@chromium.org>
Gerrit-Reviewer: Masa Fujita <mas...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Attention: Calder Kitagawa <ckit...@chromium.org>
Gerrit-Comment-Date: Sat, 11 Jul 2026 10:18:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Masa Fujita (Gerrit)

unread,
8:42 AM (8 hours ago) 8:42 AM
to Calder Kitagawa, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, android-web...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, browser-comp...@chromium.org, davidj...@chromium.org, gogeral...@chromium.org, hanxi...@chromium.org, jmedle...@chromium.org, mattsimm...@chromium.org, meilian...@chromium.org, wychen...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org
Attention needed from Calder Kitagawa

Masa Fujita voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Calder Kitagawa
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6e03cdccf38f62713182e518315387daa367f8e7
Gerrit-Change-Number: 8069521
Gerrit-PatchSet: 4
Gerrit-Owner: Masa Fujita <mas...@google.com>
Gerrit-Reviewer: Calder Kitagawa <ckit...@chromium.org>
Gerrit-Reviewer: Masa Fujita <mas...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Attention: Calder Kitagawa <ckit...@chromium.org>
Gerrit-Comment-Date: Sat, 11 Jul 2026 12:41:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages